Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

2022-06-02 Thread Jonathan Bedard via webkit-dev
> On Jun 2, 2022, at 4:41 PM, Geoffrey Garen wrote: > >  >> As we move to GitHub, I would like to propose we strengthen our protections >> on `main` by making MergeQueue and CommitQueue mandatory. > > > What is the goal of this proposal? The goal is to increase the stability of the build,

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

2022-06-02 Thread Chris Dumez via webkit-dev
> On Jun 2, 2022, at 6:29 PM, Michael Catanzaro wrote: > > > > On Thu, Jun 2 2022 at 04:06:42 PM -0700, Chris Dumez via webkit-dev > wrote: >> I am concerned by this proposal given how slow EWS and the merge queue are >> these days. > > Hopefully Jonathan's three proposed blockers will ad

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

2022-06-02 Thread Michael Catanzaro via webkit-dev
On Thu, Jun 2 2022 at 04:06:42 PM -0700, Chris Dumez via webkit-dev wrote: I am concerned by this proposal given how slow EWS and the merge queue are these days. Hopefully Jonathan's three proposed blockers will address this: - run-webkit-tests consulting results.webkit.org to avoid ret

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

2022-06-02 Thread Chris Dumez via webkit-dev
I am concerned by this proposal given how slow EWS and the merge queue are these days. I think the issue is likely related to failures on the bots and the retries needed to determine if those failures are new. We’ve never had this restriction before. Seems we are becoming overly strict with t

Re: [webkit-dev] Proposal: Mandatory Commit and Merge Queue

2022-06-02 Thread Geoffrey Garen via webkit-dev
> As we move to GitHub, I would like to propose we strengthen our protections > on `main` by making MergeQueue and CommitQueue mandatory. What is the goal of this proposal? What problem are you trying to solve, and with what level of urgency? Thanks, Geoff > On Jun 2, 2022, at 2:35 PM, Jona

Re: [webkit-dev] Add CODEOWNERS to WebKit

2022-06-02 Thread Alexey Proskuryakov via webkit-dev
It seems like we still need to host watchlist CC service though, to support patch workflow - and we'll have separate lists in GitHub and in Bugzilla, unless watchlists are reimplemented. I believe that while there are stale watchlists entries, newer additions are valid. - Alexey 2 июня 2022 г

[webkit-dev] Proposal: Mandatory Commit and Merge Queue

2022-06-02 Thread Jonathan Bedard via webkit-dev
As we move to GitHub, I would like to propose we strengthen our protections on `main` by making MergeQueue and CommitQueue mandatory. This would mean that with a few exceptions, all changes would need to be built and run layout tests before they are landed. To spell out what the exceptions I had

Re: [webkit-dev] Add CODEOWNERS to WebKit

2022-06-02 Thread Jonathan Bedard via webkit-dev
Porting is possible, but that would be something that would happen, at the earliest, a few weeks from now. I does seem to me that the watchlist is out of date, so a forced-cleanup doesn’t seem like the worst thing. Jonathan > On Jun 2, 2022, at 2:21 PM, Chris Dumez wrote: > > I’m kind of ambi

Re: [webkit-dev] Add CODEOWNERS to WebKit

2022-06-02 Thread Chris Dumez via webkit-dev
I’m kind of ambivalent/neutral about this. One question though: When adopting CODEOWNERS, will our existing watchlists get ported, or will each contributor have to modify CODEOWNERS themselves to match whatever was in the watchlists for them? Thanks, Chris. > On Jun 2, 2022, at 1:12 PM, Jonath

Re: [webkit-dev] 안광림 is out of office.

2022-06-02 Thread Ling Ho via webkit-dev
I have set up a couple of rules to catch and hold based on "X-AutoResponse: AutoResponse" and "Auto-submitted: auto-generated". Not sure of the latter is needed. We'll have to see if they work tomorrow. ... ling On 6/2/22 11:00 AM, Klaus Weidner via webkit-dev wrote: Short version, you may want

[webkit-dev] Add CODEOWNERS to WebKit

2022-06-02 Thread Jonathan Bedard via webkit-dev
Hey folks, Yusuke is interested in adding the CODEOWNERS file to the WebKit project (see https://github.com/WebKit/WebKit/pull/1137 ). There have been some objections to this, the two ones I’m aware of: - WebKit doesn’t assign “ownership” to pieces of

Re: [webkit-dev] 안광림 is out of office.

2022-06-02 Thread Klaus Weidner via webkit-dev
Short version, you may want to set up a local mail filter to hide messages from this list with that subject. Unfortunately the interactions between mailing lists and autoresponders aren't very well standardized. The list messages have a List-Id: header which the user agent should use as an indicat

Re: [webkit-dev] 안광림 is out of office.

2022-06-02 Thread Alemar via webkit-dev
These out of office messages are getting out of hand. Is there anything we can do? El jue, 2 jun 2022 a las 10:43, 안광림 via webkit-dev (< webkit-dev@lists.webkit.org>) escribió: > > Period : 2022/05/23 00:00 ~ 2022/07/15 00:00 [Korea Standard Time] > > 부재중입니다. > ___

[webkit-dev] 안광림 is out of office.

2022-06-02 Thread 안광림 via webkit-dev
Period : 2022/05/23 00:00 ~ 2022/07/15 00:00 [Korea Standard Time] 부재중입니다. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-02 Thread Ryosuke Niwa via webkit-dev
On Thu, Jun 2, 2022 at 4:28 AM Claudio Saavedra via webkit-dev wrote: > > On Wed, 2022-06-01 at 16:39 -0700, Ryosuke Niwa via webkit-dev wrote: > > One day per month for one beginner sounds like a really low > > maintenance cost compared to having every WebKit developer fix non- > > unified builds

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-02 Thread Claudio Saavedra via webkit-dev
On Wed, 2022-06-01 at 16:39 -0700, Ryosuke Niwa via webkit-dev wrote: > One day per month for one beginner sounds like a really low > maintenance cost compared to having every WebKit developer fix non- > unified builds at all times. I'm sorry, but this is not about having "every WK developer fix