Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-12 Thread Ryosuke Niwa via webkit-dev
> On Jan 12, 2023, at 9:05 PM, Ryosuke Niwa via webkit-dev > wrote: > > >> On Jan 12, 2023, at 8:37 PM, Darin Adler wrote: >> >>> On Jan 12, 2023, at 9:35 PM, Ryosuke Niwa wrote: >>> >>> One alternative is to make bar() return RefPtr although that would be a bit >>> heavy handed in the c

Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-12 Thread Ryosuke Niwa via webkit-dev
> On Jan 12, 2023, at 8:37 PM, Darin Adler wrote: > >> On Jan 12, 2023, at 9:35 PM, Ryosuke Niwa wrote: >> >> One alternative is to make bar() return RefPtr although that would be a bit >> heavy handed in the case of trivial function calls like this: >> document().frame()->ownerElement() >

Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-12 Thread Darin Adler via webkit-dev
> On Jan 12, 2023, at 9:35 PM, Ryosuke Niwa wrote: > > One alternative is to make bar() return RefPtr although that would be a bit > heavy handed in the case of trivial function calls like this: > document().frame()->ownerElement() I don’t quite follow. You just said that all arguments includ

Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-12 Thread Ryosuke Niwa via webkit-dev
> On Jan 12, 2023, at 6:50 PM, Michael Catanzaro wrote: > > On Thu, Jan 12 2023 at 12:35:09 PM -0800, Ryosuke Niwa via webkit-dev > wrote: >> So… instead of: >> foo(bar()); >> do: >> foo(RefPtr { bar() }.get()); > > What's the value of creating a temporary RefPtr just to get at the underlying

Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-12 Thread Michael Catanzaro via webkit-dev
On Thu, Jan 12 2023 at 12:35:09 PM -0800, Ryosuke Niwa via webkit-dev wrote: So… instead of: foo(bar()); do: foo(RefPtr { bar() }.get()); What's the value of creating a temporary RefPtr just to get at the underlying raw pointer? Isn't this overkill? ___

Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-12 Thread Ryosuke Niwa via webkit-dev
> On Jan 12, 2023, at 1:27 PM, Darin Adler wrote: > >> On Jan 12, 2023, at 3:35 PM, Ryosuke Niwa via webkit-dev >> wrote: >> >>> On Jan 12, 2023, at 6:13 AM, Darin Adler wrote: >>> On Jan 12, 2023, at 12:21 AM, Ryosuke Niwa via webkit-dev wrote: assuming every local

Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-12 Thread Darin Adler via webkit-dev
> On Jan 12, 2023, at 3:35 PM, Ryosuke Niwa via webkit-dev > wrote: > >> On Jan 12, 2023, at 6:13 AM, Darin Adler wrote: >> >>> On Jan 12, 2023, at 12:21 AM, Ryosuke Niwa via webkit-dev >>> wrote: >>> >>> assuming every local variable / variable in stack is stored in a smart >>> pointer, f

Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-12 Thread Ryosuke Niwa via webkit-dev
> On Jan 12, 2023, at 6:13 AM, Darin Adler wrote: > >> On Jan 12, 2023, at 12:21 AM, Ryosuke Niwa via webkit-dev >> wrote: >> >> assuming every local variable / variable in stack is stored in a smart >> pointer, function arguments are safe to be raw pointers / references via >> transitive p

Re: [webkit-dev] Stop Using Raw Pointers & References in New Code

2023-01-12 Thread Darin Adler via webkit-dev
> On Jan 12, 2023, at 12:21 AM, Ryosuke Niwa via webkit-dev > wrote: > > assuming every local variable / variable in stack is stored in a smart > pointer, function arguments are safe to be raw pointers / references via > transitive property What about the case where the function argument is t