[webkit-dev] Removing the MUTATION_OBSERVERS feature define

2012-12-19 Thread Adam Klein
Hi webkit-dev, I intend to remove the #define for ENABLE_MUTATION_OBSERVERS in https://bugs.webkit.org/show_bug.cgi?id=105459. It's been enabled for quite awhile on all ports (see the ChangeLog on that bug for a bit more discussion). Unless I hear objections (e.g., from port maintainers that wish

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-11 Thread Adam Klein
On Wed, Jul 11, 2012 at 9:51 AM, Ryosuke Niwa wrote: > On Wed, Jul 11, 2012 at 9:30 AM, Yaar Schnitman wrote: > >> [(dev time of maintaining comments) + (risk of outdated comments causing >> bugs X dev time of fixing resulting bugs)] << (dev time gained by more >> contributors each being more kn

Re: [webkit-dev] Unprefixing DOM MutationObservers, and looking for help from port maintainers

2012-06-15 Thread Adam Klein
stharness.js and submit them to > W3C? That way, we can help other browser vendors implement it "correctly" > when they do. (of course, this shouldn't block unprefixing the API) It'd definitely be nice to push these upstream, I agree. And I also don't think this should

Re: [webkit-dev] Unprefixing DOM MutationObservers, and looking for help from port maintainers

2012-06-15 Thread Adam Klein
xing it, can we make sure we also pass Mozilla's tests and > vice versa? Mutation events was a huge mess partially because browsers > didn't interoperate. I'd like to make sure this API interoperates well from > day 1. > > - Ryosuke > > On Fri, Jun 15, 2012 at 1

Re: [webkit-dev] Unprefixing DOM MutationObservers, and looking for help from port maintainers

2012-06-15 Thread Adam Klein
and EFL, or only DRT? On Fri, Jun 8, 2012 at 2:16 PM, Adam Klein wrote: > Hi webkit-dev, > > DOM MutationObservers (see meta bug > https://bugs.webkit.org/show_bug.cgi?id=68729) have been shipping as > WebKitMutationObserver in Chromium since earlier this year. The > feature i

[webkit-dev] Unprefixing DOM MutationObservers, and looking for help from port maintainers

2012-06-08 Thread Adam Klein
to help other ports implement this appropriately, and provide the unprefixed version there too. Please let me know how I can be of assistance. Let me know if you have questions or concerns, Adam Klein ___ webkit-dev mailing list webkit-dev@lists.webk

Re: [webkit-dev] Moving code from Element to NamedNodeMap -- I think that is the wrong direction

2011-12-22 Thread Adam Klein
On Wed, Dec 21, 2011 at 11:32 PM, Darin Adler wrote: > On Dec 21, 2011, at 11:26 PM, Ryosuke Niwa wrote: > > > the immediate problem we have today is that code that updates and > notifies attributes are scattered all over the place, and making > refactoring harder > > Understood. I want to make s

Re: [webkit-dev] js-test-(pre|post).js in http tests

2011-12-19 Thread Adam Klein
Which tests are you referring to? I've certainly written HTTP tests that use the JS test harness, e.g., http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/filesystem/resolve-uri.html. Note the resources are in fact copied to a special '/js-test-resources/' directory to make them accessible

Re: [webkit-dev] Style guide should mention that we don't use anonymous namespace

2011-10-19 Thread Adam Klein
On Wed, Oct 19, 2011 at 4:29 PM, Ryosuke Niwa wrote: > On Wed, Oct 19, 2011 at 4:00 PM, Darin Adler wrote: >> >> On Oct 19, 2011, at 3:58 PM, Ryosuke Niwa wrote: >> > On Wed, Oct 19, 2011 at 3:51 PM, Darin Adler wrote: >> >>>  How about classes that are only used in one cpp file? Should we be >>

[webkit-dev] Style: Vector::iterator vs indexed iteration

2011-10-17 Thread Adam Klein
A small style question came up in a review today, and I was curious if there's any consensus on this: when iterating over a WTF::Vector, does WebKit style prefer using a size_t vs a Vector::iterator, or vice-versa? Both show up in WebCore, but the indexed style is more common (by maybe a 5-1 ratio

Re: [webkit-dev] Replacing DOM Mutation Events

2011-09-23 Thread Adam Klein
ERS", and then begin uploading implementation patches in small chunks. I've opened a meta-bug at https://bugs.webkit.org/show_bug.cgi?id=68729, and aim to coordinate the various pieces by making them block that bug. Cheers, - Adam On Thu, Aug 18, 2011 at 9:41 AM, Adam Klein wrote: &g

Re: [webkit-dev] Replacing DOM Mutation Events

2011-08-18 Thread Adam Klein
an open source test suite that is easily > accessible to UA implementors to ensure implementations are > consistent. Agreed, though we'll want to move a little closer together before we get there (discussion is still ongoing about details of the API). - Adam > Dominic > &g

[webkit-dev] Replacing DOM Mutation Events

2011-08-16 Thread Adam Klein
Greetings webkit-dev, It's generally agreed upon in the web community, and in WebKit specifically, that DOM Mutation Events are a bad thing. See, e.g., discussion on https://bugs.webkit.org/show_bug.cgi?id=8191 (relating to DOMAttrModified, and why WebKit does not wish to implement it) and https:/