Re: [webkit-dev] Adding LenientThis to WebKitIDL

2013-04-10 Thread Alec Flett
this is kind of what 'bind' is for, no? it's a little wordy, but you can just pass: console.log.bind(console) instead of the closure. its been around quite a while: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Function/bind personally as a web dev, it would frus

Re: [webkit-dev] SerializedScriptValue: signed vs unsigned char

2013-02-06 Thread Alec Flett
27;s particular libraries we want to use which have different > conventions, the adaptation should be done at the level of interfacing the > library. Changing WebKit's conventiones because of one optional dependency > does not make sense to me. > > Regards, > Maciej > >

Re: [webkit-dev] SerializedScriptValue: signed vs unsigned char

2013-02-06 Thread Alec Flett
end on SerializedScriptValue's current method signatures? Alec On Mon, Feb 4, 2013 at 5:14 PM, Benjamin Poulain wrote: > On Mon, Feb 4, 2013 at 4:54 PM, Alec Flett wrote: > >> Well, nobody is explicitly using LChar with SerializedScriptValue (maybe >> it should, maybe that

Re: [webkit-dev] SerializedScriptValue: signed vs unsigned char

2013-02-04 Thread Alec Flett
why LevelDB uses it as its lowest-common-denominator, but we don't have to have that debate here :)) Alec On Mon, Feb 4, 2013 at 4:43 PM, Benjamin Poulain wrote: > On Mon, Feb 4, 2013 at 3:51 PM, Alec Flett wrote: > >> At the moment, SerializedScriptValue uses Vector (aka >> Vec

[webkit-dev] SerializedScriptValue: signed vs unsigned char

2013-02-04 Thread Alec Flett
At the moment, SerializedScriptValue uses Vector (aka Vector) for both it's API (createFromWireBytes, toWireBytes) as well as its internal representation. (for both v8 and jsc implementations) The two largest consumers of this aspect of SerializedScriptValue seems to be IndexedDB and postMessage()

Re: [webkit-dev] platform-specific differences in test case inputs

2012-09-19 Thread Alec Flett
So this thread kinda died. Anyone have any suggestions? Where is JSC's SerializedScriptValue consistency tested? Alec On Tue, Sep 18, 2012 at 1:22 PM, Alec Flett wrote: > Sorry I totally left out the "I expose this through Internals" - and adam > has explained the rationa

Re: [webkit-dev] platform-specific differences in test case inputs

2012-09-18 Thread Alec Flett
Sorry I totally left out the "I expose this through Internals" - and adam has explained the rationale On Tue, Sep 18, 2012 at 12:46 PM, Oliver Hunt wrote: > What exactly are you trying to test here? The internal serialisation > format isn't exposed anywhere (nor should it be). > > By definition

[webkit-dev] platform-specific differences in test case inputs

2012-09-18 Thread Alec Flett
Background: some of the storage systems use SerializedScriptValue to persist structured-clonable objects ( http://www.w3.org/TR/html5/common-dom-interfaces.html#safe-passing-of-structured-data) - most of this is implemented in a V8 or JSC-specific implementation of SerializedScriptValue. I'm addin

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-13 Thread Alec Flett
On Fri, Jul 13, 2012 at 10:56 AM, Ryosuke Niwa wrote: > On Fri, Jul 13, 2012 at 5:57 AM, Stephen Chenney wrote: > >> I don't doubt there are poor comments, both outdated and useless. >> That's a reviewing failure. You have simply highlighted the fact that any >> standard for comments requires re

Re: [webkit-dev] Comments in the code (Was Please include function-level comments in change log entries)

2012-07-11 Thread Alec Flett
I'm gonna chime in here, as I am 3 months into working on WebKit and the lack of comments has driven me absolutely crazy. This is a bit of a rant from a self-declared newbie, but I'm trying to be constructive. I've contributed to a handful of open and closed source projects. I am trying to help,

Re: [webkit-dev] Queries regarding indexed db implementation

2012-05-02 Thread Alec Flett
On Wed, May 2, 2012 at 4:42 AM, 김지연 wrote: > Hi all. > > ** ** > > This is Jiyeon Kim recently joined webkit-dev mailing list. > > ** > Welcome - I'm somewhat new here myself, but I am working on IndexedDB support in WebKit.. ** > > I’ve got two questions on IndexedDB. > > First, I