Re: [webkit-dev] Announcing WebKit2

2010-04-09 Thread Cameron Zwarich
On Apr 9, 2010, at 2:34 AM, Jeremy Orlow wrote: > On Fri, Apr 9, 2010 at 2:33 AM, Adam Treat wrote: > On Thursday 08 April 2010 09:24:32 pm Darin Adler wrote: > > On Apr 8, 2010, at 6:23 PM, Adam Treat wrote: > > > Can someone please point to the bug report and the forum where this > > > developm

Re: [webkit-dev] Squirrelfish

2009-04-14 Thread Cameron Zwarich
On 14-Apr-09, at 10:15 AM, thouraya andolsi wrote: Hi, I had a look on the squirrelfish source code and I saw that there is no mixed mode. It means we use JIT or interpreter but we can't switch to interpreter if the JIT fails. Is it OK ? or I'm wrong ? In theory, it should be possible f

[webkit-dev] Support for ESMP and other mobile web standards

2009-03-30 Thread Cameron Zwarich
For some time now there has been a bug in Bugzilla about adding conditional support for ECMA Script Mobile Profile: https://bugs.webkit.org/show_bug.cgi?id=24114 I am capable of reviewing the technical content of the patch, but I don't know how the greater WebKit community feels about adding

Re: [webkit-dev] JavaScriptCore or WebCore

2009-03-11 Thread Cameron Zwarich
On 11-Mar-09, at 3:31 PM, Husam Senussi wrote: Hi, I'm trying to see where should go, I'm writing the code for JSON object and I'm not sure where should go. In the patch attached to the bug the code for JSON object exist in JavaScriptCore/kjs which doesn't exist in source tree I checke

Re: [webkit-dev] A question about SubresourceLoader

2008-12-19 Thread Cameron Zwarich
On 19-Dec-08, at 1:01 AM, Cameron Zwarich wrote: Why is SubresourceLoader::m_client a pointer, and why is it also null-checked? It is only set by its private constructor that is called from ::create(), which is always called from a SubresourceLoaderClient with 'this' as

[webkit-dev] A question about SubresourceLoader

2008-12-19 Thread Cameron Zwarich
Why is SubresourceLoader::m_client a pointer, and why is it also null- checked? It is only set by its private constructor that is called from ::create(), which is always called from a SubresourceLoaderClient with 'this' as the client parameter. Shouldn't it just be a reference? Maybe I am mi

Re: [webkit-dev] [webkit-changes] [38187] trunk/JavaScriptCore

2008-11-10 Thread Cameron Zwarich
On 10-Nov-08, at 7:59 AM, George Staikos wrote: Shouldn't that be PLATFORM(LINUX) instead of PLATFORM(GTK)? Seems that PLATFORM(GTK) could be wrong in some cases, and not having, for example PLATFORM(QT), could be also wrong. I reviewed Alp's patch. The patch makes all memory allocate as

[webkit-dev] JavaScriptCore cleanup

2008-09-07 Thread Cameron Zwarich
Now that SquirrelFish Extreme has landed, we should perform some of the cleanup that we've been itching to do for a while now. A few items immediately come to mind, but I am sure there are others: 1) Directory reorganization. We should split the code into more logical units than kjs, pcre, w

Re: [webkit-dev] CodeGenerator::newTemporary

2008-08-10 Thread Cameron Zwarich
Indeed, this seems to be a problem. I have made a Bugzilla entry for it: https://bugs.webkit.org/show_bug.cgi?id=20340 We should continue discussion of the bug there. Thanks for pointing it out. We should have noticed this subtlety when we added SegmentedVector. Cameron ___

Re: [webkit-dev] WindScorpion

2008-08-10 Thread Cameron Zwarich
Do you have more details on your code coverage tests? You should also try running them with the tests in LayoutTests/fast/js, because typically all new tests are found there. I would be interesting in seeing what is missing so we can improve test coverage. I haven't had time to look at the t