[webkit-dev] vertical text

2011-11-10 Thread Cary Clark
TL;DR: Why is the graphics context rotated when drawing vertical text? Skia ports use text-on-path to draw vertical text. This is slow, and sometimes doesn't look very good, for instance when rendering fast/writing-mode/text-orientation-basic.html . To fix this, I added vertical text support on S

Re: [webkit-dev] vertical text

2011-11-11 Thread Cary Clark
Thanks for the answer, Dave. That makes perfect sense. Why is it that the graphics context is rotated but the advances supplied to Font::DrawGlyphs in the GlyphBuffer aren't? Cary On Thu, Nov 10, 2011 at 5:22 PM, David Hyatt wrote: > On Nov 10, 2011, at 4:07 PM, Cary Clark wrote: >

[webkit-dev] Android and WebKit

2009-01-09 Thread Cary Clark
The Android browser team is actively submitting changes to webkit. This change adds the bulk of the Android port to WebKit/android: https://bugs.webkit.org/show_bug.cgi?id=23118 It has raised some eyebrows, in part because it does not follow the webkit coding conventions or use an accepted copy

[webkit-dev] how to remove an event listener when the element attribute is removed

2009-01-14 Thread Cary Clark
When a web page removes the click handler from an element, webkit leaves the event listener on the event target node. In practice, this works fine, because the click can't dispatched -- there's no click handler anymore. On Android's browser, we draw a focus ring (like the ring Safari draws when ta

Re: [webkit-dev] How did Android developer develop WebKit for android

2009-03-12 Thread Cary Clark
Android engineers sometimes use XCode to run webkit, but mainly debug on the Android emulator and Android devices using gdb, Eclipse, and logs. When we use XCode, we're either running a tiny fraction of webkit, or building webkit without our changes for use with Safari as a reference as described o

[webkit-dev] globals and guidelines

2008-12-09 Thread Cary Clark
Global variables aren't discussed here: http://webkit.org/coding/coding-style.html In sources, I see: gX.. WebCore/rendering/RenderLayer.h:138:static const ScrollAlignment gAlignCenterIfNeeded; s_x.. WebCore/rendering/RenderObject.h:964:static bool s_affectsParentBlock; AxBx.. WebCore/d

Re: [webkit-dev] How webkit on android implements magnifying glass?

2008-12-19 Thread Cary Clark
On Thursday 18 December 2008 07:50:00 ying lcs wrote: > In webkit on android, it has a 'magnifying glass' feature: in the zoom > out view, it has a viewing rectangle which shows the content in 100%. > > Can you please point to me where is the code how webkit on android > implements magnifying glass