Re: [webkit-dev] Vertical Selections in Textareas

I think it’s a neat idea. It’s a big, challenging project. The first step is probably to add the notion of a selection that is not a single DOM range. There are many, many functions that currently have that assumption. I don’t have a lot more specific feedback to add. — Darin __

Re: [webkit-dev] Clipboard class plans

On May 16, 2013, at 5:47 AM, Carlos Garcia Campos wrote: > I can help with he GTK port, I've already opened a new bug : > > https://bugs.webkit.org/show_bug.cgi?id=116221 > > Do you also plan to fix the layering violations in Pasteboard? Absolutely. If you look at my original mail in this thre

Re: [webkit-dev] Clipboard class plans

On Feb 6, 2013, at 9:13 AM, Darin Adler wrote: > The major step is to refactor so that Pasteboard is the platform abstraction > and Clipboard is a pure DOM class built on top of Pasteboard. To do a good > job on that I will probably need help from people willing to tackle platforms

Re: [webkit-dev] Test frame size for reftests

On Apr 24, 2013, at 3:52 PM, Dirk Pranke wrote: > You mean it's easy to write a test that is bigger than 800x600, and perhaps > we should generate some sort of warning for this? It’s easy to write a test where part of what we’re trying to test is outside 800x600, right. And it would be good if

Re: [webkit-dev] Test frame size for reftests

On Apr 24, 2013, at 3:45 PM, Dirk Pranke wrote: > in the absence of tests that *need* bigger viewports, I'd side w/ David and > say that we should fix tests to fit within 800x600 so that they are portable > to other browsers and meet the W3C's criteria. Makes sense. I believe the 800x600 view

Re: [webkit-dev] Test frame size for reftests

On Apr 23, 2013, at 11:36 AM, Benjamin Poulain wrote: > The current mode works fine for some ref-tests but is really annoying for > others. I would love to have a way to compare the entire page instead of the > viewport. > > Maybe it could just be an API on testrunner? Like: > testRunner.d

Re: [webkit-dev] on coding-style

On Apr 12, 2013, at 3:33 PM, Karen Shaeffer wrote: > Shouldn't the coding-style documentation be updated to use nullptr? We may want to update the guidelines to tell people to use nullptr where it works. We definitely put some effort into making it usable in certain contexts; we originally add

Re: [webkit-dev] Adding "__FILE__" and "__LINE__" to CRASH() macro

Is this for debug builds or for production builds? If it is for debug builds, then adding file and line seems fine; we should do it in a way that shares code with assertion macros. If it is for production builds, then how do you debug other crashes? -- Darin

Re: [webkit-dev] Rewriting binding code generator, maybe?

On Apr 11, 2013, at 9:51 AM, Darin Adler wrote: > The actual code generation needs to change all the time as the internal > architecture of WebKit and of the JavaScript engine and other things we’re > binding change, so we should not try to change that. I meant “we should not try

Re: [webkit-dev] Rewriting binding code generator, maybe?

On Apr 11, 2013, at 5:02 AM, Thiago Marcos P. Santos wrote: > Would be great if both projects could share the same generators. The part that would be OK to share would be the parsing. The actual code generation needs to change all the time as the internal architecture of WebKit and of the Jav

Re: [webkit-dev] Sunsetting committership and reviewership

On Apr 7, 2013, at 7:07 PM, Glenn Adams wrote: > This seems rather subjective criteria. Yes, that’s right, the criteria for becoming a reviewer is subjective, and should remain so. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org htt

Re: [webkit-dev] Feature announcement: Web VHS API

Finally. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Should we create an 8-bit path from the network stack to the parser?

On Mar 11, 2013, at 9:54 AM, Adam Barth wrote: > As for the long-term direction of the HTML parser, my guess is that the > optimum design will be to deliver the network bytes to the parser directly on > the parser thread. Sounds right to me. > If you're about to reply complaining about the ab

Re: [webkit-dev] SVGStopElement.idl recompiling every time if you build twice in a row?

Thanks for the information, both of you. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] SVGStopElement.idl recompiling every time if you build twice in a row?

On Mac, SVGStopElement.idl keeps getting recompiled every time I build WebCore, and then in turn everything that uses the headers generated. Anyone know why this happens? Is this specific to Mac, or happening with other build systems too? -- Darin ___

Re: [webkit-dev] Should we create an 8-bit path from the network stack to the parser?

there some other case you don't think we are handling? > > - Michael > > On Mar 7, 2013, at 9:29 AM, Darin Adler wrote: > >> Hi folks. >> >> Today, bytes that come in from the network get turned into UTF-16 by the >> decoding process. We then turn

Re: [webkit-dev] Garbage Collection doesn't fire in time for Video/Audio element removing

On Mar 7, 2013, at 3:07 AM, Horky wrote: > When creating the new video element or audio element and remove it by > clearing the innerHTML of parent div node, the used memory will be growing > for each time. I doubt if there is no specified garbage collection mechanism > for this situation. >

[webkit-dev] Should we create an 8-bit path from the network stack to the parser?

Hi folks. Today, bytes that come in from the network get turned into UTF-16 by the decoding process. We then turn some of them back into Latin-1 during the parsing process. Should we make changes so there’s an 8-bit path? It might be as simple as writing code that has more of an all-ASCII speci

Re: [webkit-dev] [webkit-help] [squirrelfish-dev] How to debug the JIT when it crash

On Mar 4, 2013, at 2:41 AM, talking1...@gmail.com wrote: > Hi All, apologies for the spam. Please, it’s not acceptable to cross-post to all three of lists to ask for help debugging a problem. If we all did that we’d have tons of traffic on these mailing lists. Stop! Please at least narrow thi

Re: [webkit-dev] Kickstarting the migration of platform-specific WebCore source code to Source/Platform

On Feb 28, 2013, at 1:02 PM, Maciej Stachowiak wrote: > I think Adam's old plan for the Platform directory was to migrate from > WebCore/platform piece-by-piece, starting with related groups of classes that > are already free of layering violations. That seems like a sensible approach > to me

Re: [webkit-dev] Kickstarting the migration of platform-specific WebCore source code to Source/Platform

On Feb 28, 2013, at 10:23 AM, John Yani wrote: > If I understood correctly, the idea is that WebCore should depend on > "platform", not vice versa. > > Still, while "platform" provides platform independent API to WebCore, it has > platform-specific bits. > > Did I get the idea correctly? Tha

Re: [webkit-dev] Kickstarting the migration of platform-specific WebCore source code to Source/Platform

On Feb 28, 2013, at 9:31 AM, Darin Adler wrote: > minimize the need for platform-independent code minimize the need for platform-specific code Moving all the platform-specific bits of various parts of WebCore away from the code they are tightly integrated with and into a “all platf

Re: [webkit-dev] Kickstarting the migration of platform-specific WebCore source code to Source/Platform

There may be a misunderstand of what the “platform layer” is. We should not move all platform-specific files into the platform directory! Please do not make the changes in bug 110330 until we have discussed this. The idea is not that all platform-specific code is in the WebCore/platform directo

Re: [webkit-dev] Possibilities to use border css property on image map...

On Feb 26, 2013, at 8:49 PM, Arunprasad Rajkumar wrote: > From next time can I post it to webkit-help to ensure the bug? No, you shouldn’t. It’s normally considered bad manners to send mail to the mailing list to ask “Is this a bug?” without first filing a bug report. If it’s not a bug we can

Re: [webkit-dev] Possibilities to use border css property on image map...

On Feb 25, 2013, at 11:26 PM, Arunprasad Rajkumar wrote: > So I tried using :focus { border:5px solid red; }. But it is not working in > WebKit based browsers. But border property works well for all other > elements(a,div,span,p,..) but not with area. Thanks fore the bug report. However, mail

Re: [webkit-dev] AncestorChainWalker substance and style thoughts

On Feb 18, 2013, at 6:40 PM, Ryosuke Niwa wrote: > But you're right in that the case of one off call to parent(), there isn't > much point in creating an object. We can probably get away with a single > function call. We can always add a convenience function for going a single level even if th

Re: [webkit-dev] AncestorChainWalker substance and style thoughts

On Feb 18, 2013, at 6:28 PM, Ryosuke Niwa wrote: > I had the same question when I found this class today but when I tried to > turn it into a function, I realized that each caller of this function now > needs to maintain two variables instead of one. Since those two variables > (node and distr

Re: [webkit-dev] AncestorChainWalker substance and style thoughts

On Feb 18, 2013, at 6:18 PM, Hajime Morrita wrote: > Non-trivial tree traversal API in general should, IMO, be modeled after > recently introduced NodeTraversal. Having separate namespaces allows us to > keep Node API minimal. Also it is stateless and simple. I made > NodeRenderingTraversal in

Re: [webkit-dev] AncestorChainWalker substance and style thoughts

On Feb 18, 2013, at 6:17 PM, Ryosuke Niwa wrote: > See https://bugs.webkit.org/show_bug.cgi?id=110146 where we're going to > rename the class, member functions and variables. Thanks. Good discussion there. What about my other question? Why is this a class instead of a function? -- Darin _

[webkit-dev] AncestorChainWalker substance and style thoughts

I am trying to learn about code related to shadow DOM that needs to be understood by anyone working on an part of the DOM. I have some questions and concerns about AncestorChainWalker. If there is a document I should be reading that covers these, please point me to it. The parentNode and parent

Re: [webkit-dev] sln files with wrong line endings

Typically in Subversion the fix for a problem like this is to set the eol-style explicitly; presumably to CRLF for Windows project and solution files and to LF or native for plain old source files. Once that property is set, people changing file later on can’t cause problems with inconsistent li

Re: [webkit-dev] Should LChar really being unsigned char? (was Re: SerializedScriptValue: signed vs unsigned char)

Short answer, yes. On Feb 10, 2013, at 9:14 AM, Glenn Adams wrote: > Because LChar is often (always?) UTF-8 encoded, the individual encoding units > of which are 0x00 through 0xFF. Close. LChar is always Latin-1 encoded. That’s what the "L" is for. That’s the same thing as the first 256 code

Re: [webkit-dev] SerializedScriptValue: signed vs unsigned char

On Feb 7, 2013, at 8:31 AM, Glenn Adams wrote: > Given Maciej and Adam's comments, you had best stay with unsigned char/uint_8 > and convert any non-conforming usage to this pattern when needed. Yes, I think that’s the right direction for WebKit. -- Darin __

Re: [webkit-dev] Clipboard class plans

On Feb 6, 2013, at 12:06 PM, Daniel Cheng wrote: > ​I think ​Clipboard.types currently returns an Array. Clipboard::types currently returns ListHashSet, and custom bindings translate that into a JavaScript array. > There's a patch in progress to change this to Vector to remove the > need for

[webkit-dev] Clipboard class plans

Hi folks. I have some work planned on the DOM clipboard classes. I’m not in a big hurry to get this done fast. It’s my side project. But I thought some people might be interested in what I am thinking about doing. I have a good 20% of the project already sitting in my local git repository and I

Re: [webkit-dev] request of "canconfirm-bit"

On Jan 16, 2013, at 2:54 PM, 徐征 wrote: > So, how can I get assign for this issue(and make the status to ASSIGNED)? You don’t need to. You can add comments and post a patch without having the bug formally assigned to you. In fact, we don’t normally pay all that much attention to the Assigned To

Re: [webkit-dev] Proposal to remove list-item special counter

On Jan 16, 2013, at 5:46 PM, Elliott Sprehn wrote: > I've scoured the web and can't find any reference to anyone using it, mention > of it's usage on any pages and no other browser supports it. How much more common is use of the rest of the counters specification? I understand that counters is

Re: [webkit-dev] request of "canconfirm-bit"

On Jan 16, 2013, at 9:19 AM, Adam Barth wrote: > We more or less ignore the "is confirmed" bit in bugs.webkit.org. I believe it’s possible to rename UNCONFIRMED to NEW and delete NEW so we can get rid of this distinction that we don’t make use of. Might be worth doing at some point to reduce c

Re: [webkit-dev] Prefix naming scheme for DOM-exposed functions

On Dec 7, 2012, at 12:28 PM, Elliott Sprehn wrote: > This seems like it would introduce bugs and make maintaining the DOM harder > since we'd need to duplicate logic. We should not needlessly duplicate logic. If the change causes us to copy and paste code, we’re doing it wrong. > Right now we

[webkit-dev] Prefix naming scheme for DOM-exposed functions

Hi folks. Many of the APIs designed for use in the DOM are not efficient for use inside WebKit, or have designs that are better for JavaScript than for C++. Antti Koivisto and I have been discussing how to best communicate this to WebKit contributors so they don’t end up using inefficient idiom

Re: [webkit-dev] sharing more test references

On Nov 13, 2012, at 4:56 PM, Dirk Pranke wrote: > Wouldn't the fact that there are a large set of tests with the same result be > an argument *for* doing the iframe thing? The simple hand-coded green square in upper left corner should be simple, perhaps even simpler than the iframe thing. > W

Re: [webkit-dev] sharing more test references

On Nov 13, 2012, at 4:01 PM, Dirk Pranke wrote: > It turns out that we have a reasonably large number of tests that produce the > exact same pixel results. On chromium-mac on 10.8, for example, there are > 2048 tests that share a result with some other test. 50 of them, for example, > draw a g

Re: [webkit-dev] do you want "WK1" and "WK2" keywords in the TestExpectations files?

On Nov 13, 2012, at 12:29 PM, Dirk Pranke wrote: > We pretty much have this today (with platform/wk2 and platform/mac-wk2). > You're saying you'd prefer to add platform/wk1, platform/mac-wk1, > platform/mac-lion-wk1, and platform/mac-lion-wk2 if/where necessary (and no > keywords), right? I w

Re: [webkit-dev] generic test expectations?

On Nov 13, 2012, at 12:16 PM, Tony Chang wrote: > Here is a ref test result from ietestcenter: > http://trac.webkit.org/browser/trunk/LayoutTests/ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm > > Looking at that HTML file, it's not immediately obvious that the result is > correct. If

Re: [webkit-dev] do you want "WK1" and "WK2" keywords in the TestExpectations files?

I’d prefer an directory-based overlay/inheritance approach to sharing WebKit1- vs. WebKit2-specific expectations over in-file keywords. I’d like to share more than just a central expectations file, so we could share expected results or even WebKit1 or WebKit2-specific tests. -- Darin __

Re: [webkit-dev] generic test expectations?

On Nov 13, 2012, at 12:02 PM, Tony Chang wrote: > I don't think we should support port specific ref test results. That kind of > misses the point of using a ref test in the first place. I mean, you may as > well check in port specific pixel results which are easier to review for > correctness.

Re: [webkit-dev] generic test expectations?

If we do add base test expectations shared by all platforms, please don’t put the file into LayoutTests/platform/generic; just put it at the top level of LayoutTests. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.

Re: [webkit-dev] Problems with the new NATIVE_TYPE_ERR

On Nov 13, 2012, at 10:44 AM, Joshua Bell wrote: > The switch from DOMException of type TYPE_MISMATCH_ERR to TypeError does not > appear to be controversial, but as arv@ mentioned in one of the bugs: > > "WebIDL only defines bindings for ECMAScript. We really need someone from > Apple to take

[webkit-dev] Problems with the new NATIVE_TYPE_ERR

Four months back we added NATIVE_TYPE_ERR for IndexedDB, as a way for the DOM code to raise JavaScript type error exceptions rather than DOM exceptions . Yesterday we started using NATIVE_TYPE_ERR elsewhere in the DOM

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

On Nov 9, 2012, at 9:59 AM, Rafael Brandao wrote: > I'd go with the overloads in a single file Why? Seems the overloads should be in the files of the classes they are for. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.w

Re: [webkit-dev] compile failure when I try to introduce GLContextEGL to MediaPlayerPrivateGStreamer

On Nov 9, 2012, at 12:27 AM, Simon Hausmann wrote: > It's the X11 headers that are broken and the usual workaround is to do things > like > >#undef None > > after including them. That should probably happen in GLContextEGL.h or even > nearer to the inclusion. I agree. You can see one ex

Re: [webkit-dev] …Inlines.h vs …InlineMethods.h

On Nov 5, 2012, at 8:47 AM, Geoffrey Garen wrote: > (2) Adopt the convention that any class using "*Inlines.h" defines all inline > functions defined out-of-line in "*Inlines.h" This is a proposal I don’t agree with. Making a firm rule here here means that every larger inline function in one o

Re: [webkit-dev] …Inlines.h vs …InlineMethods.h

On Nov 3, 2012, at 10:09 AM, Mark Lam wrote: > 1. to keep class definitions more compact >- so you can see more of the entire class (not that this is always > possible anyway). >- being able to see the entire class (when possible) can yield useful > information about the shape of the cl

Re: [webkit-dev] Slide deck: How WebKit Works

I like those slides. Thanks for putting them where we can all see and use them. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Mac build issue (appearing only locally)

Seems like this must be a difference between clang versions; I suggest updating to a newer version of Xcode. If we need to support the older clang, then the fix of reordering the methods seems OK. There are other fixes we could consider too. -- Darin

Re: [webkit-dev] Transformations precision: double -> float

On Oct 10, 2012, at 9:00 AM, Gabor Rapcsanyi wrote: > That was a long time ago and there were no objections >> Unless there's something in the spec requiring double precision it makes >> sense to move away from double precision throughout WebKit. I’m a little concerned about this. The program

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

On Oct 3, 2012, at 4:18 PM, Dirk Pranke wrote: > it's trying to run "/usr/bin/make", "-C" > "/Users/darin/Safari/Internal/Tools/Scripts/../../../OpenSource/LayoutTests/java"] > (approximately). > > It's probably bad that it's hardcoded to look in /usr/bin; is that your > problem? I’ll check.

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

On Oct 3, 2012, at 9:10 AM, Ryosuke Niwa wrote: > Could you tell us what your directory structure look like and where you're > executing that command? Looks like a path confusion. My WebKit source tree is in ~/Safari/OpenSource and my build products are in ~/Builds. I am running the script ins

[webkit-dev] Tips on why run-webkit-tests is not working for me?

I’m trying to test some changes on my Mountain Lion Mac, using the Mac port. When I call run-webkit-tests it fails with file not found. Using port 'mac-mountainlion' Test configuration: Placing test results in /Users/darin/Build/Debug/layout-test-results Baseline search path: mac -> generic Usin

Re: [webkit-dev] Is there a rule to use UNUSED_PARAM ?

On Oct 1, 2012, at 5:23 PM, Darin Adler wrote: > Yes, even though I named the macro Hmm, not sure I did. Maybe someone else did. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Is there a rule to use UNUSED_PARAM ?

On Oct 1, 2012, at 5:21 PM, Mike Lawther wrote: > my first reading of that name had me thinking it meant 'ASSERT that this > variable is unused' in the vein of macros I've seen in other places like > ASSERT_TRUE, ASSERT_NOT_NULL etc. Yes, even though I named the macro I have had the same thou

Re: [webkit-dev] Improving DOM Exception console messages.

On Oct 1, 2012, at 2:57 AM, Mike West wrote: > Concretely, this might involve adding two properties to ExceptionBase: > 'context' and 'totallySektitContext' I think the naming here is critical. The word “context” is an extremely bland and vague one that does not make it clear what this inform

Re: [webkit-dev] Is there a rule to use UNUSED_PARAM ?

I prefer we use UNUSED_PARAM as little as possible. The main reason is that we can utter UNUSED_PARAM and then use the parameter without getting a compiler error. This makes it easy to use the macro in a way that is misleading. It doesn’t actually enforce that a parameter is unused, and is more

Re: [webkit-dev] New Feature: Canvas Path object

On Sep 22, 2012, at 9:21 PM, Elliott Sprehn wrote: > On Fri, Sep 21, 2012 at 6:34 AM, Dirk Schulze wrote: > >> I would like to ask if there are objections to implement the canvas Path >> object. > > Do we have metrics on how often people already have things named Path? All > other canvas obj

Re: [webkit-dev] Enable encoding detector on layout(regression) test

On Sep 19, 2012, at 9:22 AM, Darin Adler wrote: > On Sep 18, 2012, at 6:25 PM, Kangil Han wrote: > >> However, enabling encoding detector by javaScript manipulation seems not >> feasible since encoding detector works on reading input stream level. > > You could p

Re: [webkit-dev] Enable encoding detector on layout(regression) test

On Sep 18, 2012, at 6:25 PM, Kangil Han wrote: > However, enabling encoding detector by javaScript manipulation seems not > feasible since encoding detector works on reading input stream level. You could probably make an encoding detection test using an iframe with a data URL in it. Have you t

Re: [webkit-dev] unsigned vs unsigned int

On Sep 17, 2012, at 1:22 AM, Allan Sandfeld Jensen wrote: > On Sunday 16 September 2012, Darin Adler wrote: >> I think we should use the shortest name for each type. >> >> That is why I like “unsigned” better than “unsigned int”. > > Does this mean you also prefer &#

Re: [webkit-dev] unsigned vs unsigned int

On Sep 16, 2012, at 2:30 AM, Allan Sandfeld Jensen wrote: > On Thursday 13 September 2012, Dan Bernstein wrote: >> On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen >> wrote: >> >>> I was telling people to use "unsigned" instead of "unsigned int", as I >>> have been told that was the pre

Re: [webkit-dev] Proposal for coding guidelines: Do not use fall-through switch cases inside #ifdef's

On Aug 21, 2012, at 1:22 PM, Mark Rowe wrote: > It'd be preferable to fix whatever problem exists with the dependencies so > that these files are automatically regenerated when needed. Otherwise anyone > building on these platforms, including buildbots, will just run in to the > issue after yo

Re: [webkit-dev] Proposal to remove list-item special counter

On Aug 15, 2012, at 2:29 PM, Elliott Sprehn wrote: > WebKit is the only browser that implements the magic counter named > "list-item" and we have no tests for it. Seems like we really ought to add some tests for it. > It's not useful since we don't support the ::marker pseudo element Maybe it

Re: [webkit-dev] New runtime setting: css3TextDecoration

On Aug 14, 2012, at 5:41 PM, Elliott Sprehn wrote: > The point of the vendor prefix is to assert the instability of the feature. The WebKit project uses vendor prefixes to avoid compatibility conflict between a feature and a later incompatible standardized feature that would use the same name.

Re: [webkit-dev] Question related to license in WK2 EFL port

There’s some specific policy about this that’s displayed in bugs.webkit.org when you attach a patch for review: > Hello and thank you for contributing a patch. Here is our licensing policy > and terms for contributing code to the WebKit project. > > • If you are sending in a patch to exis

Re: [webkit-dev] Lots of email to this list is showing up too small for me to read

On Jun 26, 2012, at 10:12 PM, Ryosuke Niwa wrote: > Could you send me a copy (markup and possibly a screenshot) of emails you see > this problem and ones you don't see this problem? Yes. I did that. -- Darin ___ webkit-dev mailing list webkit-dev@list

[webkit-dev] Lots of email to this list is showing up too small for me to read

Some of the email to the WebKit lists is now showing up in 10 point size rather than the default size for my mail reader. I’m having a hard time reading the small text and I have to do various tricks to make these mails readable. It seems to mostly be from people at Google. Did you guys change s

Re: [webkit-dev] [PATCH] Errors from "build-webkit --debug --minimal"

This is the wrong mailing list to discuss this kind of issue. On this list we discuss contributions to the WebKit project and collaborate on WebKit development. If you want to build WebKit and do not intend to contribute patches, you can ask questions on the webkit-help mailing list as described

Re: [webkit-dev] Hardware Acceleration

On Jun 21, 2012, at 2:49 AM, ketan goyal wrote: > I am working on some 3D stuff and need hardware acceleration for performance. > > So, I am wondering if Hardware Acceleration is supported for GTK port in > webkit ? I think you may misunderstand the purpose of this mailing list. This is the ma

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

On Jun 15, 2012, at 10:15 AM, Maciej Stachowiak wrote: > But it's hard to explain fully in a function name w/o excess verbosity. I think my favorite excess verbosity version is refDocumentButNotOtherNodes. -- Darin ___ webkit-dev mailing list webkit-d

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

On Jun 15, 2012, at 9:47 AM, Ryosuke Niwa wrote: > // Nodes belonging to this document hold guard references - > // these are enough to keep the document from being destroyed, but > // not enough to keep it from removing its children. This allows a > // node that outlives its document to still hav

Re: [webkit-dev] Making Webkit compliant with HTML5 new features

On Jun 15, 2012, at 7:23 AM, Ryosuke Niwa wrote: > Filing bugs on bugs.webkit.org for things that make WebKit not compliant with > the HTML5 specifications is a good starting point. Another useful task is to learn to write good regression tests, and write tests that demonstrate the problems you

Re: [webkit-dev] Rename of selfOnlyRef to guardRef - ok if I change it back? (was Re: DOM tree traversal on detached nodes)

On Jun 15, 2012, at 12:12 AM, Roland Steiner wrote: > I made the original name change, because I honestly was entirely confused > about the meaning of "selfOnlyRef" (it's done by Node on Document, so what is > "self"? Why is it needed?) A good rule of thumb, the one that I use, is that a name l

Re: [webkit-dev] editbugs permission

On Jun 13, 2012, at 9:25 PM, Mike Lawther wrote: > I'd like to ask for EditBugs permission for dstockw...@chromium.org, who has > already landed a couple of patches and is helping us triage bugs. Someone must have seen this and granted permission, because I went to do so and he already had it.

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

On Jun 13, 2012, at 4:26 PM, Ryosuke Niwa wrote: > So something like > > webkit.org/12345 [Win Mac Debug] animations/stop-animation-on-suspend.html > [Crash Text Pass] > > ? I like that! Yes, looks good to me too. -- Darin ___ webkit-dev mailing li

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

On Jun 13, 2012, at 3:53 PM, Dirk Pranke wrote: > * we use "\" (backslash) as a delimiter instead of ":" and "=" Seems worse to me. When I see a backslash I assume it’s a line continuation character or a C escape sequence. On the other hand, neither the ":" nor the "=" meant anything to me eit

Re: [webkit-dev] malloc(0)

On Jun 13, 2012, at 2:24 PM, Myles C. Maxfield wrote: > There is still the question of if I can upstream this to ICU, which I'm > checking on. I was not proposing changing ICU. > In the meantime, Ryosuke Niwa has a good argument for option 3) above. Yes, that’s what I was suggesting; I am gla

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

On Jun 13, 2012, at 12:12 PM, Dirk Pranke wrote: > On Wed, Jun 13, 2012 at 12:05 PM, Darin Adler wrote: >> On Jun 12, 2012, at 5:17 PM, Ojan Vafai wrote: >> >>> It's great to use a fuzzer in order to find cases where we're broken and >>>

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

On Jun 12, 2012, at 5:17 PM, Ojan Vafai wrote: > It's great to use a fuzzer in order to find cases where we're broken and then > make reduced layout tests from those. Generally we do require a test each time we fix a bug. So it’s a strategy for the project to always make reduced tests when we

Re: [webkit-dev] malloc(0)

On Jun 12, 2012, at 3:03 PM, Myles C. Maxfield wrote: > I noticed that this caused a problem in one particular place > (WTF::StringImpl::getData16SlowCase()) where the code allocates (constant * > length) bytes for an (empty) string, and provides an accessor that exposes > this pointer. This p

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

On Jun 12, 2012, at 1:02 PM, Ryosuke Niwa wrote: > Because then we'll be placing tests for one component in multiple directories. Makes sense, but fleshing this out for all the tests could be tricky. Only a certain percentage of our tests will fall cleanly into a component such as CSS or DOM.

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

On Jun 12, 2012, at 10:17 AM, Ryosuke Niwa wrote: > The last time we had this discussion, the consensus appeared to be renaming > it to RegressionTests. I still like that name. > Are you suggesting that we have LayoutTests/W3C? Yes. Something like RegressionTests/ImportedTests/W3C. > we have

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

On Jun 11, 2012, at 7:33 PM, Mike Lawther wrote: > Does having the 'fast' directory still serve a useful purpose? Not sure it does. The original intent was to put more extensive complete tests that were slow but had greater coverage outside the “fast” directory, so that you could run the major

Re: [webkit-dev] DOM tree traversal on detached nodes

On Jun 6, 2012, at 6:14 PM, Kentaro Hara wrote: > IMHO, (a) would be the best semantics. I agree, and I think that the specification actually does require this. The real issue here is how to fix this bug efficiently. I believe that Geoff Garen has been contemplating this and also has a proposa

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

Our past experience with this sort of thing at Apple is that it led to bugs we didn’t find until after we shipped “final” software because they did not show up during earlier testing. Since then, we’ve gone out of our way to avoid differences, since one of the main things we want to do with non-

Re: [webkit-dev] webkit2 with v8

Are you a WebKit developer? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] webkit2 with v8

On Jun 1, 2012, at 9:55 AM, Jake wrote: > I believe it's a disservice to the community as a whole to not provide proper > javascript engine abstractions in webkit. I don’t agree. We should have abstractions for things that need to be abstract. Too many abstractions make the code much harder t

[webkit-dev] We should rename layoutTestController to testController

I am thinking we should rename layoutTestController to testController. Or if you don’t like that name, maybe testHarness or some even better name. The old name is too long and the word “layout” is so strange. We could expose the object under the new name and the old one, and then over time conv

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

Seriously, syntax is a significant barrier. Having to know which special characters to use. I don’t see this “clear delineation” you speak of. Just special punctuation I have to use to satisfy the computer. -- Darin ___ webkit-dev mailing list webkit-d

Re: [webkit-dev] Simplifying syntax in test_expectations.txt (bug 86691)

On May 17, 2012, at 4:30 AM, Ojan Vafai wrote: > I have a proposal that hopefully addresses everyone's concerns, is minimally > different from the current format *and* unifies the format with Skipped lists > (i.e. Skipped lists as they exist today are valid test_expectations.txt > format). The

Re: [webkit-dev] Using namespace std

On May 16, 2012, at 12:47 PM, James Robinson wrote: > On Wed, May 16, 2012 at 12:04 PM, Anders Carlsson wrote: > >> FWIW, I don't think we really need using directives for the std namespace - >> the fully qualified name is short enough and I like the additional clarity >> that we're calling so

Re: [webkit-dev] Using namespace std

On May 16, 2012, at 9:20 AM, Allan Sandfeld Jensen wrote: > there is another conflict which is entirely our own fault. It is between > WTF::bind and the new std::bind from C++11 We should find a good solution for this. I’d suggest talking with Anders Carlsson about it. -- Darin ___

Re: [webkit-dev] Access to WebElements through WebKit2 Touch API

On May 15, 2012, at 8:24 AM, Webkit Research wrote: > How can we get access in Webkit2 to all WebElements x/y coordinates for a > given loaded HTML page. Our problem is that the information we want is in the > DOM but the DOM does not seem accessible through the WebKit2 Touch API. This is the w

<    1   2   3   4   5   6   7   8   9   10   >