Re: [webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

On Nov 17, 2022, at 3:17 PM, Michael Catanzaro wrote: > On Thu, Nov 17 2022 at 02:48:04 PM -0800, Ryosuke Niwa > wrote: >> But every change in WebKit comes with a Bugzilla bug. > > Certainly most do, but some counterexamples: > > * Unreviewed build fixes sometimes do not reference a bug > * W

[webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

Hi, The following PR adds placeholder text in the commit log template to remind authors to explain why a change fixes a bug: Bug 248012: Update commit message template to request a brief explanation of why a PR fixes the bug

Re: [webkit-dev] WebKit project in Coverity

Hi, Back on Sept 18, 2019, Semmle announced that they would start scanning of projects on GitHub.com using their static analysis tool. As of July/August 2019, the WebKit mirror on GitHub includes analysis results* on their website, likel

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

I actually “missed” output from the stylebot insofar as I was expecting the errors to be posted, and then I was going to reply to that automated message. I think it’s too easy to ignore style errors if you have to click to load another website, though, so I filed this bug with some thoughts: Bu

Re: [webkit-dev] Watch out for std::optional's move constructor

Filed: Dave On Dec 14, 2018, at 2:18 PM, Adrian Perez de Castro wrote: > Hello, > > On Fri, 14 Dec 2018 14:02:39 -0800, Saam Barati wrote: > >>> On Dec 14, 2018, at 1:59 PM, Chris Dumez wrote: >>> On Dec 14, 2018, at 1:56 PM, Saam Bar

[webkit-dev] Please start using RELEASE_ASSERT_WITH_SECURITY_IMPLICATION()

Hello, TL;DR: Please start using RELEASE_ASSERT_WITH_SECURITY_IMPLICATION() in place of ASSERT_WITH_SECURITY_IMPLICATION() for new/updated code. It turns out that having some of these debug asserts enabled in release builds would have prevented security issues, so we’re going through and chang

Re: [webkit-dev] Are there any plans to upgrade bugzilla server on bugs.webkit.org?

Hi Ossy, On Apr 27, 2016, at 8:15 AM, Darin Adler mailto:da...@apple.com>> wrote: > Yes, we definitely want to upgrade. It’s a bit of work. In the past, I think > David Kilzer did some upgrades. I’ll try to find some time to do a Bugzilla upgrade soon. Currently I’ve been busy he

[webkit-dev] Interdiff fixed on bugs.webkit.org

I just fixed the ‘interdiff’ feature of Bugzilla. Now you can diff your diffs while you diff! The issue was apparently being tracked here: Bug 82517: Bugzilla should provide diffs between two patches Example:

[webkit-dev] bugs.webkit.org email outage; asynchronous mail queue enabled

Hello, The bugs.webkit.org site experienced a mail server outage from at least 10:55 PM PDT on Thursday, October 23 (possibly earlier) until about 11:08 AM PDT today (Friday, October 24). During this time, we enabled Bugzilla's asynchronous mail queue to unblock all other interaction with bugs

Re: [webkit-dev] Downtime for Bugzilla upgrade on Thursday, October 16 from 8-10 AM PDT

On Oct 16, 2014, at 4:04 PM, David Kilzer wrote: > On Oct 16, 2014, at 2:38 PM, David Kilzer wrote: > >> Two commit queue issues: >> >> 1. Patches are landing, but bugs aren't being closed. Looks like >> webkit-patch is failing because a textarea is d

Re: [webkit-dev] Downtime for Bugzilla upgrade on Thursday, October 16 from 8-10 AM PDT

On Oct 16, 2014, at 2:38 PM, David Kilzer wrote: > Two commit queue issues: > > 1. Patches are landing, but bugs aren't being closed. Looks like > webkit-patch is failing because a textarea is disabled by default. Bug 137794: commit-queue: fails to close bugs after suc

Re: [webkit-dev] Downtime for Bugzilla upgrade on Thursday, October 16 from 8-10 AM PDT

. Dave -- Sent from my iPhone 6 > On Oct 16, 2014, at 10:58 AM, David Kilzer wrote: > > Update complete. > > Please file bugs on bugs.webkit.org and reply to this thread with the bug. > > Thanks! > > Dave > -- > Sent from my iPhone 6 > >> On Oct 16, 2

Re: [webkit-dev] Downtime for Bugzilla upgrade on Thursday, October 16 from 8-10 AM PDT

Update complete. Please file bugs on bugs.webkit.org and reply to this thread with the bug. Thanks! Dave -- Sent from my iPhone 6 > On Oct 16, 2014, at 10:56 AM, David Kilzer wrote: > > Sorry, sent this from the wrong address before the update. > >> On Oct 16, 2014, at 3:

Re: [webkit-dev] Downtime for Bugzilla upgrade on Thursday, October 16 from 8-10 AM PDT

into many individual patches (and 3 merge patches); I didn't want to squash-merge it in case it was easier to fix a future bug based on these changes. Dave > (note): http://www.bugzilla.org/releases/4.4/release-notes.html#v44_feat > > br, > Ossy > > David Kilzer írta: &g

[webkit-dev] Downtime for Bugzilla upgrade on Thursday, October 16 from 8-10 AM PDT

Hi, We’re planning on upgrading Bugzilla (bugs.webkit.org) from 3.2.3 to 4.2.11 on Thursday, October 16 from 8-10 AM PDT. Sorry for the short notice. I sent this message from the wrong address, and didn't see he bounce message until now. Please let me know if you have questions or concerns.

Re: [webkit-dev] Fuzzinator, a mutation based web fuzzer

On Jun 25, 2013, at 1:56 AM, Renáta Hodován wrote: > Hi folks, > > as many of you know already I'm working on an universal web fuzzer, which is > able to generate random test cases for both svg, html, css and js, and test > them against any browser. With this method we can catch crashes, asser

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

On Feb 8, 2013, at 2:52 PM, Adam Barth wrote: > On Fri, Feb 8, 2013 at 2:45 PM, David Kilzer wrote: > >> The iOS port does not require re-architecting WebCore. >> >> Bug 109071 was about coming up with a better name for a method that is >> primarily used in

Re: [webkit-dev] Merging the iOS port to svn.webkit.org (Re: WebCore and interlocking threads)

On Feb 8, 2013, at 1:41 PM, Adam Barth wrote: > Context: https://bugs.webkit.org/show_bug.cgi?id=109071 > > Adam Barth said: >> It's not clear to me that running WebCore on multiple interlocked threads is >> a good idea. That >> seems like a pretty major change to WebCore's architecture. Is t

[webkit-dev] 'ANGLE' component added to bugs.webkit.org

I've added an 'ANGLE' component to bugs.webkit.org. Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] iOS parsing of the viewport meta tag

On Jul 10, 2012, at 9:22 AM, Adam Barth wrote: > On Tue, Jul 10, 2012 at 9:16 AM, David Kilzer wrote: >> On Jul 10, 2012, at 8:48 AM, Adam Barth wrote: >>> Parse the viewport meta tag like iOS >>> https://bugs.webkit.org/show_bug.cgi?id=72722 >>> >>>

Re: [webkit-dev] iOS parsing of the viewport meta tag

On Jul 10, 2012, at 8:48 AM, Adam Barth wrote: > Parse the viewport meta tag like iOS > https://bugs.webkit.org/show_bug.cgi?id=72722 > > Is the parsing code for the viewport meta tag in iOS open source? It's on in ViewportArguments.cpp. Dave

Re: [webkit-dev] spinoff from webkit-patch -g discussion

On Feb 29, 2012, at 3:28 PM, Dirk Pranke wrote: > In my view, I would actually rather upload the combination of > committed + staged + unstaged changes rather than be told I have to > commit things; in other words, I actually prefer to commit what I've > uploaded rather than upload what I've commi

Re: [webkit-dev] 48459: Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows

WebKitSystemInterface is owned by Apple. I would implement the fix without assuming that wkGetVerticalGlyphsForCharacters is available for Windows. Dave On Feb 26, 2012, at 4:46 AM, Koji Ishii wrote: > I found another library issue for how to get vertical alternate glyphs. > > Currently, >

Re: [webkit-dev] webkit

This account has been unsubscribed. Dave On Feb 25, 2012, at 6:57 PM, Eric Seidel wrote: > Please ban this spammer. > > On Sat, Feb 25, 2012 at 1:27 PM, Tyler Cumberton wrote: >> I have a question : webkit site >> >> -- >> -Tyler. >> >> ___ >> web

Re: [webkit-dev] git.webkit.org is offline

Bill is aware of the issue and is working on it right now. Dave On Feb 15, 2012, at 6:38 AM, Osztrogonac Csaba wrote: > Hi, > > It seems git.webkit.org is offline. > Could you check what happened? > > br, > Ossy > ___ > webkit-dev mailing list > web

Re: [webkit-dev] new API for offline web applications

How did you run the layout tests? The run-webkit-tests script should take care of starting the Apache web server for you with all the configuration options set. This is usually how you run just the http tests for a debug build (after running the build-webkit script): ./Tools/Scripts/run-webki

Re: [webkit-dev] new API for offline web applications

The abort() method is defined here: There is no abort() method defined in Source/WebCore/loader/appcache/DOMApplicationCache.idl. Please file a bug and attach a patch for review. See:

Re: [webkit-dev] Using C++ constant local variables in WebKit

On Nov 29, 2011, at 6:44 PM, Ryosuke Niwa wrote: > On Tue, Nov 29, 2011 at 6:42 PM, Ryosuke Niwa wrote: >> - Prevents misuse of variable in a later patch (by a different author) >> through enforcement of const-ness. > > Prevents one specific type of misuse: Setting the variable to another va

[webkit-dev] Using C++ constant pointers (type_name * const) in WebKit

In a discussion on Bug 71921, Antti, Darin Adler and I started a discussion about using C++ constant pointers in WebKit. Does the WebKit community have a consensus opinion on the matter? * Pros - Documents use of variable. - Prevents misuse of variable in a later patch (by a different autho

Re: [webkit-dev] Chromium Mac moving to Skia

On Aug 18, 2011, at 12:24 PM, Adam Barth wrote: > Moving the chromium-mac result directories caused more of a disruption > that I expected in that it apparently broke the git WebKit mirror. > I'd like to apologize for the disruption. We've done SVN server-side > moves before, so I'm not entirely

Re: [webkit-dev] WebKit blog post proposal: Remote debugging with Web Inspector.

Hi Pavel, You need to send the contents of the blog post via email. Not everyone can read it (even after logging in). Dave On Apr 29, 2011, at 11:44 AM, Pavel Feldman wrote: > Hi guys, > > I started drafting the blog post "Remote Debugging with Web Inspector": > http://www.webkit.org/blog/

Re: [webkit-dev] Some compile time data

On Apr 25, 2011, at 4:59 PM, Stephanie Lewis wrote: > One point brought up during the compile time discussion today was that if you > pulled once a day, you were likely to have rebuild the world. I thought it > would be interesting to see which files were contributing to rebuilding the > world

Re: [webkit-dev] coding style and comments

On Jan 28, 2011, at 9:36 AM, Peter Kasting wrote: > On Thu, Jan 27, 2011 at 4:27 PM, Simon Fraser wrote: > I think we have a distinct lack of comments that help novices to understand > the code. I feel that we almost have a "privileged few" mentality in some > code; if you can't figure it out b

Re: [webkit-dev] WebCore has moved: How to avoid merge conflicts

For git, I'm assuming the following works: Local changes: 1. git stash save "WIP" 2. git pull --rebase origin (or git svn rebase) 3. git stash pop Branches: 1. git checkout branchname 2. git rebase master However, it would be interesting to know if "diff.renames=true" or if "diff.renames=copy

Re: [webkit-dev] Random inspector crasher?

On Dec 23, 2010, at 6:02 AM, Carl Lobo wrote: > I'm not very sure if this is relevant but here goes: > I'm working on a javascript hosting framework (it's open source: > https://github.com/directi/webkit_titanium/tree/webkit_clean). > I'd pulled webkit git a couple of weeks back and then again a f

Re: [webkit-dev] Stability problems involving Javascript GC

On Dec 17, 2010, at 12:02 AM, Zoltan Herczeg wrote: >>> On 6 December 2010 22:31, Zoltan Herczeg wrote: Crash in WTF::fastMalloc? Such things only happen if something overwrites memory areas belongs to the memory manager (i.e overwrites some bytes before or after a block returned b

Re: [webkit-dev] Client-based Geolocation

On Dec 10, 2010, at 6:45 AM, John Knottenbelt wrote: > It would be great if, ultimately, we could remove the non-client-based > geolocation code from WebCore (I already have plans to do this for Chromium's > WebKit layer). Such a removal would make the WebCore code more readable > because the

Re: [webkit-dev] webkit-patch --suggest-reviewers

Thanks guys! I really like this feature, but it would be great if you could pick individuals from the list of suggested reviewers instead of all-or-none: https://bugs.webkit.org/show_bug.cgi?id=48182 Dave From: Adam Barth To: webkit-dev@lists.webkit.org Sen

Re: [webkit-dev] Review tool changes

On Sep 17, 2010, at 6:38 AM, Mike Pinkerton wrote: > On Fri, Sep 17, 2010 at 2:39 AM, Adam Barth wrote: > >> The tool has some problems on iPad. The issue is the bottom toolbar >> uses position: fixed, which seems to be frozen to the initial viewport >> on iPad. When you scroll, the bar stays

Re: [webkit-dev] Canvas component in Bugzilla

On Sep 14, 2010, at 10:22 PM, Darin Adler wrote: > On Sep 14, 2010, at 5:54 PM, Andreas Kling wrote: > >> I propose we add a "Canvas" component in Bugzilla. Thoughts? > > Sounds OK to me. Done. Dave -- Sent from my iPhone 4 ___ webkit-dev mailing l

Re: [webkit-dev] Number of pending commits

On Sep 7, 2010, at 9:51 AM, Eric Seidel wrote: > I also attempted to look through pending-commit last week. I decided > to clean it out someone needs to write a script which can make a guess > if a bug is landed or not. I would guess that over half of > http://webkit.org/pending-commit are alre

Re: [webkit-dev] Build system complexity

On Aug 12, 2010, at 3:54 AM, Dumitru Daniliuc wrote: > i completely agree with jeremy. is it possible to at least drop the cryptic > hashcodes/timestamps? without them, the .xcodeproj files should at least be > editable by hand. Doesn't gyp already generate Xcode projects for Chrome? I think

Re: [webkit-dev] Some new coding style rules

On Wed, August 4, 2010 at 11:56:53 PM, Sam Weinig wrote: > On Wed, Aug 4, 2010 at 1:29 AM, Nikolas Zimmermann > wrote: > > >namespace WebCore { > >... > >} // namespace WebCore > > > >2. ENABLE(FOO) #endif comments > > > >#if ENABLE(FOO) > >.. > >#endif // ENABLE(FOO) > > I like these two forms

Re: [webkit-dev] Auto-injecting JavaScript with DRT (was Introducing dumpAsMarkup)

On Jul 26, 2010, at 6:08 PM, Maciej Stachowiak wrote: > The main problem would be getting the right path to the script file. Unless > we duplicate it in every directory with script tests, it kinda has to be a > relative path that depends on the directory. Subversion (and git) handle relative s

Re: [webkit-dev] review queue crazy idea

We should also publicize/update these existing resources to help patch authors find reviewers for their patches: http://trac.webkit.org/wiki/CodeReview http://trac.webkit.org/wiki/WebKit%20Team I think the most effective approach is when patch authors proactively seek out reviewers. We're all

Re: [webkit-dev] Bugzilla Question - Master Bug vs Component?

On Jul 9, 2010, at 7:34 AM, Adam Roben wrote: > On Jul 9, 2010, at 6:23 AM, Alex Milowski wrote: > >> Should we keep the master bug? >> >> Should we use it only for our implementation efforts and not >> make it depend on every random bug filed for the MathML >> component? > > I think an import

Re: [webkit-dev] DerivedSources.make & CPP DOM Bindings

On Jul 8, 2010, at 11:04 AM, Kevin Ollivier wrote: > I'm working on making the CPP DOM bindings accessible to the wx port, and > while I've got the whole thing building, one thing I have yet to sort out is > how to add building of the CPP DOM bindings to the build system. > DerivedSources.make

Re: [webkit-dev] Should Table Cell (TD) children inherit height?

How do Firefox and MSIE render the test case? Dave -- Sent from my iPhone 3GS On Jun 28, 2010, at 11:42 AM, Fady Samuel wrote: > My understanding is that in quirks mode, causes the > table to fill the entire client window. Now, I believe the height attribute > should trickle down to the TR a

Re: [webkit-dev] strategy for evaluating performance issues related to memory.

On Jun 21, 2010, at 6:21 AM, Mike Marchywka wrote: > (and yes my disk light still comes on for minutes at a time locking me out of > doing antyhing with iceweasel or firefox) Two things: 1. What hardware platform and O/S are you running a WebKit browser on that still uses a disk light? (Do P

Re: [webkit-dev] LayoutTest with a fragment reported as the document URL?

I think you want: window.location.hash = 'name1'; I'm sure there are other layout tests that set the hash property, so you might search for them to get some ideas about how to build your test. Dave -- Sent from my iPhone 3GS On Jun 7, 2010, at 2:04 PM, Chris Fleizach wrote: > > I'd like the

Re: [webkit-dev] WebCore Build Times

On Jun 8, 2010, at 3:17 PM, Eric Seidel wrote: > On my Intel Core 2 Duo MBP a full build takes over 1 hour. 5 years > ago, on my g4 laptop a full build took around 40m. :( We seem to be > slowly moving in the wrong direction. Was that before or after SVG was enabled in the engine? :) In gen

Re: [webkit-dev] Directory upload experimental feature

Also, I was simply pointing out existing behavior, not arguing for/against the zip file format. Dave From: Sam Weinig To: David Kilzer Cc: John Gregg ; webkit-dev@lists.webkit.org; Adele Peterson Sent: Wed, June 2, 2010 11:28:11 AM Subject: Re: [webkit

Re: [webkit-dev] Directory upload experimental feature

> Other alternatives? I believe Safari will zip a folder and send it as a single file for you if you attach a folder to a file upload element instead of an individual file. Dave From: John Gregg To: Sam Weinig Cc: webkit-dev@lists.webkit.org Sent: Tue, June

Re: [webkit-dev] svn-apply: ideal fuzz value to merge changelogs

Providing 8 lines of context instead of 3 lines to the ChangeLog part of a patch isn't going to help with reviewing or merging patches. If you want to provide more context to the rest of the patch, I think you should find a way to keep the number of lines of context for ChangeLog diffs to 3 lin

Re: [webkit-dev] webkit-patch, check-webkit-style and git now support --squash and --git-commit

On Fri, May 14, 2010 at 6:29:05 PM, Ojan Vafai wrote: > tonikitoo, aroben, ddkilzer: You are the three who I remember > voicing yourselves about wanting webkit-patch to support > committing/uploading multiple patches from the same branch. > Would Chris's suggestion below (last couple paragraphs) b

Re: [webkit-dev] Yet another bug-less change hosed the tree.

On Tue, May 11, 2010 at 2:30:45 PM, Geoffrey Garen wrote: > I don't know how to do either of these steps in an easy way: > > 1. Once I have a patch with a ChangeLog, say, "File a new > bug and upload this patch for review." (Bonus points if the > tool automatically made the first line of the Cha

Re: [webkit-dev] Bugzilla "Triaged" keyword

I've renamed "Triaged" to "QtTriaged". Dave - Original Message > From: Jocelyn Turcotte > To: webkit-dev@lists.webkit.org > Sent: Tue, April 27, 2010 10:02:36 AM > Subject: Re: [webkit-dev] Bugzilla "Triaged" keyword > > On 4/27/2010 5:38 PM, ext Alexey Proskuryakov wrote: > 27.04.20

Re: [webkit-dev] Buildbot Updates

On Tue, April 13, 2010 at 9:02:39 AM, William Siegrist wrote: > Our buildbot master has been updated to the latest python and buildbot > versions. > We also have new Qt bots per the previous webkit-dev thread as well as a bot > using new-run-webkit-tests (mac-leopard). Let me know if you see a

Re: [webkit-dev] Git meeting notes

Sure, but you have to rebuild WebKit for each test during the git-bisect. Being able to use pre-built binaries is faster, especially if they're already downloaded. Dave From: Daniel Cheng >To: David Kilzer >Cc: Timothy Hatcher ; Alexey Proskuryakov >; WebKit Development >

Re: [webkit-dev] Proposal: commit-queue to fix usernames after commit

On Mon, April 12, 2010 at 4:56:51 PM, Eric Seidel wrote: > I would love to hear your feedback! Sounds great! Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Git meeting notes

It's not immediately clear how to sort a list of commit hashes into a sequential list, e.g., if using a list of nightly builds for a binary regression search. Perhaps there is a git command that sorts them for you given an existing repository? Dave On Mon, April 12, 2010 at 8:15:40 PM, Timo

Re: [webkit-dev] git.webkit.org is missing svn revision r49890

The git.webkit.org repo has now been updated. Please refer to the bug for instructions on how to update your local repository. git.webkit.org repository is missing svn revision r49890 <https://bugs.webkit.org/show_bug.cgi?id=36193> Dave On Tue, March 16, 2010 at 2:33:44 PM, David

[webkit-dev] git.webkit.org is missing svn revision r49890

It was discovered recently that the git repository on git.webkit.org is missing svn revision r49890. This causes problems if you're using a single git repository, pulling from git.webkit.org, and using git-svn-fetch from svn.webkit.org (so that you can

Re: [webkit-dev] minimum python version to support

On Thu, March 4, 2010 at 5:35:08 PM, William Siegrist wrote: > On Mar 4, 2010, at 3:39 PM, Chris Jerdonek wrote: > > > [Resending from correct address.] > > > > On Thu, Mar 4, 2010 at 1:05 PM, Maciej Stachowiak wrote: > > > >> 4) If we have a smooth way to do it, then locally installing a newe

Re: [webkit-dev] Signing up to help with some SVG bugs

To contributed to WebKit, see: To contact other developers, see: Dave From: Mark Wyszomierski >To: webkit-dev@lists.webkit.org >Sent: Thu, January 28, 2010 8:24:48 PM >Subject: [webkit-dev] Signing up to help with

Re: [webkit-dev] changelogs: a reprise

On Thu, January 28, 2010 at 4:10:11 AM, Chris Jerdonek wrote: > On Tue, Jan 26, 2010 at 9:55 AM, David Kilzer wrote: > >> (2) Consider phasing in support for an alternate workflow where new > >> ChangeLog entries for the next commit are stored separately from the > >

Re: [webkit-dev] changelogs: a reprise

On Mon, January 25, 2010 at 10:35:00 PM, Chris Jerdonek wrote: > I was reading through the old "I HATE CHANGELOGS" messages from August: > > https://lists.webkit.org/pipermail/webkit-dev/2009-August/thread.html > > The discussion attracted a lot of interest and ideas, but it looks > like it died

Re: [webkit-dev] Showing Baseline and Container Box

On Mon, January 25, 2010 10:42:56 AM, Alex Milowski wrote: > On Mon, Jan 25, 2010 at 10:31 AM, Maciej Stachowiak wrote: > > > > It's reasonable to use an ENABLE() flag for debugging features like this, > > in > my opinion. I don't know if we have any direct precedent. > > Doesn't ENABLE() requi

Re: [webkit-dev] webkit team wiki page

On Sun, January 24, 2010 at 7:09:26 PM, Maciej Stachowiak wrote: > I think deleting the areas of knowledge is a regrettable loss of information. > I > think it's helpful to give people at least a few starting points for their > questions, because not everyone is going to be comfortable firing r

Re: [webkit-dev] questions about allow-tabs

On Fri, January 15, 2010 1:52:19 PM, Chris Jerdonek wrote: > On Thu, Jan 14, 2010 at 9:05 PM, David Kilzer wrote: > > On Thu, January 14, 2010 at 6:59:17 PM, Chris Jerdonek wrote: > >> While I'm asking, I might as well also ask -- what other subversion > >> prop

Re: [webkit-dev] questions about allow-tabs

On Thu, January 14, 2010 at 6:59:17 PM, Chris Jerdonek wrote: > I have some background questions about the "allow-tabs" property. I > imagine it pre-dates check-webkit-style by quite a while. > > (1) What's the reason and history behind our use of the property? The allow-tabs property (and the

Re: [webkit-dev] webkit.org/pending-review

I'm pretty sure it's set up as a redirect in the Apache config for webkit.org. $ curl -I http://webkit.org/pending-review HTTP/1.1 301 Moved Permanently Date: Thu, 14 Jan 2010 17:19:39 GMT Server: Apache/2.2.14 (Unix) mod_ssl/2.2.14 OpenSSL/0.9.8l DAV/2 mod_python/3.3.1 Python/2.5.4 Location: ht

Re: [webkit-dev] Error Building under ubuntu

Please use the webkit-help mailing list for questions like this. Thanks! Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] File::Spec->tmpdir() on Leopard and Snow Leopard bots

On Fri, January 8, 2010 at 12:39:41 AM, Andras Becsi wrote: > in the process of making it possible to run more than one instance of > run-webkit-tests at the same time > (https://bugs.webkit.org/show_bug.cgi?id=33153), I'm trying to make the > handling > of running httpd processes more platf

Re: [webkit-dev] how to map local file extension to the MIMEType

On Mon, January 4, 2010 at 5:19:46 PM, Fei Wang wrote: > I define my own MIMEType like application/foo with file extension .foo. It > works > fine if I serve file through web server ( inside web server configuration, I > add > application/foo foo to the mime type map). In the webkit, I modif

Re: [webkit-dev] build system for wince port

On Thu, December 24, 2009 at 1:51:43 AM, Patrick Roland Gansterer wrote: > On Thu, Dec 24, 2009 at 02:53:18, Adam Barth: > > I'm worried that the port will rot without an active maintainer, no > > matter which build system you choose. > If i choose my preferred solution, there will be many changes

Re: [webkit-dev] [webkit-changes] [52439] trunk/WebCore

On Wed, December 23, 2009 at 4:34:06 AM, Evan Martin wrote: > On Mon, Dec 21, 2009 at 12:20 PM, David Kilzer wrote: > > Setting "[diff] renames = copies" in ~/.gitconfig or in your > > .git/config file for each project will make git diff try to > > do rename detecti

Re: [webkit-dev] [webkit-changes] [52439] trunk/WebCore

wrote: > > > >> I'm happy to move the commit-queue to use an SVN checkout instead if > >> that would be a desired change. :) > > > > Yes please. > > > > - Maciej > > > >> > >> -eric > >> > >> On Mon, Dec 21,

Re: [webkit-dev] How to add a new interface for ObjC bindings?

files as well. That will make it easier to prevent broken builds in various ports when this change lands. Hope that helps! Dave From: Jian Li >To: David Kilzer >Cc: webkit-dev@lists.webkit.org >Sent: Tue, December 22, 2009 6:54:29 PM >Subject: Re: [webkit-dev] H

Re: [webkit-dev] How to add a new interface for ObjC bindings?

All the magic for the Obj-C DOM headers happens in: WebCore/DerivedSources.make WebKit/mac/MigrateHeaders.make It should be added as a PrivateHeader first, if at all. Someone else will have to address COM bindings since I don't know much about those. Dave From: Jian Li >To: webkit-dev@lists

Re: [webkit-dev] HELP - Need Information ****URGENT****

Please stop sending these messages to webkit-dev. They're getting through, but you're asking on the wrong list. Try instead. You only need to post it once. Thanks. Dave From: R Kalyan >To: webkit-dev@lists.webkit.org >Sent: Tue, December 22, 2009 6:53:28 AM >Subject: [webkit-dev] HELP -

Re: [webkit-dev] [webkit-changes] [52439] trunk/WebCore

If you want to make sure you're not going to lose history, you should use svn directly. The svn-apply script already knows all the magic to do the right thing...if you used svn-create-patch to create the patch *and* if you're committing to an svn repository. The "git svn dcommit" command (espe

Re: [webkit-dev] Should we put the webkit.org mailing lists on Gmane?

On Mon, December 14, 2009 at 6:47:50 PM, Adam Roben wrote: > On Jun 13, 2009, at 9:00 AM, Adam Roben wrote: > > > I think it would be good to put our mailing lists on Gmane (including > importing the archives of the lists). > > The lists are now all on Gmane. Archives for the newer lists have n

Re: [webkit-dev] TARGET_OS_EMBEDDED

On December 4, 2009 at 9:29:11 AM, Maciej Stachowiak wrote: > On Dec 4, 2009, at 5:51 AM, Zoltan Herczeg wrote: > > > Hi, > > > > it would be a great to have a macro in WebKit, which would be enabled on > > embedded systems. We could replace macros like PLATFORM(SYMBIAN) in > > TextCodecQt.cpp t

Re: [webkit-dev] Question on standards mode vs. site compatibility

Both Firefox and WebKit allow you to file evangelism bugs on any web site. Perhaps it would be best to try that approach first? Dave > >From: Chris Evans >To: Darin Adler >Cc: webkit-dev@lists.webkit.org >Sent: Tue, November 10, 200

Re: [webkit-dev] Calling all committers: The pending-commit list is overflowing

Why are there 17 patches with review+ that never get landed? This has bothered me in the past, but I wasn't sure if it was the same group of patches or not. Dave On Mon, October 19, 2009 at 7:08:50 PM, Adam Barth wrote: > WebKit, you are awesome. We're down to our usual 17 now. > > Thanks e

Re: [webkit-dev] MIPS JIT Supports

If you'd like a patch reviewed, please set the "review?" flag on the patch in bugs.webkit.org. For more information, see: Dave - Original Message > From: "Fu, Chao-Ying" > To: webkit-dev@lists.webkit.org > Sent: Tuesday, October 6, 2009

Re: [webkit-dev] js-only-tests migration from "resources" to "script-tests"

What error(s) did you get when you tried to commit them? Dave > >From: Shinichiro Hamaji >To: Eric Seidel >Cc: webkit-dev@lists.webkit.org >Sent: Saturday, September 19, 2009 3:43:25 AM >Subject: Re: [webkit-dev] js-only-tests migration from "resources" to >"script-tests" > >>+webkit-dev (I s

Re: [webkit-dev] Changes to prepare-ChangeLog

On Wednesday, September 2, 2009 at 8:14:14 AM, Adam Roben wrote: > On Sep 1, 2009, at 9:03 PM, David Kilzer wrote: > > > Not git-friendly enough, IMO. I like this better: > > > > 2009-09-01 Adam Roben > > > >Need a bug title and URL (OOPS!) >

Re: [webkit-dev] Changes to prepare-ChangeLog

On Tuesday, September 1, 2009 at 12:59:10 PM, Adam Roben wrote: > So, I propose that we change the prepare-ChangeLog template to the following: > > 2009-09-01 Adam Roben > > Reviewed by NOBODY (OOPS!) > > Need a short description of this patch (OOPS!) > > Need a bug

Re: [webkit-dev] I *HATE* CHANGELOGS!!!

On Friday, August 28, 2009 at 1:05:57 PM, Jeremy Orlow wrote: >On Fri, Aug 28, 2009 at 12:26 PM, Brady Eidson wrote: > >>Mark Rowe already pointed out - doing an automated step for >>each checkin that causes another checkin would be ridiculous. >>But how about a nightly script that checks in a Cha

Re: [webkit-dev] svn-* scripts

On Friday, August 21, 2009 at 5:32:14 PM, Darin Adler wrote: > I’m a little irritated that we’re changing our Subversion scripts, > svn-create-patch, svn-apply, and svn-unapply into WebKit-specific scripts. > Previously, they were scripts that were independent of the particular project > that e

Re: [webkit-dev] r45939 broke my workflow

> > Is there an easy fix to svn-apply and svn-unapply that you can make? > > I believe there is an easy fix for this particular workflow, which is to make > svn-apply and svn-unapply behave the same way as svn-create-patch. Dave

Re: [webkit-dev] r45939 broke my workflow

On Friday, August 21, 2009 at 1:10:31 PM, Geoffrey Garen wrote: > r45939 broke my workflow. Here's the related bugzilla bug: > https://bugs.webkit.org/show_bug.cgi?id=26999. > > Old "Roll out a patch" workflow: > > cd JavaScriptCore > svn-create-patch > patch.txt > svn-unapply patch.txt > > O

Re: [webkit-dev] Bugzilla Data Loss

On Friday, August 21, 2009 at 7:59:11 AM, Ryan Leavengood wrote: > On Fri, Aug 21, 2009 at 1:54 AM, Peter Kastingwrote: > > > but patches that were merely attached to bugs have vanished. > > Hopefully you still have local copies and can re-attach them! > > This sort of thing tends to put a kib

Re: [webkit-dev] resolve-ChangeLogs now seems to be broken the same was prepare-ChangeLog was before

On Monday, August 10, 2009 10:27:00 AM, Darin Adler wrote: > $ resolve-ChangeLogs WebCore/ChangeLog > svn: warning: > '../../../../Volumes/Home/darin/Safari/OpenSource/WebCore/ChangeLog' is not a > working copy > WARNING: ../../../../Volumes/Home/darin/Safari/OpenSource/WebCore/ChangeLog > is

Re: [webkit-dev] Towards a commit-queue

On Saturday, August 1, 2009 11:45:43 AM, Ojan Vafai wrote: >On Sat, Aug 1, 2009 at 2:08 PM, Adam Barth wrote: >>On Sat, Aug 1, 2009 at 11:04 AM, David Kilzer wrote: >>> Bugzilla has the ability to create additional 4-state flags at >>> both the attachment level and at

Re: [webkit-dev] Towards a commit-queue

On Saturday, August 1, 2009 10:16:39 AM, Adam Barth wrote: > On Sat, Aug 1, 2009 at 8:43 AM, tonikitoo (Antonio Gomes)wrote: > > Adam, as I suggedted previously, bugzilla supports KEYWORDs, so that > > would be a matter of adding a special support for bugs where patches > > are ready to go in. > >

Re: [webkit-dev] Memory leak or should I clear content of QWebPage?

On Wednesday, July 29, 2009 8:40:59 AM, Zongheng Zhou wrote: >After I load "www.cnn.com"; for 800 times consecutively, >the virtual memory size of my little program has reached >1600M; while the resident memory is 1500M > >This is horribleIs this kind of memory leak expected? Of course

Re: [webkit-dev] Patch process - let's make it better

On Saturday, July 11, 2009 11:55:36 AM, Maciej Stachowiak wrote: > On Jul 11, 2009, at 9:39 AM, Darin Adler wrote: > > > On Jul 10, 2009, at 4:23 PM, Maciej Stachowiak wrote: > > > >> Perhaps we should make update-webkit (or some new wrapper type tool) > >> run resolve-ChangeLogs automatically.

  1   2   3   >