Re: [webkit-dev] Adding reverse flag to Widget::SetFocus?

; if (event->focuseDirection() == FocusDiectionForward) > setFocusToField(0); >else > setFocusToField(m_lastFieldIndex); > >// Not sure about FocusDirectionUp/Down >// Need RTL support for FocusDirectionLeft/Right. Move focus &g

[webkit-dev] Adding reverse flag to Widget::SetFocus?

Hi all, I'm working on a plugin that needs to deal with focus. I'd like this plugin to look an feel just like any other DOM element including the way it deals with focus. The problem that I have is Widgets know about focus but not focus direction (forward/reverse). My plugin has several logical su

Re: [webkit-dev] Tab focus order for plugins

Oops, lost the link in the email: https://bugs.webkit.org/show_bug.cgi?id=88958 On Tue, Jun 26, 2012 at 1:26 PM, Fady Samuel wrote: > Hi all, > > ap@ is away until July 18, and I was hoping to get some feedback on this > change for the WebCore changes. > > In a nutshell,

[webkit-dev] Tab focus order for plugins

Hi all, ap@ is away until July 18, and I was hoping to get some feedback on this change for the WebCore changes. In a nutshell, we'd like certain plugins in chromium to participate in tab focus. My understanding from a recent thread in whatwg

Re: [webkit-dev] Device and page scaling

This sounds good to me, but is there any reason why we can't support physical device changes (switching monitors) and support target-densitydpi? This would be highly desirable for us. Fady == Page::effectiveDeviceScaleFactor == > > Page::effectiveDeviceScaleFactor starts off as matching > Page::d

Re: [webkit-dev] Understanding WebKit layering and layering violations

end on? Thanks, Fady On Thu, Jan 5, 2012 at 7:39 PM, Adam Barth wrote: > On Thu, Jan 5, 2012 at 4:18 PM, Fady Samuel wrote: > > I've been working on WebKit off and on for a while now but I must admit > > that, up to this point, I still don't have a firm grasp of all the &

[webkit-dev] Understanding WebKit layering and layering violations

ebKit community! Thanks, Fady Samuel ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Confusion over over-constrained case in RenderBox::computePositionedLogicalWidthUsing

Hi all, I'm currently studying layout code in RenderBox very carefully as I work on this: https://bugs.webkit.org/show_bug.cgi?id=47738 I'm a bit confused about something fairly subtle. In the overconstrained case where logical left, logical width, and logical right are all specified, we should i

Re: [webkit-dev] Forcing relayout on style change

Perfect! This is exactly what I was looking for, thanks! Fady On Thu, Nov 17, 2011 at 11:11 AM, Dan Bernstein wrote: > > > On Nov 17, 2011, at 7:55 AM, Fady Samuel wrote: > > Hi all, > > I've been in the process of implementing the aspect-ratio CSS property. I >

[webkit-dev] Forcing relayout on style change

Hi all, I've been in the process of implementing the aspect-ratio CSS property. I have a patch that plumbs the property to RenderStyle. I'd like to include code that force relayout upon a change to aspect ratio on the associated RenderBox.. Here's a patch from a couple of days ago of what I curre

Re: [webkit-dev] CSS Aspect Ratio Parsing Stage Up For Review

Fady On Tue, Oct 25, 2011 at 6:46 PM, David Hyatt wrote: > I'll take a look. I really like the proposal and the property definition. > > dave > (hy...@apple.com) > > On Oct 24, 2011, at 12:01 AM, Fady Samuel wrote: > > Hi all, > > I've uploaded the parsin

Re: [webkit-dev] CSS Aspect Ratio Parsing Stage Up For Review

Hi Edward, Object fit doesn't solve quite the same problem. This property is meant to work with all kinds of boxes, except table cells. Fady On Tue, Oct 25, 2011 at 2:23 PM, Edward O'Connor wrote: > Hi Fady, > > You wrote: > > I've uploaded the parsing stage for the -webkit-aspect-ratio proper

[webkit-dev] CSS Aspect Ratio Parsing Stage Up For Review

Hi all, I've uploaded the parsing stage for the -webkit-aspect-ratio property that was proposed here: http://www.xanthir.com/blog/b4810 The parsing implementation can be found here: https://bugs.webkit.org/show_bug.cgi?id=70707 An old, experimental implementation of the entire feature was uplo

[webkit-dev] Compiling chromium webkit unit tests on Mac

Hi all, I apologize for sending this out to such a broad audience, but I'd like to know how to compile the chromium webkit unit tests on Mac? I tried this: xcodebuild -project third_party/WebKit/Source/WebKit/chromium/WebKit.xcodeproj -configuration Debug -target webkit_unit_tests It complains a

Re: [webkit-dev] Making PopupMenuClient testable

*ping* I'd love to get some feedback on https://bugs.webkit.org/show_bug.cgi?id=69631. :-) Thanks, Fady On Mon, Oct 10, 2011 at 5:27 PM, Fady Samuel wrote: > Please review then? :-) > > Fady > > On Mon, Oct 10, 2011 at 9:11 PM, Darin Adler wrote: > > On Oct 10, 201

Re: [webkit-dev] Making PopupMenuClient testable

Please review then? :-) Fady On Mon, Oct 10, 2011 at 9:11 PM, Darin Adler wrote: > On Oct 10, 2011, at 7:57 AM, Fady Samuel wrote: > >> My solution in 69631 is to expose the bounding box rect through the >> PopupMenuClient interface and make it testable through window.intern

Re: [webkit-dev] Making PopupMenuClient testable

Hi Johnny, >>> What I mean is regular render tree dump, not pixel dump, not text dump. >>> Please refer here for test expectation and see in TestShell::dump in DRT >>> chromium port  I don't believe a render tree dump will solve this problem because the issue is the rect that is being passed in

Re: [webkit-dev] Making PopupMenuClient testable

ne would test this. Right now the test fails, but once 66062 is applied the test will pass. Is this a reasonable approach? Thanks, Fady On Mon, Oct 10, 2011 at 10:41 AM, Johnny Ding wrote: > > > 在 2011年10月7日 下午11:56，Fady Samuel 写道： > > Hi all, >> >> I've just

[webkit-dev] Making PopupMenuClient testable

Hi all, I've just uploaded a patch https://bugs.webkit.org/show_bug.cgi?id=69631 that's intended to make PopupMenuClient testable. On certain Chromium platforms, the position of the element's popup is incorrect if the page's scale factor is not 1.0. The fix to the problem is simple, see https:/

Re: [webkit-dev] Adding "Scroll Padding" to allow scroll beyond the edge of the page (within some bounds)

Fri, Oct 7, 2011 at 11:27 AM, Robert Kroeger wrote: > On Thu, Oct 6, 2011 at 2:02 PM, Antonio Gomes wrote: > > From what I tested on iOS5 Mobo Safari, it also overscroll's the > > overflow:scroll case (generally div's). > > > > On Thu, Oct 6, 2011 at 1:47 PM, Fad

Re: [webkit-dev] Adding "Scroll Padding" to allow scroll beyond the edge of the page (within some bounds)

: > Do you envision this being useful on overflow:scroll regions as well or is > it just frames? If it's just frames, then it seems like something we could > keep in ScrollView? (I haven't looked at the patch yet). > > - Anders > > On Oct 6, 2011, at 10:41 AM, Fady Samuel w

Re: [webkit-dev] Adding "Scroll Padding" to allow scroll beyond the edge of the page (within some bounds)

olling, > this padding would be between the content and the overhang area? > > As far as constrainsScrollingToContentEdge goes, I'd like to get rid of it > and just have two scroll functions, one that constrains to the content edge > and one that doesn't. > > - Anders >

[webkit-dev] Adding "Scroll Padding" to allow scroll beyond the edge of the page (within some bounds)

Hi all, We'd like to provide a general mechanism in WebKit for embedders to scroll page content so that it is not hidden by embedder-provided UI elements that overlap the page. In some cases, if a floating UI element overlaps the edge of the page, we'd like to allow the embedder to scroll beyond

[webkit-dev] Making top-level style changes through window.internals

ect to exposing document-level styles to window.internals? If not there, is there anywhere else where this can be exposed for testing purposes? Thanks, Fady Samuel ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/list

[webkit-dev] WebKit layout rect, and scroll area

Hi all, I was wondering if it's possible to tell webkit to layout a page at a particular resolution while telling it to provide a smaller scroll area? Thanks, Fady Samuel ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webki

Re: [webkit-dev] Six new layout tests missing expected results

So sorry. I had to leave before I got in another patch that fixed the problem. Will have it fixed tomorrow. Fady On Wed, Aug 18, 2010 at 11:08 PM, Dimitri Glazkov wrote: > Yep. It's his. He doesn't have a Mac, so he's been trying to collect > results from the bot pretty much all day today. Given

Re: [webkit-dev] Some landed patches have incorrect date in commit messages and ChangeLog

What about the case where between the time you submit the patch and it gets committed, a day passes by...does the commit queue fix this automatically, or does someone have to go back and fix it manually? Fady On Mon, Aug 9, 2010 at 1:51 PM, Jian Li wrote: > Hi, > > I noticed that several patche

[webkit-dev] Integral Type Size of pointer for platform?

Does WebKit define somewhere an integral type that's guaranteed to be the same size as the platform's pointer type? Thanks, Fady Samuel ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] SVG cloneNode?

I have just added a bugzilla bug: https://bugs.webkit.org/show_bug.cgi?id=41421 I looked at SVGAnimatedProperty.h briefly but I can't think of a clever way to modify it so that there's a nice, general way to copy these animated attributes to the cloned node. I believe a bunch of files will need t

Re: [webkit-dev] SVG cloneNode?

Hi Darin, I've attached a sample html file that creates an ellipse and then clones it. The cx, cy, rx, ry properties are not cloned and so we do not see the second ellipse. Fady On Wed, Jun 30, 2010 at 1:41 PM, Darin Adler wrote: > On Jun 30, 2010, at 10:38 AM, Fady Samu

Re: [webkit-dev] SVG cloneNode?

Sorry for the premature send. StyledElment's void copyNonAttributeProperties(const Element *sourceElement) for every single SVG node. Do you think this is the case or is there a nicer way to do this that doesn't involve my modifying 100+ files? Thanks, Fady On Wed, Jun 30, 2010 at 1:3

[webkit-dev] SVG cloneNode?

So I'm looking at cloning SVG nodes in Javascript, and it's looking to me like SVG-specific properties aren't copied on cloning. I don't see SVG properties being stored in an attribute or property map, which suggests to me I'm going to need to modify every single SVG node class, overriding StyledEl

Re: [webkit-dev] Should Table Cell (TD) children inherit height?

er the test case? > > Our rendering on this content matches Firefox in both quirks and standards > mode. I also do not know if a reason per spec for the div to get 100% > height. Height does not inherit. > > - Maciej > > > > > Dave > > -- > > Sent from

[webkit-dev] Should Table Cell (TD) children inherit height?

have a size of 0? WebKit will show you red instead of green because the div does not have a height of 100%. Now if you make the div's height 100%, you get green. Should a cell's child inherit height? Thanks, F

Re: [webkit-dev] Table hit testing

So a first patch is now available for review here: https://bugs.webkit.org/show_bug.cgi?id=40775 Thanks, <https://bugs.webkit.org/show_bug.cgi?id=40775> Fady 2010/6/8 Fady Samuel > So I was just about ready to post a potential patch for keeping track of > all cells that lie on

[webkit-dev] Initialization of Attribute Map

ed. Looking at other code, it appears that the attribute map is created lazily when needed. Is this the solution or is there a fundamental assumption being violated here that I should dig deeper into? Thanks, Fady Samuel ___ webkit-dev mailing list we

Re: [webkit-dev] Table hit testing

8, 2010 at 10:55 AM, Fady Samuel wrote: > So I was just about ready to post a potential patch for keeping track of > all cells that lie on a given grid slot. It seems that information is > insufficient for correct rendering. > > Consider the attached test case: > > 1 R1C4 sp

Re: [webkit-dev] Table hit testing

ly will be discussed here shortly. Fady On Wed, Jun 2, 2010 at 4:40 PM, Fady Samuel wrote: > So I have completed all the following things locally: > > > * First fix the grid to record all the cells at a given position. This > fixes a repaint bug. > * Then change the hit-testing to wo

Re: [webkit-dev] Table hit testing

(within the next couple of days or so). Thanks, Fady Samuel On Wed, Jun 2, 2010 at 7:34 AM, Fady Samuel wrote: > Ohh, I see, thanks Roland. > > Fady > > > On Wed, Jun 2, 2010 at 3:25 AM, Roland Steiner > wrote: > >> AFAICT you could have an arbitrary number up

Re: [webkit-dev] Table hit testing

erlapping): > > > R1C1R1C2\\ > R2C1 valign=bottom>// > > > > - Roland > > On Wed, Jun 2, 2010 at 8:58 AM, Fady Samuel wrote: > >> Hi David, >> >> Just so I'm certain, there's no way for more than two cells to overlap in >>

Re: [webkit-dev] Table hit testing

Hi David, Just so I'm certain, there's no way for more than two cells to overlap in a single grid slot, is there? Thanks, Fady Samuel On Thu, May 20, 2010 at 4:43 PM, David Hyatt wrote: > On May 20, 2010, at 3:38 PM, Fady Samuel wrote: > > > So what are the rules for

Re: [webkit-dev] Table rendering and colspans

I just tested this with IE8. It appears IE's behavior matches Opera's in these cases. Fady On Thu, May 27, 2010 at 3:25 PM, Fady Samuel wrote: > Sorry, I was playing around with t8_simple at the last minute and I changed > the colspan. I have attached the test as I descri

Re: [webkit-dev] Table rendering and colspans

Sorry, I was playing around with t8_simple at the last minute and I changed the colspan. I have attached the test as I described it. Fady On Thu, May 27, 2010 at 3:16 PM, Fady Samuel wrote: > Hi, > > I have a quick question (*crosses fingers*) about colspans in webkit. I've >

[webkit-dev] Table rendering and colspans

s of the table rendering code for performance reasons so it would be nice to know if these are legitimate table rendering bugs that should be ironed out or the current webkit behavior is good. Thanks, Fady Samuel Title: Blah cell 1,1

Re: [webkit-dev] Table hit testing

I'm still confused about the proper ordering of painting/hit testing cells for a given grid position. In the example you provided, David, WHY does cell 7 have precedence over cell 5? Is it based on the order they're defined? Thanks, Fady On Thu, May 20, 2010 at 4:47 PM, Peter Kasting wrote: >

Re: [webkit-dev] Table hit testing

So what are the rules for stacking here? do the cells stack in the order in which they appear in the HTML? Cell 7 is defined after cell 5 and therefore it "owns" that position? Thanks, Fady On Thu, May 20, 2010 at 4:18 PM, David Hyatt wrote: > On May 20, 2010, at 3:07 PM, David Hyatt wrote: >

Re: [webkit-dev] Table hit testing

> and nodeAtPoint), and then if you want to optimize further, I'd expect to > see optimizations to both painting and hit testing made together. > > dave > (hy...@apple.com) > > On May 20, 2010, at 10:58 AM, Fady Samuel wrote: > > So I have an implementation that seems to be

Re: [webkit-dev] Table hit testing

y On Tue, May 18, 2010 at 3:03 PM, Fady Samuel wrote: > Ohh I see, I was confused about this line in RenderTable: > > 1138 if (!hasOverflowClip() || overflowClipRect(tx, ty).contains(xPos, > yPos)) { > > It seems that the default case is to visit all the children as

Re: [webkit-dev] Table hit testing

hit testing to avoid visiting all children. Thanks again, Fady On Tue, May 18, 2010 at 2:57 PM, David Hyatt wrote: > > On May 18, 2010, at 12:52 PM, Fady Samuel wrote: > > Hi all, > > > > I'm looking at table hit testing, and in all the simple test cases I'

[webkit-dev] Table hit testing

re any complications here that I should be aware of that resulted in this inefficient solution? Thanks, Fady Samuel ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev