Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-28 Thread Glenn Adams
On Fri, Jul 26, 2013 at 9:07 PM, Benjamin Poulain benja...@webkit.orgwrote: On Fri, Jul 26, 2013 at 1:57 AM, Mario Sanchez Prada mario.pr...@samsung.com wrote: Ah, When I made a new patch, had doubts about the file name Deprecated. So, I have to wait the StyleBuilder Class to have a

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Glenn Adams
On Tue, Jul 23, 2013 at 12:17 AM, Kyounga Ra kyounga...@gmail.com wrote: Hi webkit-dev! I'd like to add new feature for CSS nav-[dir] properties. https://bugs.webkit.org/show_bug.cgi?id=66027 This feature is for http://dev.w3.org/csswg/css3-ui/#nav-dir On recent discussion, these nav-*

Re: [webkit-dev] When should I use AtomicString vs String?

2013-06-02 Thread Glenn Adams
On Sun, Jun 2, 2013 at 2:48 AM, Maciej Stachowiak m...@apple.com wrote: On Jun 1, 2013, at 8:54 PM, Glenn Adams gl...@skynav.com wrote: You guys obviously never wrote any Lisp code. Um, why do you think I suggested Symbol? On Jun 1, 2013, at 9:09 PM, Glenn Adams gl...@skynav.com

Re: [webkit-dev] When should I use AtomicString vs String?

2013-06-01 Thread Glenn Adams
, 2013 at 4:45 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 1, 2013, at 3:58 PM, Darin Adler da...@apple.com wrote: On May 31, 2013, at 8:01 PM, Glenn Adams gl...@skynav.com wrote: One thing that always threw me was the term Atomic in the class name. I wonder if the term InternedString

Re: [webkit-dev] When should I use AtomicString vs String?

2013-06-01 Thread Glenn Adams
On Sat, Jun 1, 2013 at 9:56 PM, Darin Adler da...@apple.com wrote: On Jun 1, 2013, at 8:54 PM, Glenn Adams gl...@skynav.com wrote: You guys obviously never wrote any Lisp code. Lets not play this game. When I met Maciej he was the maintainer of one of the most popular Scheme

Re: [webkit-dev] When should I use AtomicString vs String?

2013-05-31 Thread Glenn Adams
On Fri, May 31, 2013 at 6:14 PM, Rafael Brandao rafael.l...@openbossa.orgwrote: This thread contains really useful information, so I've created a new topic on https://trac.webkit.org/wiki/EfficientStrings and pointed to here. One thing that always threw me was the term Atomic in the class

Re: [webkit-dev] Vertical Selections in Textareas

2013-05-16 Thread Glenn Adams
On Thu, May 16, 2013 at 12:06 PM, Darin Adler da...@apple.com wrote: I think it’s a neat idea. It’s a big, challenging project. The first step is probably to add the notion of a selection that is not a single DOM range. There are many, many functions that currently have that assumption. I

[webkit-dev] obtaining webkit.org address?

2013-04-28 Thread Glenn Adams
How does a committer/reviewer obtain a webkit.org address? I notice that the majority of existing committers and reviewers have either a webkit.orgor a chromium.org address listed in contributors.json. I think it an important part of being part of the WK community to be able to identify oneself as

Re: [webkit-dev] obtaining webkit.org address?

2013-04-28 Thread Glenn Adams
, and credential to write-access SVN. On Sunday, April 28, 2013, Glenn Adams wrote: How does a committer/reviewer obtain a webkit.org address? I notice that the majority of existing committers and reviewers have either a webkit.org or a chromium.org address listed in contributors.json. I think

Re: [webkit-dev] obtaining webkit.org address?

2013-04-28 Thread Glenn Adams
On Sun, Apr 28, 2013 at 8:46 PM, Glenn Adams gl...@skynav.com wrote: And if one prefers to use a webkit.org address, like you are doing? A little follow-up: when I got my SVN account and credentials earlier this year as a committer, I expected to be given or at least asked if I wanted

Re: [webkit-dev] Implement ruby-overhang

2013-04-17 Thread Glenn Adams
On Wed, Apr 17, 2013 at 1:26 AM, Yuki Sekiguchi yuki.sekigu...@access-company.com wrote: Hi, I'd like to add support for ruby-overhang. The spec for this feature can be found here: http://www.w3.org/TR/css3-ruby/#rubyover I'm working it at this bug

Re: [webkit-dev] Sunsetting committership and reviewership

2013-04-10 Thread Glenn Adams
On Wed, Apr 10, 2013 at 1:46 AM, Eric Seidel e...@webkit.org wrote: If we create an emeritus class in committers.py, we also have a whole bunch of old (long-webkit-retired) Apple committers/reviewers (ken, vicki, cblu, gramps, etc.) which should go there. :) Then the tools (including

[webkit-dev] Tools/BuildSlaveSupport/.../TestFailures/run-unittests.html

2013-04-09 Thread Glenn Adams
Does any bot (or person) run this? Regularly? I just noticed today it reports a number of failures (using r148074). Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_3) AppleWebKit/537.37+ (KHTML, like Gecko) Version/6.0.3 Safari/536.28.10 Tests completed in 705 milliseconds. 513 tests of 545 passed,

Re: [webkit-dev] Tools/BuildSlaveSupport/.../TestFailures/run-unittests.html

2013-04-09 Thread Glenn Adams
On Tue, Apr 9, 2013 at 11:15 PM, Dirk Pranke dpra...@chromium.org wrote: TestFailures, as I understand it, provides a summarize view of current tree failures clustered by the changes that might have caused the failures, kind of like garden-o-matic's initial page. All the garden-o-matic UI is

Re: [webkit-dev] Unmaintained feature list

2013-04-08 Thread Glenn Adams
On Mon, Apr 8, 2013 at 4:28 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 7, 2013, at 6:35 PM, Benjamin Poulain benja...@webkit.org wrote: On Sun, Apr 7, 2013 at 6:23 PM, Dirk Schulze k...@webkit.org wrote: The recent request from Andreas to remove CSS Variables leads to the question

Re: [webkit-dev] Unmaintained feature list

2013-04-08 Thread Glenn Adams
On Mon, Apr 8, 2013 at 5:01 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Apr 8, 2013 at 3:59 PM, Glenn Adams gl...@skynav.com wrote: On Mon, Apr 8, 2013 at 4:28 PM, Maciej Stachowiak m...@apple.com wrote: On Apr 7, 2013, at 6:35 PM, Benjamin Poulain benja...@webkit.org wrote: On Sun

Re: [webkit-dev] Sunsetting committership and reviewership

2013-04-07 Thread Glenn Adams
On Sun, Apr 7, 2013 at 7:27 PM, Benjamin Poulain benja...@webkit.orgwrote: I don't really see the big deal with revoking reviewer rights. If you come back to the project, make a few good patches and show a good understanding of the code base, you just get the rights back. This seems rather

Re: [webkit-dev] Cleaning House

2013-04-04 Thread Glenn Adams
On Thu, Apr 4, 2013 at 11:03 AM, Brent Fulgham bfulg...@gmail.com wrote: I'd also suggest purging the chromium layout tests ASAP so we can enjoy the much-reduced archive sync costs. We really need to get the Mac or Win EWS performing tests by default and reliably before doing this. At

Re: [webkit-dev] Cleaning House

2013-04-04 Thread Glenn Adams
On Thu, Apr 4, 2013 at 1:44 PM, Filip Pizlo fpi...@apple.com wrote: Sent from my PDP-11 11/20? 11/40? RSX-11? RT-11? Love the split I/D memory on 11/70s. ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Cleaning House

2013-04-04 Thread Glenn Adams
On Thu, Apr 4, 2013 at 1:50 PM, Geoffrey Garen gga...@apple.com wrote: To clarify: (1) The EWS bots are still running. (2) The mac and mac-wk2 EWS bots are running tests, and passing. (3) The cr-linux bots are running tests, and failing. If we're OK with item (3), we can go ahead with

[webkit-dev] Upcoming Contributors Meeting

2013-04-04 Thread Glenn Adams
Any update on the upcoming contributors meeting [1]? Logistics? Agenda? [1] http://trac.webkit.org/wiki/May%202013%20Meeting ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Feature announcement: Web VHS API

2013-04-01 Thread Glenn Adams
On Mon, Apr 1, 2013 at 10:39 AM, Michael Saboff msab...@apple.com wrote: I had heard that there is some disagreement among browser vendors as to video formats being supported with the Web VHS API. Safari will only support the Not Too Saturated Colors (NTSC) format to improve clarity, while

Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-27 Thread Glenn Adams
On Fri, Mar 22, 2013 at 3:24 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi all, I've made a change to NRWT in http://trac.webkit.org/changeset/146657 so that it always generate pixel results in retries even when pixel tests are disabled by default (on all but Chromium ports). We now enable

Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-27 Thread Glenn Adams
On Wed, Mar 27, 2013 at 9:16 AM, Glenn Adams gl...@skynav.com wrote: On Fri, Mar 22, 2013 at 3:24 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi all, I've made a change to NRWT in http://trac.webkit.org/changeset/146657 so that it always generate pixel results in retries even when pixel tests

Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-27 Thread Glenn Adams
On Wed, Mar 27, 2013 at 11:46 AM, Glenn Adams gl...@skynav.com wrote: On Wed, Mar 27, 2013 at 9:16 AM, Glenn Adams gl...@skynav.com wrote: On Fri, Mar 22, 2013 at 3:24 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi all, I've made a change to NRWT in http://trac.webkit.org/changeset/146657so

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-22 Thread Glenn Adams
On Fri, Mar 22, 2013 at 3:07 PM, Ryosuke Niwa rn...@webkit.org wrote: Landed it in http://trac.webkit.org/changeset/146657. Once EWS bots catch up, we can start grabbing both text and pixel results off of Chromium and Mac EWS bots. Thanks, this will be very useful!

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa rn...@webkit.org wrote: Lately, I've encountering changesets that only add lines to TestExpectations and then never baseline tests for any platform. This (never rebaseline tests for any platform in that changeset) may not be possible depending on

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 12:49 PM, Ryosuke Niwa rn...@webkit.org wrote: Lately, I've encountering changesets that only add lines to TestExpectations

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 5:40 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:36 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:10 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:02 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my platform, so I have to manage with it. I do have a Retina MBP too but I don't use it to work on the rendering engine precisely because

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-21 Thread Glenn Adams
On Thu, Mar 21, 2013 at 6:11 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 5:10 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Mar 21, 2013 at 5:55 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Mar 21, 2013 at 4:50 PM, Glenn Adams gl...@skynav.com wrote: That's my

Re: [webkit-dev] Best practices for landing new/changed layout test expectations?

2013-02-25 Thread Glenn Adams
On Mon, Feb 25, 2013 at 3:53 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Feb 25, 2013 at 2:48 PM, Dirk Pranke dpra...@google.com wrote: On Mon, Feb 25, 2013 at 2:05 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Feb 25, 2013 at 1:39 PM, Dirk Pranke dpra...@google.com wrote: Are you

Re: [webkit-dev] Best practices for landing new/changed layout test expectations?

2013-02-25 Thread Glenn Adams
On Mon, Feb 25, 2013 at 5:27 PM, Ryosuke Niwa rn...@webkit.org wrote: Quite frankly, I don't want it to be my (or anyone but patch author's) job to take care of all these stale entries people add. I agree, but I think that sloppy follow-up doesn't mean the approach is necessarily bad. We have

Re: [webkit-dev] Best practices for landing new/changed layout test expectations?

2013-02-25 Thread Glenn Adams
On Mon, Feb 25, 2013 at 6:17 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Feb 25, 2013 at 5:06 PM, Glenn Adams gl...@skynav.com wrote: On Mon, Feb 25, 2013 at 5:27 PM, Ryosuke Niwa rn...@webkit.org wrote: Quite frankly, I don't want it to be my (or anyone but patch author's) job

Re: [webkit-dev] WebKit Perf Monitor (perf.webkit.org) has been launched

2013-02-24 Thread Glenn Adams
On Mon, Feb 25, 2013 at 12:24 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi all, We've replaced webkit-perf.appspot.com by perf.webkit.org. webkit-perf.appspot.com will be phased-out in the coming weeks. I'm going to check in the source code of perf.webkit.org into WebKit repository in

Re: [webkit-dev] Should LChar really being unsigned char? (was Re: SerializedScriptValue: signed vs unsigned char)

2013-02-10 Thread Glenn Adams
On Sun, Feb 10, 2013 at 10:03 AM, Balazs Kelemen kbal...@webkit.org wrote: On 02/07/2013 01:48 AM, Maciej Stachowiak wrote: I think we should continue to use uint8_t instead of char as the primary way to represent a raw byte in WebKit. First, it's good to distinguish raw data from C

Re: [webkit-dev] Should LChar really being unsigned char? (was Re: SerializedScriptValue: signed vs unsigned char)

2013-02-10 Thread Glenn Adams
On Sun, Feb 10, 2013 at 11:38 AM, Darin Adler da...@apple.com wrote: Short answer, yes. On Feb 10, 2013, at 9:14 AM, Glenn Adams gl...@skynav.com wrote: Because LChar is often (always?) UTF-8 encoded, the individual encoding units of which are 0x00 through 0xFF. Close. LChar is always

Re: [webkit-dev] SerializedScriptValue: signed vs unsigned char

2013-02-07 Thread Glenn Adams
On Wed, Feb 6, 2013 at 5:35 PM, Alec Flett alecfl...@chromium.org wrote: Personally outside of WebKit I tend to see more char* as the common denominator for raw bytes. I've been coding in C since around 1972, and I admit that in the early days, char was used as a synonym for byte, however,

Re: [webkit-dev] SerializedScriptValue: signed vs unsigned char

2013-02-04 Thread Glenn Adams
On Mon, Feb 4, 2013 at 4:51 PM, Alec Flett alecfl...@chromium.org wrote: At the moment, SerializedScriptValue uses Vectoruint8_t (aka Vectorunsigned char) for both it's API (createFromWireBytes, toWireBytes) as well as its internal representation. (for both v8 and jsc implementations) The

Re: [webkit-dev] WebIDL implementation plans (was: Re: Multiple inheritance in the DOM)

2013-01-25 Thread Glenn Adams
On Fri, Jan 25, 2013 at 10:14 AM, Adam Barth aba...@webkit.org wrote: There's no experiment that you can run using web content to detect whether we implement WebIDL. All you can detect is whether we implement particular specifications that use WebIDL. We can just simply not implement the

Re: [webkit-dev] Feature announcement: HTMLTemplateElement

2012-11-29 Thread Glenn Adams
On Wed, Nov 28, 2012 at 1:31 PM, Rafael Weinstein rafa...@chromium.orgwrote: Hello, WebKit! I plan to start landing the implementation of the HTMLTemplateElement (behind a compile flag). The spec is here: http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html A

Re: [webkit-dev] Feature announcement: HTMLTemplateElement

2012-11-29 Thread Glenn Adams
On Thu, Nov 29, 2012 at 10:00 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Nov 29, 2012 at 8:55 PM, Glenn Adams gl...@skynav.com wrote: On Wed, Nov 28, 2012 at 1:31 PM, Rafael Weinstein rafa...@chromium.orgwrote: Hello, WebKit! I plan to start landing the implementation

Re: [webkit-dev] Feature announcement: HTMLTemplateElement

2012-11-29 Thread Glenn Adams
On Thu, Nov 29, 2012 at 11:05 PM, Rafael Weinstein rafa...@chromium.orgwrote: On Thu, Nov 29, 2012 at 9:55 PM, Adam Barth aba...@webkit.org wrote: On Thu, Nov 29, 2012 at 9:23 PM, Glenn Adams gl...@skynav.com wrote: On Thu, Nov 29, 2012 at 10:00 PM, Ryosuke Niwa rn...@webkit.org wrote

[webkit-dev] generic test expectations?

2012-11-13 Thread Glenn Adams
Just checking, but I don't see a way to add test expectations that apply generically (to all ports). It would be nice to have something like LayoutTests/platform/generic/TestExpectations to which one could add new tests that are known to fail everywhere (e.g., because the code that implements a

Re: [webkit-dev] generic test expectations?

2012-11-13 Thread Glenn Adams
at 10:49 AM, Glenn Adams gl...@skynav.com wrote: Just checking, but I don't see a way to add test expectations that apply generically (to all ports). It would be nice to have something like LayoutTests/platform/generic/TestExpectations to which one could add new tests that are known to fail

Re: [webkit-dev] generic test expectations?

2012-11-13 Thread Glenn Adams
On Tue, Nov 13, 2012 at 12:02 PM, Glenn Adams gl...@skynav.com wrote: implements the expected behavior (on some but not all ports), and the comment further follow-on s/the comment further/then commit further/ ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] generic test expectations?

2012-11-13 Thread Glenn Adams
On Tue, Nov 13, 2012 at 12:09 PM, Dirk Pranke dpra...@chromium.org wrote: We don't currently support port-specific reftests (or at least, not very well), and we certainly should be trying to minimize where they occur. Hmm, I actually used port specific reftest expectation files in a recent

Re: [webkit-dev] HbbTV support within Webkit

2012-10-10 Thread Glenn Adams
On Wed, Oct 10, 2012 at 3:50 PM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: Hi, I still don't get it. CE-HTML is a closed standard and not something we ever want in WebKit as we are pushing HTML5/Living Standard. Just to provide some additional input. CE-HMTL, more

[webkit-dev] Remove support for -webkit-auto as a specifiable value for CSS text-align property?

2012-10-02 Thread Glenn Adams
Now that the initial value returned for text-align is 'start' instead of '-webkit-auto' (see [1]), would there be any objection to removing support for the ability to specify -webkit-auto as a legacy synonym for 'start'? If not, I will proceed with a new bug I just filed [2] to do this. Otherwise,

Re: [webkit-dev] Remove support for -webkit-auto as a specifiable value for CSS text-align property?

2012-10-02 Thread Glenn Adams
. Also, I would think that, if this possible difference is eliminated, then we should be able to at least remove the use of -webkit-auto in html.css, etc. On Tue, Oct 2, 2012 at 1:44 AM, Glenn Adams gl...@skynav.com wrote: Now that the initial value returned for text-align is 'start' instead

Re: [webkit-dev] Remove support for -webkit-auto as a specifiable value for CSS text-align property?

2012-10-02 Thread Glenn Adams
On Wed, Oct 3, 2012 at 1:20 AM, Maciej Stachowiak m...@apple.com wrote: Our recent practice and policy has been that the person asking for removal has to present information to show that it's likely safe.For example by gathering usage statistics. See:

[webkit-dev] WKCreateCTLineWithUniCharProvider

2012-09-26 Thread Glenn Adams
Where can I find the source for WKCreateCTLineWithUniCharProvider? I'm working on a bug [1] in which I will need to at least understand and perhaps modify its behavior. Basically, to fix this bug, I need to pass character context from adjacent text runs (or adjacent inline text nodes) that will

Re: [webkit-dev] Updated https://trac.webkit.org/wiki/DeprecatingFeatures (was Re: Removing the prefix from webkitPostMessage)

2012-09-21 Thread Glenn Adams
On Sat, Sep 22, 2012 at 7:30 AM, Adam Barth aba...@webkit.org wrote: On Wed, Sep 12, 2012 at 7:13 PM, Adam Barth aba...@webkit.org wrote: On Wed, Sep 12, 2012 at 6:40 PM, Maciej Stachowiak m...@apple.com wrote: That seems like a reasonable approach to gathering usage data indirectly, so

[webkit-dev] adding support for css3 line-break property to -webkit-line-break

2012-09-05 Thread Glenn Adams
Bug 89235 [1] notes lack of support for the CSS3 Text module's line-break property. I have prepared a patch to add support for the values expressed by this property to the existing -webkit-line-break property, as a preliminary step before the CSSWG agrees to unprefixed usage of CSS3 Text

[webkit-dev] testing strategy? - CJK line breaking tests

2012-09-04 Thread Glenn Adams
What is the recommended approach to test cases when one needs to use a CJK font that covers the test data? I could use DRT text results as expected but given lack of common font across platforms, that doesn't seem to be effective. From my somewhat limited (i.e., newbie) exposure to WK, I gather

Re: [webkit-dev] testing strategy? - CJK line breaking tests

2012-09-04 Thread Glenn Adams
Certainly it is not be the intent to expose such props to web content in general. But I could fathom exposing this to WK test content (without necessarily being dependent on DRT framework). On Tuesday, September 4, 2012, Glenn Adams wrote: What is the recommended approach to test cases when one

Re: [webkit-dev] testing strategy? - CJK line breaking tests

2012-09-04 Thread Glenn Adams
On Tue, Sep 4, 2012 at 11:26 PM, Dan Bernstein m...@apple.com wrote: On Sep 4, 2012, at 5:50 AM, Glenn Adams gl...@skynav.com wrote: Alternatively, you can compute the with of each character with script (without adding any new feature to WebKit). Unfortunately, that won't work since I

Re: [webkit-dev] Passing null or undefined object as input url for XMLHttpRequest open()

2012-09-04 Thread Glenn Adams
On Wed, Sep 5, 2012 at 12:10 AM, Joshua Bell jsb...@chromium.org wrote: On Tue, Sep 4, 2012 at 8:32 AM, Alexey Proskuryakov a...@webkit.org wrote: 04.09.2012, в 07:43, Pozdnyakov, Mikhail написал(а): req = new XMLHttpRequest(); req.open(“GET”, null); ** ** the implementation

[webkit-dev] RenderStyleConstants.h - enum naming conventions?

2012-08-24 Thread Glenn Adams
I'm implementing a patch for [1], namely to support the CSS3 line-break property. [1] https://bugs.webkit.org/show_bug.cgi?id=89235 There is an older -{khtml,webkit}-line-break enum EKHTMLLineBreak defined in RenderStyleConstants.h. I see that some enums use a 'E' prefix, while others do not,

Re: [webkit-dev] RenderStyleConstants.h - enum naming conventions?

2012-08-24 Thread Glenn Adams
On Fri, Aug 24, 2012 at 3:06 PM, Glenn Adams gl...@skynav.com wrote: [or if there is a name conflict on LineBreak, then will use LineBreakType] (whether the suffice 'Type' is included also seems somewhat irregular) s/suffice/suffix/ ___ webkit-dev

[webkit-dev] EditBugs permission request

2012-08-21 Thread Glenn Adams
Could I be enabled for EditBugs permission? I'm starting to submit patches and actively work bugs, e.g., https://bugs.webkit.org/show_bug.cgi?id=94633 https://bugs.webkit.org/show_bug.cgi?id=6148 Thanks! ___ webkit-dev mailing list

Re: [webkit-dev] EditBugs permission request

2012-08-21 Thread Glenn Adams
On Wed, Aug 22, 2012 at 6:42 AM, Adam Barth aba...@webkit.org wrote: On Tue, Aug 21, 2012 at 2:41 PM, Glenn Adams gl...@skynav.com wrote: Could I be enabled for EditBugs permission? I'm starting to submit patches and actively work bugs, e.g., Done. In the future, folks should feel free

Re: [webkit-dev] Disjointed selection ranges

2012-08-14 Thread Glenn Adams
On Tue, Aug 14, 2012 at 12:25 PM, Ryosuke Niwa rn...@webkit.org wrote: On Tue, Aug 14, 2012 at 11:51 AM, Shezan Baig shezbaig...@gmail.comwrote: We are using embedded WebKit in our application, and we need to be able to use disjointed selection ranges for table editing. I was wondering

Re: [webkit-dev] Disjointed selection ranges

2012-08-14 Thread Glenn Adams
On Tue, Aug 14, 2012 at 1:43 PM, Ryosuke Niwa rn...@webkit.org wrote: On Tue, Aug 14, 2012 at 1:14 PM, Glenn Adams gl...@skynav.com wrote: On Tue, Aug 14, 2012 at 12:25 PM, Ryosuke Niwa rn...@webkit.org wrote: On Tue, Aug 14, 2012 at 11:51 AM, Shezan Baig shezbaig...@gmail.comwrote: We

Re: [webkit-dev] Disjointed selection ranges

2012-08-14 Thread Glenn Adams
On Tue, Aug 14, 2012 at 3:36 PM, Ryosuke Niwa rn...@webkit.org wrote: I have to admit there are some valid use cases for supporting multi-range selection but the complexity it adds to our codebase is unjustifiable. Gecko has tried this for a decade but they're now trying to get rid of it. See

[webkit-dev] is platform/mac baselined for ML (mountain lion)?

2012-07-31 Thread Glenn Adams
NRWT is producing a large number of apparent regressions on ML. A build/test run I performed last night shows 294 unexpected fails on WK1 tests [1] and 150 unexpected fails on WK2 tests [2]. My question is whether platform/mac has been rebaselined for ML or not? If not, then are there plans to do

[webkit-dev] mac-mountainlion port?

2012-07-28 Thread Glenn Adams
anyone planning to add a mac-mountainlion port/baseline soon? at present, NRWT defaults to mac-future on 10.8 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] build time - lion vs mountain lion - 200% slowdown

2012-07-27 Thread Glenn Adams
Just upgraded from Lion to Mountain Lion (and XCode 4.4). Clean build time went from 29mins to 1h 29mins on a new 2.6GHz 16GB MacBook Pro 15 Retina. You might want to hold off on an upgrade unless you enjoy waiting for builds. ___ webkit-dev mailing list

Re: [webkit-dev] build time - lion vs mountain lion - 200% slowdown

2012-07-27 Thread Glenn Adams
On Fri, Jul 27, 2012 at 2:40 PM, Mark Rowe mr...@apple.com wrote: On 2012-07-27, at 13:33, Glenn Adams gl...@skynav.com wrote: Just upgraded from Lion to Mountain Lion (and XCode 4.4). Clean build time went from 29mins to 1h 29mins on a new 2.6GHz 16GB MacBook Pro 15 Retina. You might want