Re: [webkit-dev] Coding style change proposal: Avoid using Objective C autorelease when possible

+1 There’s quite a few of those, I’ve removed some when I encountered them, some of them not so trivial replacement due to local scoping. Jean-Yves Sent from my iPhone > On 5 Apr 2025, at 11:45 am, Chris Dumez via webkit-dev > wrote: > > Hi, > > I would like to propose updating the WebKi

Re: [webkit-dev] std::optional: * or value()?

I personally try to always use std::optional the same as T* To get access to a method of the inner object:  operator-> So to get the content : 

Re: [webkit-dev] Set once pointer types and static analysis

it >> type or some annotation instead of having to look at the whole code is an >> improvement. >> >> Le mar. 29 oct. 2024 à 03:10, Jean-Yves Avenard via webkit-dev >> a écrit : >>> Hi >>> >>> It’s a very strong +1 for me ; I find the usage

[webkit-dev] Gerald Squelart is now a reviewer !

G’day ! I'm excited to announce that Gerald Squelart is now a WebKit reviewer. 🥳 Gerald joined the WebKit Graphic team a little while back and lately has been working on increasing our HDR support. Gerald has an almost infinite depth of C++ knowledge. Don’t hesitate to throw him questions abou

Re: [webkit-dev] Set once pointer types and static analysis

Hi It’s a very strong +1 for me ; I find the usage of foo->protectedBar()->method() or Ref { foo->bar() }->method() particularly unsightly (and points more to the inability of the static analyser to deal with some use case than the code being inherently unsafe) Having a way to reduce the unsigh

Re: [webkit-dev] Naming scheme for fooIfExists/ensureFoo - Round 2

> > On 3 Oct 2024, at 1:48 pm, Ryosuke Niwa via webkit-dev > wrote: > > StyleResolver* styleResolverIfExists(); > StyleResolver& styleResolver(); I myself prefer this one, it’s more concise in its most common use. It’s also the style I’ve personally seen the most around the code I’m involved

Re: [webkit-dev] Initializing member variables

> On 20 Sep 2024, at 7:55 AM, Ryosuke Niwa via webkit-dev > wrote: > > > Should we do: > > struct Foo { > int bar = 0; > } > > Or > > struct Foo { > int bar { 0 }; > } > > We do both at the moment. > > - R. Niwa I think `int bar = 0` reads better. I only ever see (and use) { }

Re: [webkit-dev] Proposal: Dropping MSVC support and use clang-cl exclusively on Windows

Hi > On 2 May 2024, at 10:07 am, Herb Sutter via webkit-dev > wrote: > > > We’ve had full C++20 including concepts for a couple of years so I wasn’t > sure what problem you were running into… are you encountering bugs in those > features? or you can’t turn on /std:c++20 for some reason? or

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

Hi > On 29 Nov 2023, at 9:44 am, Chris Dumez via webkit-dev > wrote: > > FYI, our official documentation on WebKit.org says: > ``` > Making unofficial reviews before you become a reviewer is encouraged. This is > an excellent way to show your skills. Note that you should n

Re: [webkit-dev] Unsigned to avoid negative values

I could have sworn reading a few years ago a white paper discussing signed vs unsigned discussed with Blink coding style showing that using unsigned had a performance impact. Of course, now I can’t find reference to it. But I clearly recall recommendations like you mentioned. Sent from my

Re: [webkit-dev] New status field required for feature flags

Hi. What status should be used for: "Enabled by default on most platforms except those we’ve decided not to support or if a local system dependency can’t be met but feature is still ready for general use, but UI to toggle the feature remains to support debugging, A/B testing." That defaultValu

Re: [webkit-dev] Running the GTK port on macOS with Docker

Hi How is that effort going ? Having a way to build the GTK port today would have saved me a lot of time. Instead I had to keep uploading patches to bugzilla to find compilation errors. Jean-Yves > On 15 Oct 2021, at 10:33 pm, Philippe Normand wrote: > > On Fri, 2021-10-15 at 10:04 +1100, Jea

Re: [webkit-dev] Running the GTK port on macOS with Docker

Hi. Personally, I would love a way to quickly build for GTK on my Mac, as for now I had to rely on pushing to the EWS, wait for compilation errors and fix them as I went. So something running in docker using my local tree would be ideal. Jean-Yves > On 15 Oct 2021, at 1:21 am, Philippe Norman