[webkit-dev] Use dashboard region to support dragging frameless window in chromium extensions

2012-06-21 Thread Jian Li
Hi, In Chromium port, we're working on supporting frameless windows for extensions, that allow the web contents to have complete control of the window. Frameless windows do not have the standard frame and the web contents cover the whole window. Thus we need to provide a way to let the web content

Re: [webkit-dev] Separating ENABLE(NOTIFICATIONS) and ENABLE(LEGACY_NOTIFICATIONS)

2012-03-13 Thread Jian Li
So yes, it includes HTML notifications and old syntax, and will > not remove anything that already exists. > > Jon > > On Mar 13, 2012, at 1:25 PM, Jian Li wrote: > > Jon, could you please provide what are going to be included in > LEGACY_NOTIFICATIONS? Does LEGACY_N

Re: [webkit-dev] Separating ENABLE(NOTIFICATIONS) and ENABLE(LEGACY_NOTIFICATIONS)

2012-03-13 Thread Jian Li
Jon, could you please provide what are going to be included in LEGACY_NOTIFICATIONS? Does LEGACY_NOTIFICATION only includes HTML notification and old syntax we're considering to deprecate? Jian On Mon, Mar 12, 2012 at 7:11 PM, Adam Barth wrote: > That sounds like a good approach. Chromium wil

Re: [webkit-dev] Removing obsolete File attributes

2012-02-24 Thread Jian Li
Can we introduce some sort of "Obsolete" IDL attribute so that it will automatically produce console warning messages for those attributes and could even trigger metric gathering for those platforms that have interest? It seems that this addition could be useful in deprecating some other attributes

Re: [webkit-dev] Web Notifications API

2012-02-15 Thread Jian Li
On Wed, Feb 15, 2012 at 9:46 AM, Jon Lee wrote: > On Feb 13, 2012, at 5:51 PM, Andrew Wilson wrote: > > I don't have an answer for you here, as the internet is vast :) Among > google properties, Gmail and Google Calendar currently use it. I'm not > aware of any other google property that uses it

[webkit-dev] Propose adding button support to text based notifications (Was: Removing HTML notifications from WebKit)

2012-02-14 Thread Jian Li
One of the reasons for using html notifications is to allow direct interaction with the notifications. Here're some scenarios from our customers that want to use html notifications purely for this purpose: 1) In calendar notifications, the user might want to snooze the reminder for some time. 2) I

Re: [webkit-dev] Web Notifications API

2012-02-14 Thread Jian Li
Both GMail and Google Calendar are using text based notification, not html notification. What kind of notifications do IRCCloud, New York Timers "skimmer" view, and TweetDeck use, text based or html? Are notifications trigger from the web site or Chrome App extension? On Mon, Feb 13, 2012 at 6:0

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-26 Thread Jian Li
r 25, 2011 at 4:43 PM, Jian Li wrote: > Please see inline for the reply from the spec author Arun about your > questions. > > Arun has updated Blob.slice in the File API spec to explicitly illustrate > the case for optional end parameter. > > If the optional end parameter

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-25 Thread Jian Li
Please see inline for the reply from the spec author Arun about your questions. Arun has updated Blob.slice in the File API spec to explicitly illustrate the case for optional end parameter. If the optional end parameter is not used as a parameter when making this call, let relativeEnd be size.

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-22 Thread Jian Li
I will pass your good arguments to the spec author. Personally I am not in strong favor of mimicking Array.slice. I just found the problems we have during implementation and seek the solution. On Fri, Apr 22, 2011 at 3:00 PM, Geoffrey Garen wrote: > I would suggest updating the specification fo

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-22 Thread Jian Li
sted change might not be preferred since we're trying to mimic the behavior of Blob.slice to Array.slice and Array.slice does allow passing undefined and treat it as omitting the value. > > -Ken > > [1] http://www.khronos.org/registry/typedarray/specs/latest/#7 > > On Fri, Apr 22,

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-22 Thread Jian Li
s[1]); > return impl->foo(arg1, arg2); > > > This would allow the C++ impl to use overloading to resolve things > correctly. > > --Oliver > > On Apr 21, 2011, at 10:16 PM, Jian Li wrote: > > One other way is to write custom binding code to handle this > case specially. &

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-21 Thread Jian Li
One other way is to write custom binding code to handle this case specially. On Thu, Apr 21, 2011 at 10:07 PM, Maciej Stachowiak wrote: > > On Apr 21, 2011, at 6:29 PM, Jian Li wrote: > > I've pinged the spec author to make it clear in the spec. What is meant in > the sp

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-21 Thread Jian Li
> On Apr 21, 2011, at 12:14 AM, Jian Li wrote: > > > The current File API spec says that: > > If the end parameter is not provided (undefined), let relativeEnd be > size. > > That seems like loose wording. Parameter not provided and parameter > provided with a valu

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-21 Thread Jian Li
r 21, 2011 at 12:14 AM, Jian Li wrote: > The current File API spec says that: > If the end parameter is not provided (undefined), let relativeEnd be > size. > This seems to indicate that passing undefined as end parameter is same as > omitting it. Per the latest discussion on pub

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-21 Thread Jian Li
start, undefined). On Wed, Apr 20, 2011 at 11:17 PM, Cameron McCormack wrote: > Jian Li: > > > I am referring to Blob.slice(start, end) that mimics Array.slice. Where > in > > > WebIDL has this behavior defined? Sorry I can't find it in the spec. > > > > &g

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-20 Thread Jian Li
On Wed, Apr 20, 2011 at 9:58 PM, Ryosuke Niwa wrote: > On Wed, Apr 20, 2011 at 9:37 PM, Jian Li wrote: > >> I am referring to Blob.slice(start, end) that mimics Array.slice. Where in >> WebIDL has this behavior defined? Sorry I can't find it in the spec. >> >>

Re: [webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-20 Thread Jian Li
0. If it is true that passing undefined should be treated as 0, we do not have a bug in JSC and V8 bindings layer. However, we do have a bug in JSC and V8 internals. On Wed, Apr 20, 2011 at 7:28 PM, Maciej Stachowiak wrote: > > On Apr 20, 2011, at 6:16 PM, Jian Li wrote: > > Hi, >

[webkit-dev] Optional parameter in IDL and undefined JS value

2011-04-20 Thread Jian Li
Hi, I've just found a problem in our generated code for handling optional parameters. Suppose we define a method with optional parameter in numeric type, like the following in IDL: Foo bar(in [Optional] long long start, in [Optional] long long end); And we declare our C++ method as the f

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Jian Li
Currently it is guarded by the same guarding expression. CC Chris who implemented this feature since he knows whether it is ready all versions or not. On Thu, Dec 23, 2010 at 11:23 AM, Darin Adler wrote: > On Dec 23, 2010, at 11:21 AM, Jian Li wrote: > > > We do not add an addi

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Jian Li
Currently the definition of TypedArray is guarded by ENABLE(3D_CANVAS) || ENABLE(BLOB). It has been used in the following features: - WebGL - File API: FileReader and BlobBuilder - XMLHttpRequest: send and response We do not add an additional check expression when TypedArray is added to

Re: [webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-23 Thread Jian Li
Sounds like a good idea. I am going to add TYPED_ARRAY guard for this. Thanks, Jian On Thu, Dec 23, 2010 at 8:13 AM, Chris Marrin wrote: > > On Dec 22, 2010, at 5:34 PM, Jian Li wrote: > > > Hi, > > > > TypedArray has been used in some non-WebGL areas, like File

[webkit-dev] Plan to move TypedArray out of WebGL feature guard

2010-12-22 Thread Jian Li
Hi, TypedArray has been used in some non-WebGL areas, like File API and XHR. It would be nice if we move it out of WebGL feature guard. Any objection? Thanks, Jian ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/

Re: [webkit-dev] ArrayBuffer supprot

2010-11-14 Thread Jian Li
Kenneth, if you have not started working on adding DataView support, I can take this to make it work. How do you think? Thanks. On Wed, Oct 13, 2010 at 8:37 AM, Jian Li wrote: > > > On Tue, Oct 12, 2010 at 2:17 PM, Kenneth Russell wrote: > >> On Fri, Oct 8, 2010 at 2:46

Re: [webkit-dev] ArrayBuffer supprot

2010-10-12 Thread Jian Li
On Tue, Oct 12, 2010 at 2:17 PM, Kenneth Russell wrote: > On Fri, Oct 8, 2010 at 2:46 PM, Jian Li wrote: > > Hi, > > I am looking into hooking up ArrayBuffer support in FileReader and > > BlobBuilder. It seems that most of the typed array types (ArrayBuffer, > > Array

Re: [webkit-dev] ArrayBuffer supprot

2010-10-08 Thread Jian Li
On Fri, Oct 8, 2010 at 3:29 PM, Maciej Stachowiak wrote: > > On Oct 8, 2010, at 3:05 PM, Jian Li wrote: > > Sounds good. I will add the File API feature guard to it and still keep > those files under html/canvas. > > > Another possibility is to have an ArrayBuffer featu

Re: [webkit-dev] ArrayBuffer supprot

2010-10-08 Thread Jian Li
Sounds good. I will add the File API feature guard to it and still keep those files under html/canvas. On Fri, Oct 8, 2010 at 2:55 PM, Darin Adler wrote: > On Oct 8, 2010, at 2:46 PM, Jian Li wrote: > > > Currently all these typed array supports are put under 3D_CANVAS feature &g

[webkit-dev] ArrayBuffer supprot

2010-10-08 Thread Jian Li
Hi, I am looking into hooking up ArrayBuffer support in FileReader and BlobBuilder. It seems that most of the typed array types (ArrayBuffer, ArrayBufferView, Uint8Array, and etc) have already been implemented in WebKit, except TypedArray.get() and DataView. Currently all these typed array suppor

Re: [webkit-dev] Testing XHR

2010-09-21 Thread Jian Li
ategorizing them and sending feedback to > public-webapps working groups is more important at this point. Jian Li from > Chromium team is currently filing bugs for tests that fail in WebKit. > > - WBR, Alexey Proskuryakov > > 20.09.2010, в 22:34, Ojan Vafai написал(а): > > Fil

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Jian Li
Indeed when I implement BlobResourceHandle, I have taken the range request support into consideration and got it work. The problem is that current media element implementation does not route through ResourceHandle. However, introducing a ResourceHandle subclass does not sound like an elegant solut

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Jian Li
On Tue, Sep 14, 2010 at 6:02 PM, Adam Barth wrote: > On Tue, Sep 14, 2010 at 5:56 PM, David Levin wrote: > > On Tue, Sep 14, 2010 at 5:42 PM, Adam Barth wrote: > >> What do you think of the idea of having a re-useable BlobCore module > >> that all the ports can share? > > > > I don't think this

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Jian Li
do you think of the idea of having a re-useable BlobCore module > that all the ports can share? > > Adam > > > On Tue, Sep 14, 2010 at 5:39 PM, Jian Li wrote: > > When I implemented the blob scheme handling, I intentionally tried to > have > > some common impl

Re: [webkit-dev] Blob scheme implementation

2010-09-14 Thread Jian Li
wrapper around the platform loading logics. To fix this problem, I can move all the blob handling logic to the platform specific layer (for WebKit mac) and it is up to other individual platform to implement it when needed. Jian On Tue, Sep 14, 2010 at 5:22 PM, Adam Barth wrote: > Jian Li just

Re: [webkit-dev] Blob changes to SecurityOrigin.cpp

2010-09-03 Thread Jian Li
On Fri, Sep 3, 2010 at 4:08 PM, Adam Barth wrote: > On Fri, Sep 3, 2010 at 4:02 PM, Jian Li wrote: > > On Fri, Sep 3, 2010 at 3:43 PM, Adam Barth wrote: > >> On Fri, Sep 3, 2010 at 3:19 PM, Jian Li wrote: > >> > The reason that we skip the unique origin ch

Re: [webkit-dev] Blob changes to SecurityOrigin.cpp

2010-09-03 Thread Jian Li
On Fri, Sep 3, 2010 at 3:43 PM, Adam Barth wrote: > On Fri, Sep 3, 2010 at 3:19 PM, Jian Li wrote: > > Some parts of changes are due to the File API work I have worked on. > > On Fri, Sep 3, 2010 at 2:50 PM, Adam Barth wrote: > >> > >> I was looking at Sec

Re: [webkit-dev] Blob changes to SecurityOrigin.cpp

2010-09-03 Thread Jian Li
Some parts of changes are due to the File API work I have worked on. On Fri, Sep 3, 2010 at 2:50 PM, Adam Barth wrote: > I was looking at SecurityOrigin.cpp today and I saw a bunch of code > relating to Blob URLs. I don't really understand why this code is > correct. Would someone be willing t

[webkit-dev] Some landed patches have incorrect date in commit messages and ChangeLog

2010-08-09 Thread Jian Li
Hi, I noticed that several patches landed recently have the incorrect date put in the commit messages and ChangeLog. Please fix the incorrect information in ChangeLog. For the commit messages, anyone know if we can fix them or not? Please make sure the correct date is used when you land your patc

Re: [webkit-dev] How to handle a new protocol for Blob.url support?

2010-06-02 Thread Jian Li
6:08 PM, Darin Adler wrote: > On Jun 1, 2010, at 5:14 PM, Jian Li wrote: > > I am working on Blob.url support as defined in the latest version of File > API (http://dev.w3.org/2006/webapi/FileAPI/). The Blob.url will return a > URL that can be used to refer to the blob object in a r

[webkit-dev] How to handle a new protocol for Blob.url support?

2010-06-01 Thread Jian Li
Hi, I am working on Blob.url support as defined in the latest version of File API (http://dev.w3.org/2006/webapi/FileAPI/). The Blob.url will return a URL that can be used to refer to the blob object in a resource request, like blobdata:f81d4fae-7dec-11d0-a765-00a0c91e6bf6. The blob object can rep

Re: [webkit-dev] Broken test

2010-05-18 Thread Jian Li
I am investigating it. It seems that some test cases, like testing non-existent and empty files, are not robust enough. I am disable these test cases in this test file and going to land the fix soon. On Tue, May 18, 2010 at 10:15 AM, Adam Barth wrote: > The same test is failing on essentially al

[webkit-dev] Question regarding build flags for the features

2010-03-23 Thread Jian Li
Hi, I've introduced a build flag ENABLE(BLOB_SLICE) for the Blob.slice feature. To continue implementing other File API features, we probably need a couple more build flags, like ENABLE(FILE_URN) and ENABLE(FILE_READER). When the embedder implements the necessary support, these flags can be turned

Re: [webkit-dev] Blob.slice support

2010-03-18 Thread Jian Li
chromium platform work and check them in soon. For all other platforms, you will need to implement the file range reading support and enable the flag, if you want to make use of Blob.slice feature. Thanks, Jian On Fri, Feb 19, 2010 at 5:24 PM, Jian Li wrote: > Hi, > > I am working on B

Re: [webkit-dev] Failing tests blocking commit queue

2010-03-11 Thread Jian Li
I will mark "http/tests/local/send-sliced-dragged-file.html" as Skipped on mac-tiger since it frequently times out in a tiger machine. On Thu, Mar 11, 2010 at 2:42 PM, Kenneth Russell wrote: > Sorry to complain without going in and just fixing the issue, but it > looks like the commit queue has

Re: [webkit-dev] Question on FormData interface and implementation

2010-02-25 Thread Jian Li
ses backing the new scriptable object > as DOMFormData (similar in sprirt to DOMWindow), and leave the existing > FormData classes as they are. > > On Thu, Feb 25, 2010 at 3:31 PM, Jian Li wrote: > >> Hi, >> >> I am looking into the work to support FormData inter

[webkit-dev] Question on FormData interface and implementation

2010-02-25 Thread Jian Li
Hi, I am looking into the work to support FormData interface as defined in XMLHttpRequest Level 2 ( http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata). To support the new FormData interface, we need to add the FormData object that collides with the name that has already existed. Currently w

[webkit-dev] Blob.slice support

2010-02-19 Thread Jian Li
Hi, I am working on Blob.slice support as defined in the File API ( http://www.w3.org/TR/FileAPI/). To make it work, we need to get the network embedder layer to add the capability to send the file range. I plan to add the following fields to class FormDataElement: long long m_fileStart;

Re: [webkit-dev] The tree is on fire

2010-01-22 Thread Jian Li
Thanks dimich for fixing this debug-only test failure. The buildbot seems to be improving a lot now. Sorry for the failures caused by r53722. I have fixed all related failures on Mac and Qt. The Gtk results seem not be updated for quite some time. So I do not touch them. If there is anything else

[webkit-dev] Legacy attributes in existing File interface

2010-01-15 Thread Jian Li
Hi, I am in the process of implementing the new File API as in http://www.w3.org/TR/FileAPI/. I have a question regarding legacy methods in the existing File interface. The existing File interface defines fileName and fileSize attributes. In the new File API spec, they are called as name in File

Re: [webkit-dev] How to add a new interface for ObjC bindings?

2009-12-22 Thread Jian Li
27;t know much about those. > > Dave > > > *From:* Jian Li > *To:* webkit-dev@lists.webkit.org > *Sent:* Tue, December 22, 2009 3:05:08 PM > *Subject:* [webkit-dev] How to add a new interface for ObjC bindings? > > Hi, > > I am working on adding Blob interface ba

[webkit-dev] How to add a new interface for ObjC bindings?

2009-12-22 Thread Jian Li
Hi, I am working on adding Blob interface based on the latest File API spec. I have one question about the various kinds of bindings we need to put up for this new interface. I got JSC and V8 bindings generated and built successfully. I have some problem with ObjC bindings. What's the right proced

[webkit-dev] Support sending multiple files via XMLHttpRequest.send()

2009-09-08 Thread Jian Li
In WebKit, XMLHttpRequest.send() supports sending single file. It would be better if we can support sending multiple files, like FileList (see bug 25923 ). In addition, XMLHttpRequest.send() only sends the raw content of the file, without including the

Re: [webkit-dev] [V8] It's time for V8Proxy to come to Jesus

2009-07-04 Thread Jian Li
FYI, we've also another WorkerContextExecutionProxy that acts like V8Proxy in order to talk to V8 engine for everything needed in WorkerContext. When we do refactoring for V8Proxy, we also need to make it be able to support different execution context. On Fri, Jul 3, 2009 at 12:23 PM, Adam Barth

[webkit-dev] Any problem to use ThreadableLoader to load scripts in nested workers, instead of CachedResource?

2009-04-17 Thread Jian Li
To make script loading in nested worker work, I plan to change the use of CachedResource machinery to ThreadableLoader, as in bug 25215 ( https://bugs.webkit.org/show_bug.cgi?id=25215). Can anyone who is an expert on loading design advise if this switch has any problem or not? Thanks a lot, Jian

Re: [webkit-dev] Propose some changes to WebKit implementation of HTML5 workers in order to run them in Chrome's worker process

2009-02-05 Thread Jian Li
eportPendingActivity(bool hasPendingActivity) = 0; // Called when the worker context is destroyed. virtual void workerContextDestroyed() = 0; }; On Mon, Feb 2, 2009 at 6:10 PM, Jian Li wrote: > The current WebKit implementation of HTML5 workers is based on cross-thread > communica

[webkit-dev] Propose some changes to WebKit implementation of HTML5 workers in order to run them in Chrome's worker process

2009-02-02 Thread Jian Li
The current WebKit implementation of HTML5 workers is based on cross-thread communication in single process. To make it work for Chrome, we need to run the workers in Chrome's worker process. Hence, we propose the following changes: MessagingWorkerProxy acts as the gateway between Worker and Worke