Re: [webkit-dev] webkit-patch land behavior change

2022-04-27 Thread Manuel Rego Casasnovas via webkit-dev
On 26/04/2022 21:58, Jonathan Bedard via webkit-dev wrote: > As we move closer to transitioning away from Subversion, I’ve change > ‘webkit-patch land’ to use commit-queue instead of directly committing a > local change from a contributor’s machine >

Re: [webkit-dev] New EWS queue: Stress Test EWS

2021-04-28 Thread Manuel Rego Casasnovas via webkit-dev
Hi, The stress test EWS has some issue when dealing with testharness.js tests. Every now and then it thinks it's a different type of test and it dumps the layout tree, and it fails as the actual result has nothing to do with a layout tree dump. Actually it dumps an empty layout tree: layer at

Re: [webkit-dev] WebKit Transition to Git

2020-10-13 Thread Manuel Rego Casasnovas
On 14/10/2020 03:12, Ken Russell wrote: > On Tue, Oct 13, 2020 at 2:37 PM Konstantin Tokarev > wrote: > 1. Workflow 1 - "Squash merge" policy > > * Whole PR is considered to be a single atomic change of WebKit > source tree. If work is supposed to be

Re: [webkit-dev] Experimental and (new) Internal feature flags

2018-11-05 Thread Manuel Rego Casasnovas
On 25/09/18 01:00, Ryosuke Niwa wrote: > On Mon, Sep 24, 2018 at 1:26 AM Frédéric Wang > wrote: > > On 12/09/2018 23:48, Dean Jackson wrote: > > What about testing? > > > > > > You can turn both experimental and internal features on via >

Re: [webkit-dev] A couple more build flags to review

2018-02-20 Thread Manuel Rego Casasnovas
On 20/02/18 20:09, Michael Catanzaro wrote: > ENABLE_CSS3_TEXT looks to be support for text-align-last and > text-justify [1]. Seems to be only partically implemented in WebKit. I > guess this is the sort of thing that should probably be implemented > eventually, so probably makes sense to keep

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Manuel Rego Casasnovas
On 10/05/17 04:23, Ryosuke Niwa wrote: > Continuing the tradition of a massive rename in > https://lists.webkit.org/pipermail/webkit-dev/2012-August/021746.html, > I suggest we rename the top-level LayoutTests directory to something > more descriptive of the current state. > > Some ideas: >

Re: [webkit-dev] WebKit servers transitioning to new hardware

2017-03-21 Thread Manuel Rego Casasnovas
Hi, Dunno if it was related to this or something else but planet.webkit.org is not being updated since March 10, 2017. Thanks, Rego ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Unprefixing intrinsic size keywords (-webkit-min-content et al)

2017-03-07 Thread Manuel Rego Casasnovas
On 08/08/15 00:22, Dean Jackson wrote: > >> On 7 Aug 2015, at 2:44 AM, Christian Biesinger >> wrote: >> >> Hi all! >> >> We (blink) would like to unprefix the intrinsic sizing keywords: >> https://drafts.csswg.org/css-sizing/#width-height-keywords >> >> We support them

Re: [webkit-dev] On/Off selection gap painting during the text selection

2016-05-03 Thread Manuel Rego Casasnovas
On 03/05/16 17:12, Gyuyoung Kim wrote: > In second issue case, although it looks there is no critical issue with > new layout methods yet > I think I need to check it further. But the issues won't appear on port > which uses gaps painting. Maybe I didn't explain myself properly, but the issue

Re: [webkit-dev] On/Off selection gap painting during the text selection

2016-05-03 Thread Manuel Rego Casasnovas
Hi, On 03/05/16 15:24, Gyuyoung Kim wrote: > I upload a patch to add a preference API in order to enable/disable the > selection gap painting feature. BTW, this has been removed from Chrome too past year: https://groups.google.com/a/chromium.org/d/msg/blink-dev/6Iu5oIbAGbI/PsJlNvJPhfMJ Note

Re: [webkit-dev] About unprefixing CSS Grid Layout (implementation status summary included)

2016-05-03 Thread Manuel Rego Casasnovas
On 30/04/16 00:17, Dean Jackson wrote: > Please leave the build flag around. We probably need a bigger discussion > on this, but for now we should have both a runtime flag and a build flag > just in case a browser ships and doesn't want the feature compiled at all > (reducing binary size). Ok,

[webkit-dev] About unprefixing CSS Grid Layout (implementation status summary included)

2016-04-27 Thread Manuel Rego Casasnovas
Hi, as announced yesterday it seems that the WebKit prefixing policy has been updated [1]. Right now CSS Grid Layout implementation is prefixed in WebKit and behind a compilation flag. We'd like to ask about the possibility to unprefix it and put it behind a runtime flag (probably removing the

[webkit-dev] CSS Grid Layout Status Review (Jan 2015)

2015-01-21 Thread Manuel Rego Casasnovas
Hi, this is a new status review (last one was in August 2014 [1]) of the CSS Grid Layout [2] implementation done by Igalia. We'll summarize the work done during the past months and the plans for the future. Of course, we'll be really happy to get any kind of feedback from the community. The

Re: [webkit-dev] EFL and GTK EWS bots having issues

2014-07-11 Thread Manuel Rego Casasnovas
Hi, On 11/07/14 22:38, Joseph Pecoraro wrote: - GTK EWS bot has Unable to build without patch” with: ninja: error: build.ninja:3225: lexing error We found the problem and the EWS should be running properly again. Who would be best to look into these issues? I thought there used

Re: [webkit-dev] Enabling CSS Grid Layout runtime flag by default

2014-04-30 Thread Manuel Rego Casasnovas
On 25/04/14 23:39, Benjamin Poulain wrote: On 4/25/14, 5:21 AM, Javier Fernandez wrote: If everybody agrees, we have a patch ready to do this change: http://webkit.org/b/132189 JFYI, we've just landed this change today (r167993). Personally, I think you should remove the runtime flag, and be

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-11 Thread Manuel Rego Casasnovas
On Mon, 2014-02-10 at 13:38 -0800, Benjamin Poulain wrote: Can't we add a compile time flag instead? The chromium patch you linked is inelegant and it touches some hot paths. BTW, only with the compile flag the issue is not completely fixed. For example you can enable the compile flag but

Re: [webkit-dev] [blink-dev] Selection CSS Regions

2013-12-20 Thread Manuel Rego Casasnovas
Hi Yosi, On 20/12/13 02:37, Yoshifumi Inoue wrote: I would like to provide render tree iterator base rendered position from Render Tree for TextIterator, Selection, and others. TextIterator is the first client of its. Ok, I guess that it could be something similar to the RenderIterator that

Re: [webkit-dev] [blink-dev] Selection CSS Regions

2013-12-19 Thread Manuel Rego Casasnovas
Hi Yosi, On 19/12/13 02:17, Yoshifumi Inoue wrote: Selection for Shadow DOM tree is similar to CSS Region. Shadow DOM tree also randomizes rendering order against (shadow/non-shadow) DOM tree order. Using render tree information for selection also allows us to handle position:absolute

[webkit-dev] Selection CSS Regions

2013-12-18 Thread Manuel Rego Casasnovas
Hi, we've been working for a while in selection and CSS Regions. Current implementation is working fine from the DOM tree point of view, the retrieved content when you do a selection is right (fulfilling the editing spec [1]). However, in several use cases with CSS Regions, highlighted content

Re: [webkit-dev] [WIP][GTK] Memory leak detection

2013-05-21 Thread Manuel Rego Casasnovas
Hi Brian, On 05/20/2013 04:48 PM, Brian Holt wrote: Memory leak detection is a recurrent topic on this mailing list [1-5] but at present there exists only support for the Mac leaks tool[6]. The de facto standard for memory checking and leak detection for Unix is Valgrind and the goal of this