Re: [webkit-dev] Proposal: Dropping MSVC support and use clang-cl exclusively on Windows

2024-05-02 Thread Olmstead, Don via webkit-dev
Hey Herb, Not everyone whose embedding WebKit on Windows announces to us that they’re using it so unsure if someone is still compiling using MSVC. All the documentation we have points to clang-cl being the preferred way. The ones we know of Bun, https://bun.sh/ , and Playwright,

Re: [webkit-dev] Proposal: Dropping MSVC support and use clang-cl exclusively on Windows

2024-05-02 Thread Olmstead, Don via webkit-dev
Hi Herb If you grep around the WebKit codebase for COMPILER(MSVC) there are a number of workarounds hanging out. Some may have been fixed over time but the workaround wasn’t removed. Biggest issue was around the JIT and some other low level features the JSC folks utilize that isn’t present in

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-07 Thread Olmstead, Don via webkit-dev
I agree with everything Mark said in his reply I just wanted to add another benefit of having a non-unified build specifically to support build time optimization. > > 2) In my contributions, I don’t just want to add missing includes, I want > > to remove unnecessary ones taking full advantage

Re: [webkit-dev] Deployment of new EWS Non-Unified builder

2022-06-06 Thread Olmstead, Don via webkit-dev
If it isn’t it should be considering how many times I’ve had a cq- come from an AppleWin build that is in no way affected by my patch. From: Geoffrey Garen via webkit-dev Sent: Monday, June 6, 2022 10:40 AM To: Mark Lam Cc: Darin Adler ; webkit-dev@lists.webkit.org Subject: Re: [webkit-dev]