Re: [webkit-dev] Proposal: bundled/vendored code belongs under ThirdParty/

2024-10-06 Thread Sam Weinig via webkit-dev
d despite our best intentions, I trash my build repo for one reason or another more often than I would like). - Sam > On Oct 2, 2024, at 6:58 PM, Yusuke Suzuki wrote: > > The question I have is, what is the benefit from this policy change? > > -Yusuke > >> On Oct 1

Re: [webkit-dev] Proposal: bundled/vendored code belongs under ThirdParty/

2024-10-01 Thread Sam Weinig via webkit-dev
I think this makes a lot of sense and we should adopt this into the style guidelines. Two additional steps I am curious if we can take are: 1. Moving all, including source currently in WTF and PAL to Sources/ThirdParty. Having a single place seems more straightforward than multiple. Are there

Re: [webkit-dev] Request for position: Canvas 2D display-p3 support

2021-06-09 Thread Sam Weinig via webkit-dev
Hi Christopher, We are in favor of this proposal. - Sam > On Jun 9, 2021, at 6:39 PM, Christopher Cameron via webkit-dev > wrote: > > Hi webkit-dev, > > (and sorry for the duplicate post here, I mangled the headers on the previous > post!) > > This is a request for WebKit's position on dis

Re: [webkit-dev] Request for position: preferCurrentTab

2021-06-09 Thread Sam Weinig via webkit-dev
Hi Elad, Are there other existing uses of the term “tab” in other web exposed APIs? It feels a bit wrong to be wrong to be encoding that specific UI treatment into API. - Sam > On Jun 9, 2021, at 4:20 AM, Elad Alon via webkit-dev > wrote: > > This is a request for WebKit's position on addin

Re: [webkit-dev] Use of Swift (for bridging) in the WebKit project

2021-06-08 Thread Sam Weinig via webkit-dev
Hi Jer, I think it sounds like a reasonable rule to allow Swift for bridging purposes only, with the caveat that we should prefer Objective-C/C where it can be used. The one other place that Swift seems reasonable for WebKit is in the definition and refinement of Swift bindings to WebKit’s publ

[webkit-dev] Is anyone building with USE(DIRECT2D)?

2021-05-20 Thread Sam Weinig via webkit-dev
Hi WebKit-dev, Is anyone still using attempting to build using USE(DIRECT2D) enabled? Recently, I updated files to “keep” it working, but in some I have seen things that obviously wouldn’t compile and think it is probably unmaintained. So is anyone using it? - Sam __

Re: [webkit-dev] New EWS Non-Unified builder

2021-05-03 Thread Sam Weinig via webkit-dev
Hi, I am curious about the current state of our knowledge about the various benefits we are gaining from Unified Source. I think it is important to reevaluate it from time to time to ensure we are still getting the benefits we want (as there are some not so insignificant downsides). I know when

Re: [webkit-dev] Making WTF::StringImpl and WTF::AtomString thread-safe

2020-12-02 Thread Sam Weinig via webkit-dev
Hey Geoff and Chris, > On Dec 1, 2020, at 9:21 AM, Geoff Garen via webkit-dev > wrote: > > A few thoughts here: > > 1. It’s not just ref counting. > > To make String thread-safe, you also need to address all other data members. > That means all state in m_hashAndFlags, including the 8bit/16