Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

2019-05-07 Thread Xan Lopez
ej Stachowiak wrote: > > > > On Feb 14, 2019, at 1:37 AM, Xan Lopez wrote: > > Hi Maciej, > > the first patches had the flag indeed, so it should be easy to add it back > to the patch. Not sure what's the usual procedure, but I guess it makes > sense to enable it b

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

2019-02-14 Thread Xan Lopez
Hi Maciej, the first patches had the flag indeed, so it should be easy to add it back to the patch. Not sure what's the usual procedure, but I guess it makes sense to enable it by default in the bug so that the bots keep testing the code? Then we'll disable it before landing if that's our

Re: [webkit-dev] Crash in JSC while loading gap.com on 1.6.3

2013-04-30 Thread Xan Lopez
On Tue, Apr 30, 2013 at 9:11 AM, Allan Sandfeld Jensen k...@carewolf.comwrote: He probably refers to 1.6.3 of WebKitGTK+, the confusion comes from the fact that WebKitGTK+ calls themselves and their library 'WebKit' on Linux with no attempt of disambiguation. I doubt it. The confusion

Re: [webkit-dev] Status of Windows Port?

2013-04-05 Thread Xan Lopez
Hi, On Fri, Apr 5, 2013 at 12:19 AM, Benjamin Poulain benja...@webkit.orgwrote: I don't know exactly what is the problem with integrating Qt...but I think fixing that will be far less work than making a new WebKit2 port from scratch. WebKitGTK+ also run on Windows. But I don't know if it

Re: [webkit-dev] WebKit Wishes

2013-01-30 Thread Xan Lopez
Hi Eric, On Wed, Jan 30, 2013 at 10:28 PM, Eric Seidel e...@webkit.org wrote: I wish we didn’t have to worry about platforms we couldn’t test. It can’t be the job of the core maintainers to care about all the peripheral ports which contribute very little core code. Our code needs to be

Re: [webkit-dev] WebKit2GTK+ breakage due to removal of WKPageResourceLoadClient

2013-01-21 Thread Xan Lopez
On Mon, Jan 21, 2013 at 2:53 PM, Mario Sanchez Prada mario.pr...@samsung.com wrote: Hi, (...) If anyone could drop some light on this issue or provide some pointers to better understand the motivation of this change, I’d really appreciate that. I understand rolling r140285 might be not the

Re: [webkit-dev] Enable the [Supplemental] IDL on all build systems

2011-12-31 Thread Xan Lopez
On Sat, Dec 31, 2011 at 9:21 AM, Kentaro Hara hara...@chromium.org wrote: What is the problem? Please note that we need to make a change on _all_ build systems (no matter if the build system wishes to support the [Supplemental] IDL), because if any of the build systems does not

Re: [webkit-dev] It's time to remove the Haiku port

2011-09-25 Thread Xan Lopez
On Sun, Sep 25, 2011 at 9:34 AM, Adam Barth aba...@webkit.org wrote: As part of our effort to reduce complexity in WebKit, I believe it is now time to remove the Haiku port. Perhaps it would make sense to have a small set of simple rules written down somewhere that would justify the WebKit

Re: [webkit-dev] Git mirror out of sync?

2011-08-24 Thread Xan Lopez
On Tue, Aug 23, 2011 at 7:44 PM, William Siegrist wsiegr...@apple.com wrote: We just used git svn reset -r X and git svn fetch where X is the rev before the bad one. This does not seem to help with my particular problem. Xan ___ webkit-dev mailing

Re: [webkit-dev] Git mirror out of sync?

2011-08-23 Thread Xan Lopez
On Thu, Aug 18, 2011 at 6:21 PM, William Siegrist wsiegr...@apple.com wrote: Yes, I'm working on it. Git-svn refuses to get past r93167, I've tried a few things, nothing has worked so far. Unfortunately I have no ETA to give you. Did you ever figure how go to past that in git-svn? Pretty sure

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-07-06 Thread Xan Lopez
[Sending with the right address...] On Wed, Jul 6, 2011 at 11:10 AM, Eric Seidel e...@webkit.org wrote: Update: Leopard Release, Gtk and Qt have been successfully transitioned. What do we exactly consider successfully transitioned? The GTK+ bots were still failing, so I reverted to the old

Re: [webkit-dev] Best practices for failing a flaky tests (was Re: Switching to new-run-webkit-tests)

2011-07-06 Thread Xan Lopez
On Wed, Jul 6, 2011 at 6:29 PM, Eric Seidel e...@webkit.org wrote: NRWT uses both!  It will read in all the port's Skipped files, covert them to SKIP text_expectations, and add them to your test_expectations file.

[webkit-dev] No getters for iconURL/title/body in Notification.idl

2011-07-01 Thread Xan Lopez
Hi, we are adding all the Notification related objects to the GTK+ DOM bindings, and also adding the necessary APIs to WebKitGTK+ to interact with the UA. One thing we have noticed is that although the constructors for the Notification objects have the three data parameters mentioned in the

Re: [webkit-dev] No getters for iconURL/title/body in Notification.idl

2011-07-01 Thread Xan Lopez
On Fri, Jul 1, 2011 at 8:17 PM, John Gregg john...@google.com wrote: The data parameters are certainly needed by the UA to show the notification, but it seems like you're suggesting they need to be exposed as part of the Notification API (i.e., to web pages).  I don't see why that would be

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-06-27 Thread Xan Lopez
On Tue, Jun 28, 2011 at 1:17 AM, Eric Seidel e...@webkit.org wrote: There appear to be 6 remaining blocking issues: https://bugs.webkit.org/showdependencytree.cgi?id=34984hide_resolved=1 We would like to hear from others who have tried new-run-webkit-tests, if they have issues which they

Re: [webkit-dev] Cairo Painting Problem?

2011-06-25 Thread Xan Lopez
On Sun, Jun 26, 2011 at 4:43 AM, Brent Fulgham bfulg...@gmail.com wrote: Hi Everyone, I've recently noticed the following strange drawing behavior under the WinCairo port of WebKit.  I was hoping someone could confirm whether this is also happening under any other Cairo-based WebKit port.

Re: [webkit-dev] Criteria for becoming a core builder

2011-03-02 Thread Xan Lopez
On Wed, Mar 2, 2011 at 7:38 PM, Eric Seidel e...@webkit.org wrote: IMO the core list should be *descriptive* rather than *prescriptive*. If a bot is regularly green, it should be core. If its not, it should be non-core.  We should not remove bots we don't like, or add bots we hope to stay

Re: [webkit-dev] WebKit bindings status

2011-03-01 Thread Xan Lopez
On Tue, Mar 1, 2011 at 5:35 PM, Artem Kozlov akz...@yahoo.com wrote: Hello All,  I've got a question regarding language bindings provided by WebKit. I'm particularly interested in bindings for C++ and GObject: having checked out the latest WebKit trunk, I found that the code generators both

Re: [webkit-dev] WebKitGtk app memory leaks , please help

2010-11-03 Thread Xan Lopez
On Wed, Nov 3, 2010 at 7:52 AM, Fedor Kryukov y...@mail.ru wrote: After calling webkit_web_view_get_dom_document() and similar functions ( webkit_dom... * ) memory is not freed, what am I doing wrong? I wrote simple application which handle events ( load-started/load-finished/etc ) and make

Re: [webkit-dev] WebKitGtk app memory leaks , please help

2010-11-03 Thread Xan Lopez
in general the GTK+ ones have more features), so you'll have to be careful with that too. Xan Xan Lopez-3 wrote: On Wed, Nov 3, 2010 at 7:52 AM, Fedor Kryukov y...@mail.ru wrote: After calling webkit_web_view_get_dom_document() and similar functions ( webkit_dom... * ) memory is not freed

Re: [webkit-dev] when is expose_event fired

2010-10-21 Thread Xan Lopez
On Fri, Oct 22, 2010 at 2:10 PM, Aneesh Bhasin contact.ane...@gmail.com wrote: However, I wanted to know where and how is the webkit_web_view_expose_event function triggered internally - as I understand it could either be triggered from the windowing system if there is some movement /scrolling

Re: [webkit-dev] GTK Skiplist

2010-09-03 Thread Xan Lopez
On Fri, Sep 3, 2010 at 9:50 PM, Jeremy Orlow jor...@chromium.org wrote: Recently in a code review for IndexedDB, I was told that I should be adding every test individually to GTK's skip list.  The reason cited was this comment at the top # Also, no grouping should occur. Every test for itself.

Re: [webkit-dev] On IDL files, events and writing DOM bindings

2010-08-11 Thread Xan Lopez
On Wed, Aug 11, 2010 at 7:51 AM, Darin Adler da...@apple.com wrote: The bindings do not expose events directly, thus the IDL files don’t show the events. The IDL files only show functions and attributes on the various objects. Events are neither functions nor attributes. For the bindings I am

Re: [webkit-dev] On IDL files, events and writing DOM bindings

2010-08-11 Thread Xan Lopez
On Wed, Aug 11, 2010 at 5:56 PM, Darin Adler da...@apple.com wrote: On Aug 10, 2010, at 11:39 PM, Xan Lopez wrote: For the GObject bindings I'm actually exposing the events directly. This is a new feature, no other binding has this, and you will have to build everything yourself. There’s

Re: [webkit-dev] On IDL files, events and writing DOM bindings

2010-08-11 Thread Xan Lopez
On Wed, Aug 11, 2010 at 8:39 AM, Xan Lopez x...@gnome.org wrote: On Wed, Aug 11, 2010 at 7:51 AM, Darin Adler da...@apple.com wrote: The bindings do not expose events directly, thus the IDL files don’t show the events. The IDL files only show functions and attributes on the various objects

[webkit-dev] On IDL files, events and writing DOM bindings

2010-08-10 Thread Xan Lopez
Hi, as we all know, when writing DOM bindings on top of WebKit we are supposed to use the IDL files it ships as the source of the structure and behavior of the DOM. At first I had assumed that to figure out which events apply to each type/class it was OK to see which EventListeners were defined,

Re: [webkit-dev] On IDL files, events and writing DOM bindings

2010-08-10 Thread Xan Lopez
On Tue, Aug 10, 2010 at 8:32 PM, Adam Barth aba...@webkit.org wrote: I'm not sure I understand your question.  Every event can happen on every EventTarget. I mean that an HTMLMediaElement will naturally emit an 'ended' Event in some situations, but an HTMLImageElement won't. I see no obvious

Re: [webkit-dev] On IDL files, events and writing DOM bindings

2010-08-10 Thread Xan Lopez
On Tue, Aug 10, 2010 at 8:59 PM, Xan Lopez x...@gnome.org wrote: On Tue, Aug 10, 2010 at 8:32 PM, Adam Barth aba...@webkit.org wrote: I'm not sure I understand your question.  Every event can happen on every EventTarget. I mean that an HTMLMediaElement will naturally emit an 'ended' Event

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-08 Thread Xan Lopez
On Thu, Jul 8, 2010 at 7:54 PM, Adam Barth aba...@webkit.org wrote: 2) Currently the commit-queue only lands if it gets a 100% passing run of all the tests.  We could instead change it to land if there are no new test failures as a result of applying the patch.  This check is to avoid

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-08 Thread Xan Lopez
On Thu, Jul 8, 2010 at 8:09 PM, Adam Barth aba...@webkit.org wrote: Originally, we had the commit-queue to land only if all the core builders were green.  One recent change we made to make the commit-queue more agressive is to land when the commit-queue itself sees 100% passing tests on

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-08 Thread Xan Lopez
On Thu, Jul 8, 2010 at 11:38 PM, Jeremy Orlow jor...@chromium.org wrote: I think the point that's been made in this thread is that whatever policy the commit queue uses should be in line with whatever policies all committers should be using.  Otherwise you run into the problems Maciej noted.

Re: [webkit-dev] Frustrated at inconsiderate behavior

2010-07-08 Thread Xan Lopez
On Fri, Jul 9, 2010 at 12:30 AM, Daniel Cheng dch...@chromium.org wrote: As someone who doesn't have committer access, I like the change to the CQ. Before, I might have to wait 3 days for a patch to land since the CQ would wait for all the core builders to be green. Meanwhile, committers see

Re: [webkit-dev] GTK bots are now core builders

2010-04-19 Thread Xan Lopez
On Sun, Apr 18, 2010 at 9:17 PM, Eric Seidel e...@webkit.org wrote: http://trac.webkit.org/changeset/57795 Sheriff Bot will nag you when you break GTK. Commit Queue will block while any GTK builder is broken. build.webkit.org will show GTK in the core set. [1] The GKT bots have been green

Re: [webkit-dev] Announcing WebKit2

2010-04-09 Thread Xan Lopez
On Fri, Apr 9, 2010 at 2:47 AM, Xan Lopez x...@gnome.org wrote: I suppose I could wait until you land the patches and see by myself, but: - In the wiki you mention that one goal of the new framework is to provide a stable C-based API. Is this meant as a public API for WebKit, the same in all

Re: [webkit-dev] Announcing WebKit2

2010-04-08 Thread Xan Lopez
On Fri, Apr 9, 2010 at 1:01 AM, Anders Carlsson ander...@apple.com wrote: Hello everyone, This is a heads-up that we will shortly start landing patches for a new WebKit framework that we at Apple have been working on for a while. We currently call this new framework WebKit2. WebKit2 is

Re: [webkit-dev] Announcing WebKit2

2010-04-08 Thread Xan Lopez
On Fri, Apr 9, 2010 at 2:52 AM, Darin Adler da...@apple.com wrote: As I understand it, the goal is to have a C API that is suitable and works well cross platform for all the many platform independent operations; it is indeed analogous the one for JavaScriptCore in that respect. When you

Re: [webkit-dev] Gtk and Qt bots need love

2010-03-19 Thread Xan Lopez
On Fri, Mar 19, 2010 at 9:59 PM, Eric Seidel e...@webkit.org wrote: Gtk and Qt bots need love. Looks like Gtk needs 5 new results, and Qt needs 42. Various other tests are failing there too. Do any Qt/Gtk folks have a minute to try and green up the bots so we can start tracking regressions

Re: [webkit-dev] Yet another email about a broken tree

2010-03-17 Thread Xan Lopez
On Wed, Mar 17, 2010 at 9:02 AM, Adam Barth aba...@webkit.org wrote: Manual investigation confirms http://trac.webkit.org/changeset/56079 broke GTK Linux 32-bit Release, GTK Linux 64-bit Release, and Qt Linux Release.  Is there some reason we didn't roll out the offending patch? FWIW this

Re: [webkit-dev] The tree is on fire: a tragedy of the commons

2010-02-26 Thread Xan Lopez
On Fri, Feb 26, 2010 at 11:36 AM, Adam Barth aba...@webkit.org wrote: Not to point fingers, but we've been having trouble keeping build.webkit.org green these past few weeks.  As I write this message, every platform is broken, again.  As the project scales, polluting the build with brokenness

Re: [webkit-dev] webkit gtk stable library dependency versions?

2010-01-29 Thread Xan Lopez
On Fri, Jan 29, 2010 at 7:53 PM, Joseph Zuromski jos...@zuromski.com wrote: for the webkit gtk port on linux,  is there a site that lists the newest stable version #'s of the dependencies of webkit... specifically: gtk+, cairo, pango, icu, soup, gcrypt, gnutls, xslt, glib, atk or is it a

[webkit-dev] +R mode on #webkit IRC channel

2010-01-19 Thread Xan Lopez
Hi, I woke up this morning to find #webkit set up with mode +R (http://docs.dal.net/docs/modes.html#2.17), so basically you can't speak unless you have your nick registered on freenode. Is this a new policy or just some error or temporary measure that someone forgot to disable? If it's the latter

Re: [webkit-dev] Patch to use V8 engine with Gtk port

2009-12-12 Thread Xan Lopez
On Sun, Dec 13, 2009 at 4:19 AM, Holger Freyther ze...@selfish.org wrote: On Saturday 12 December 2009 22:42:34 Maciej Stachowiak wrote: I think questioning someone's priorities in an open source project is generally not polite, unless there is some direct relationship between different tasks.

Re: [webkit-dev] On the greeness of the GTK+ bot

2009-11-16 Thread Xan Lopez
On Mon, Nov 16, 2009 at 3:33 PM, Gustavo Noronha Silva g...@gnome.org wrote: On Mon, 2009-11-16 at 05:24 -0800, Adam Barth wrote: Eric and I are working on a bot that might help this situation. Essentially, the bot will try out patches on Qt and GTK and add a comment to the bug if the patch

Re: [webkit-dev] How to cancel a resource request

2009-10-23 Thread Xan Lopez
On Fri, Oct 23, 2009 at 5:37 PM, Jaroslav Gresula jgresula.leave-this-...@gmail.com wrote: Xan Lopez wrote: On Fri, Oct 23, 2009 at 5:05 PM, Jaroslav Gresula jgresula.leave-this-...@gmail.com wrote: Xan Lopez wrote: On Thu, Oct 22, 2009 at 11:18 AM, Jaroslav Gresula jgresula.leave

Re: [webkit-dev] Security advice for linux browsers based on WebKit

2009-08-24 Thread Xan Lopez
On Mon, Aug 24, 2009 at 8:23 PM, Serge Noiraudserge.noir...@laposte.net wrote: Hi, I'm writing a webkit application which use only local files ( gramps-project ) I use python-webkit and pywebkitgtk. This is not a browser for the user. If I understand correctly, in a near futur, my