Re: [webkit-dev] WebKit Transition to Git

2020-10-05 Thread Robert Ma
On Mon, Oct 5, 2020 at 6:22 AM Frédéric Wang wrote: > One thing to take into account is that WebKit's repository is big and > public GitHub/GitLab prevent creating large repository by default. This > means it might not be possible for contributors to actually fork > WebKit's repository on their

Re: [webkit-dev] Supporting for finding ref tests

2019-11-12 Thread Robert Ma
MANIFEST.json mostly stays out of the way / happens under the hood. It is cached as GitHub releases, and ignored by .gitignore. One of its purposes is a cache of the reftest graph. Once you run any test or explicitly run `./wpt manifest`, the manifest will be generated/updated in the root of your

Re: [webkit-dev] Supporting for finding ref tests

2019-11-08 Thread Robert Ma
WPT has recently passed an RFC trying to simplify the reftest graph (although it has not been implemented yet), which eliminates a lot of the complexities and concerns. On Fri, Nov 8, 2019 at 5:07 PM Ryosuke

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Robert Ma
Any thoughts on bytes and Unicode strings, especially the string literals in the code base? On Fri, Jul 12, 2019 at 3:38 PM Tim Horton wrote: > > > On Jul 12, 2019, at 12:18 PM, Jonathan Bedard wrote: > > Hello WebKit developers, > > Now that the Catalina developer seeds are available, it is

Re: [webkit-dev] Standard process for exporting new WPT tests?

2018-05-25 Thread Robert Ma
Current maintainer of Chromium's WPT sync chiming in: Because of the lack of atomic operations across two separate repos, some kind of transient inconsistency and race conditions are unavoidable. FWIW, when Chromium's WPT sync was originally designed, there was concern about increasing the wait

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-24 Thread Robert Ma
That said, we can of course benefit from WPT performance improvement as well. Robert ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] No coverage of pixel tests

2013-09-09 Thread Robert Hogan
to see this situation change in the near future? If not, reviewers and patch authors take note I guess! Thanks, Robert ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Commit Queue is Wedged

2013-03-27 Thread Robert Hogan
Hi there, The commit queue is stuck and 19 patches are now pending. Looks like the problem started about 8 hours ago. Thanks, Robert ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-23 Thread Robert Hogan
This will allow us to rebaseline BOTH test and image expected results PRIOR to landing patches. You're welcome. Great stuff. Thanks for doing this! A question for the Qt/gtk/efl ports: do you plan to put some testers on the EWS queue? If not, I think you should shout if you do not want

[webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Robert Hogan
On Wednesday, 20 March 2013, Ryosuke Niwa wrote: Please don't add lines to TestExpectations saying that they just need rebaselines and then leave. OK. That means I will have to pull the new results from the bots, which is fine - but in the case of the Mac port (and any other bot that does not

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Robert Hogan
On Thursday, 21 March 2013, Ryosuke Niwa wrote: I used to pull results from the bots where possible but creating inconsistency between png/text results is not good. It is unfortunate but it's much better than losing the complete test coverage. If that's the case then I'm happy to land

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-21 Thread Robert Hogan
On Thursday, 21 March 2013, Ryosuke Niwa wrote: On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan li...@roberthogan.netjavascript:_e({}, 'cvml', 'li...@roberthogan.net'); wrote: On Thursday, 21 March 2013, Ryosuke Niwa wrote: I used to pull results from the bots where possible but creating

Re: [webkit-dev] Testing feature suggestion: animation/interaction pixel-results on the fly

2013-02-08 Thread Robert Kroeger
Questions inline. On Fri, Feb 8, 2013 at 8:35 AM, noam.rosent...@nokia.com wrote: Hellos we don't currently have a solution in webkit's test infrastructure for testing animations on the fly, or in general for testing multiple image results in the same test. I have been wishing for such a

Re: [webkit-dev] Adding high resolution platform timestamp to DOM events

2012-10-25 Thread Robert Flack
me to believe that some people think we can simply modify timeStamp IDL attribute instead of adding new one. - Ryosuke On Wed, Oct 24, 2012 at 6:17 PM, Robert Flack fla...@chromium.org wrote: Hi webkit-dev, I would like to add platform timestamps to DOM events as the systemTime property. I

[webkit-dev] Adding high resolution platform timestamp to DOM events

2012-10-24 Thread Robert Flack
Hi webkit-dev, I would like to add platform timestamps to DOM events as the systemTime property. I have a patch implementing the feature: https://bugs.webkit.org/show_bug.cgi?id=94987. This will let us know the time at which the system received an event to be able to accurately handle it, whereas

Re: [webkit-dev] is DNS for webkit.org down?

2012-07-03 Thread Robert Hogan
This has started happening again I think. As of 8.30pm GMT Monday evening. On Sunday 01 July 2012 15:34:36 William Siegrist wrote: There was a network issue that has since been resolved. If you're still having trouble, please let me know. -Bill On Jun 30, 2012, at 8:17 PM, Dirk Pranke

Re: [webkit-dev] is DNS for webkit.org down?

2012-07-03 Thread Robert Hogan
Looks like the problem (for me at least) is with Google's DNS servers - 8.8.8.8 and 8.8.4.4. OpenDNS and co. work fine. On Tuesday 03 July 2012 20:37:30 Robert Hogan wrote: This has started happening again I think. As of 8.30pm GMT Monday evening. On Sunday 01 July 2012 15:34:36 William

[webkit-dev] the why of viewport tag

2012-05-07 Thread Robert Kroeger
Hi all, Some of the Chromium developers had a discussion recently about whether or not it was desirable for Chromium to always support the viewport tag even on the desktop. This prompted us to observe that desktop Safari does not support the viewport tag while mobile Safari does. Is anybody

Re: [webkit-dev] Is converting pixel tests to reftests kosher for imported libraries?

2012-04-12 Thread Robert Hogan
On Thursday 12 April 2012 00:58:47 Ryosuke Niwa wrote: On Wed, Apr 11, 2012 at 4:45 PM, Ojan Vafai o...@chromium.org wrote: I agree with the sentiment that we should be upstreaming these to the W3C, but I don't see why we would require upstreaming them first instead of committing them

Re: [webkit-dev] CSS 2.1 Test Suite

2012-04-11 Thread Robert Hogan
On Wednesday 11 April 2012 20:11:23 Alan Stearns wrote: The best way to judge whether a reference result is correct is to submit the result to the W3C CSS 2.1 test suite and have it reviewed. The only way this test suite will get more reference results is if people like us volunteer to submit

Re: [webkit-dev] CSS 2.1 Test Suite

2012-04-11 Thread Robert Hogan
On Tuesday 10 April 2012 22:35:13 Ryosuke Niwa wrote: As we have previous discussed following https://lists.webkit.org/pipermail/webkit-dev/2012-March/019782.html, it's hard to judge whether a given reference result is enough to cover everything the test intends to test. e.g. you can have a

Re: [webkit-dev] CSS 2.1 Test Suite

2012-04-11 Thread Robert Hogan
On Wednesday 11 April 2012 20:27:23 Dirk Pranke wrote: What does clean up the existing folder entail? Just move any -expected.html file out of there and generate pixel results. Or move the test and its -expected.html into a folder in fast/css. ___

Re: [webkit-dev] importing test suites (was: CSS 2.1 Test Suite)

2012-04-11 Thread Robert Hogan
On Wednesday 11 April 2012 23:29:56 Dirk Pranke wrote: 1) What is the best way to add these tests to the tree? Should we add them one-at-a-time with -expected files that we have created? Should we add them all at once and SKIP the tests until we have generated -expected results for each

[webkit-dev] CSS 2.1 Test Suite

2012-04-10 Thread Robert Hogan
be that we only directly import to the css2.1 folder those tests in the CSS test suite that have ref tests native to the suite. Thanks, Robert [1] I keep a local and relatively up to date copy of the passing and failing tests in separate folders in my checkout. Yes I know I should create bugs

Re: [webkit-dev] handling failing tests (test_expectations, Skipped files, etc.)

2012-04-09 Thread Robert Hogan
consquence that when you change the expected pixel result for a test that has pixel results on all platforms you end up with stale png results in the tree for those that you are not in a position either to generate yourself or persuade someone on #webkit to generate for you. Thanks, Robert

Re: [webkit-dev] Git/SVN is slow

2012-03-14 Thread Robert Hogan
On Wednesday 14 March 2012 08:44:46 Ashod Nakashian wrote: From: Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de To: WebKit Development webkit-dev@lists.webkit.org Cc: Sent: Wednesday, March 14, 2012 1:31 AM Subject: [webkit-dev] Git/SVN is slow G ood morning WebKit crowd,

Re: [webkit-dev] Subpixel Layout Update

2012-02-12 Thread Robert O'Callahan
Cool! FYI, your formula for enclosingIntRect is wrong. Consider, e.g., x=0.4 and width=0.7. Also, in pixelSnappedIntRect, you need to ensure that your rounding function doesn't round towards (or away from) 0. See http://robert.ocallahan.org/2008/02/rounding-towards-or-away-from-zero_12.html. In

[webkit-dev] Users of PlatformGestureRecognizer?

2012-01-31 Thread Robert Kroeger
to code derived from GestureRecognizerChromium. Rob. On Mon, Jan 30, 2012 at 5:41 PM, Adam Barth aba...@webkit.org wrote: On Mon, Jan 30, 2012 at 2:35 PM, Robert Kroeger rjkro...@chromium.org wrote: As best as I can tell, only Chromium uses PlatformGestureRecognizer and its Chromium

[webkit-dev] Users of PlatformGestureRecognizer?

2012-01-30 Thread Robert Kroeger
Hi, As best as I can tell, only Chromium uses PlatformGestureRecognizer and its Chromium-specific implementation. Since Chromium no longer needs the code, would anybody object if I removed it? Rob. ___ webkit-dev mailing list

Re: [webkit-dev] does anyone use the advanced --print options to new-run-webkit-tests besides me?

2012-01-25 Thread Robert Hogan
On Wednesday 25 January 2012 21:09:35 Dirk Pranke wrote: On Wed, Jan 25, 2012 at 11:20 AM, Robert Hogan rob...@roberthogan.net wrote: On Wednesday 25 January 2012 07:38:07 Ryosuke Niwa wrote: On somewhat related note, can we simplify the output of new-run-webkit-tests on bots? It's way too

Re: [webkit-dev] Adding Scroll Padding to allow scroll beyond the edge of the page (within some bounds)

2011-10-07 Thread Robert Kroeger
On Thu, Oct 6, 2011 at 2:02 PM, Antonio Gomes toniki...@gmail.com wrote: From what I tested on iOS5 Mobo Safari, it also overscroll's the overflow:scroll case (generally div's). On Thu, Oct 6, 2011 at 1:47 PM, Fady Samuel fsam...@chromium.org wrote: Hi Anders, At this point in time, we see

[webkit-dev] advice for FIXME in EventHandler::handleGestureEvent

2011-09-27 Thread Robert Kroeger
I've been doing some work on gesture events in WebKit. I started thinking/working on how to fix // FIXME: This should hit test and go to the correct subframe rather than // always sending gestures to the main frame only. We should also ensure // that if a frame gets a gesture begin

Re: [webkit-dev] Switching away from integers for layout

2011-06-28 Thread Robert O'Callahan
On Fri, Jun 24, 2011 at 7:11 AM, Levi Weintraub le...@google.com wrote: Emil and I looked into what Firefox did. They did go with a fixed-point-esque approach where one of their units represents 1/96th of a pixel. That number should tell you something about when this work was done, and they

[webkit-dev] Adding ENABLE_GESTURE_MANAGER

2011-05-09 Thread Robert Kroeger
Hi webkit-dev! As suggested by Eric Seidel's email from earlier today, I thought it would be proper to let you know that I am in the process of adding a touch gesture recognition feature to the Chromium port of WebKit. The first part of this feature is

Re: [webkit-dev] Adding ENABLE_GESTURE_MANAGER

2011-05-09 Thread Robert Kroeger
recognizer in the Chrome platform makes it efficient for delivering the synthesized events without additional IPC or external libraries. Rob. Adam On Mon, May 9, 2011 at 11:32 AM, Robert Kroeger rjkro...@chromium.org wrote: Hi webkit-dev! As suggested by Eric Seidel's email from earlier

Re: [webkit-dev] Adding ENABLE_GESTURE_MANAGER

2011-05-09 Thread Robert Kroeger
Hi, On Mon, May 9, 2011 at 3:03 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, May 9, 2011 at 11:32 AM, Robert Kroeger rjkro...@chromium.org wrote: As suggested by Eric Seidel's email from earlier today, I thought it would be proper to let you know that I am in the process of adding

[webkit-dev] API for Handling Browser Fingerprinting

2011-04-26 Thread Robert Hogan
on this? Am I going the right way about exposing the user's environment information to the port and client in 56274 and 56482? Thanks, Robert - ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] beforeload link (esp rel prefetch)

2011-01-13 Thread Robert Hogan
On Thursday 13 January 2011 17:02:15 Alexey Proskuryakov wrote: As a specific example discussed in this thread, we'd break some browser extensions like Incognito if resource loading could bypass onbeforeload. Could you elaborate on this a bit? I don't understand the potential breakage.

[webkit-dev] git and svn out of sync?

2011-01-02 Thread Robert Hogan
: /home/robert/Development/WebKit/Tools/ChangeLog No bug id provided and --reviewer= not provided. Not updating ChangeLogs with reviewer. Parsing ChangeLog: /home/robert/Development/WebKit/Tools/ChangeLog Committed r74869: http://trac.webkit.org/changeset/74869 Committed r74869: http

Re: [webkit-dev] git and svn out of sync?

2011-01-02 Thread Robert Hogan
Looks like this was a false alarm. The revision is now in git. It took an awfully long time to sync though. Was there a problem, or does the git repo wait for a minimum number of revisions before sync'ing? On Sunday 02 January 2011 18:47:40 Robert Hogan wrote: Hi, I committed http

Re: [webkit-dev] Hunspell based spellchecker

2010-11-17 Thread Robert Hogan
On Wednesday 17 November 2010 04:52:36 Hajime Morita wrote: Hi WebKit folks, I'm thinking about porting Hunspell-based spellchecking code from Chromium to WebKit/WebCore. The Qt folks on the list can correct me if I'm wrong but this would be very welcome for Qt. I don't see how a WebCore

Re: [webkit-dev] [webkit-changes] [56661] trunk

2010-03-29 Thread Robert Hogan
obviously Qt-specific. - WBR, Alexey Proskuryakov On 27.03.2010, at 5:46, rob...@webkit.org wrote: Revision 56661 Author rob...@webkit.org Date 2010-03-27 05:46:35 -0700 (Sat, 27 Mar 2010) Log Message 2010-03-26 Robert Hogan rob...@roberthogan.net Reviewed

Re: [webkit-dev] [webkit-changes] [56661] trunk

2010-03-29 Thread Robert Hogan
the rule specific to the Qt port unless someone shouts stop! Thanks, Robert On Mon, Mar 29, 2010 at 1:16 PM, Alexey Proskuryakov a...@webkit.org wrote: What is an application plugin outside of Qt context? This change will make all port authors scratch their heads trying to understand what

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-03-09 Thread Robert O'Callahan
Mozilla has been using this technique for years. Perhaps we can pick their brains for some good tricks. Or, dare I say it, share some tests. Hi, hope I'm not crashing the party, and sorry I'm late :-). Let me just say a few things about reftests... Maciej mentioned that a reftest can assert

[webkit-dev] [QtWebKit] exposing JScript Objects to Clients

2009-09-29 Thread Robert Hogan
Hi there, At the moment WebKit does not deliberately expose any of the properties of Javascript objects to clients. Those it does expose seem to be as much by luck as anything else. One example is navigator.useragent, which in Qt's case ultimately returns whatever the client has set in

Re: [webkit-dev] [GTK]Scroll deficiency

2009-03-26 Thread robert
I think maybe webkit does not refresh the page when scroll. So, i trace the flow of webkit when scroll event fired. In function ChromeClient::repaint() If i mask // if (contentChanged) all the problem is gone when scroll page. Even though the page refresh ok when scroll follow upon,

Re: [webkit-dev] Removing ICU dependancy from WebKit?

2008-02-05 Thread Robert Norris
Robert's file showing the commands he did looks like a much more structured way to do it than what I did ;) It took me many tens of tries before I finally worked out a set of steps that worked every time. I'm still not convinced the library actually does the right thing, all I wanted was

Re: [webkit-dev] Removing ICU dependancy from WebKit?

2008-01-25 Thread Robert Norris
I managed to cross-compile ICU based on Ryan Leavengood's description of how he got it to work. My steps are for compiling on Linux for AROS, but you might be able to work something out based on them: http://cataclysm.cx/git/cgit.cgi?url=icu/tree/BUILD.AROS FYI, I'm intending to remove the ICU

[webkit-dev] Failed assertion at FrameLoader.cpp:3940 in AROS port

2008-01-05 Thread Robert Norris
I've hit a snag with my efforts porting WebKit to AROS and I really need some help from someone who understands this code. This description will probably be a little vague, because I'm not entirely sure what information to provide, but I'll try. My port is so far pretty much just stubs, but I

[webkit-dev] Introduction

2007-12-03 Thread Robert Norris
Adam suggested privately that I introduce myself and my work to the list as a good first step towards getting a contributor badge. I'm working on a port of WebKit to AROS (http://aros.org/) which is a reimplementation of the Amiga OS. Its been around since 1995 but has never attracted a lot of

Re: [webkit-dev] Moving away from qmake

2007-11-12 Thread Robert Norris
If we cannot reach a conclusion, the GTK+ port will most likely go ahead and switch to autotools. I'm one person with a highly niche port, but for what its worth I'd support a move to autotools. I'm doing a port to AROS, which currently means cross-building WebKit on Linux. I opted to use

Re: [webkit-dev] Windows WebKit/Safari incompatibilities have been resolved

2007-11-09 Thread Robert Błaut
:( -- Regards Robert Błaut ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Where does S60 WebKit discussion take place?

2007-08-22 Thread Robert Nicholson
Anybody know where discussion of the S60 WebKit takes place? ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev