Re: [webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-10 Thread Steven Coul (scoul)
A rebuild from scratch with no ccache is 48m approx. So 34 seconds isn’t so useful. My “normal” build case involves pulling updates from webkit.org once or twice a day and rebuilding WTF/JSCore/WebCore with my patch set. I also do a clean rebuild prior to my local commits since it’s the best

Re: [webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-10 Thread Darin Adler
On Mar 9, 2015, at 5:02 PM, Steven Coul (scoul) sc...@cisco.com wrote: The IDL processing time went from 139 seconds real time to 105. 34 seconds sounds like substantial savings. What’s the total build time for you on that computer? — Darin ___

Re: [webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-09 Thread Steven Coul (scoul)
Would [Conditional] use through out also not allow us to perform the IDL compile without running the c preprocessor on each file? Can [Conditional] not be fixed to support multiple flags? The compiling of IDL is a significant portion of the total build time, and ccache distcc et al cannot

Re: [webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-09 Thread Darin Adler
On Mar 9, 2015, at 5:39 AM, Steven Coul (scoul) sc...@cisco.com wrote: Would [Conditional] use through out also not allow us to perform the IDL compile without running the c preprocessor on each file? Possibly. Can [Conditional] not be fixed to support multiple flags? It does support

Re: [webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-09 Thread Steven Coul (scoul)
On Mar 9, 2015, at 2:52 PM, Darin Adler da...@apple.com wrote: On Mar 9, 2015, at 5:39 AM, Steven Coul (scoul) sc...@cisco.com wrote: Would [Conditional] use through out also not allow us to perform the IDL compile without running the c preprocessor on each file? Possibly. Can

[webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-07 Thread Darin Adler
Why do we have [Conditional=] in our IDL files? Perhaps because some ports lacked a way to do #if in the past? Should we use #if or [Conditional]? See for example, HTMLMediaElement.idl, which has a mix of both styles. It’s pretty ugly how the #if look in the IDL files, but even worse is a

Re: [webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-07 Thread Ryosuke Niwa
On Sat, Mar 7, 2015 at 8:55 AM, Darin Adler da...@apple.com wrote: Why do we have [Conditional=] in our IDL files? Perhaps because some ports lacked a way to do #if in the past? I think Conditional is a nicer/newer way of if-defing based on feature flags. Should we use #if or