Re: [webkit-dev] Ancient patches in pending-review

2010-05-18 Thread Ojan Vafai
On Thu, May 13, 2010 at 9:12 AM, Adam Barth wrote: > Editing (Enrica, Ojan) > * 24943: Command-B and Command-I do not generate keydown events in > contentEditable regions. > * 35632: htmlediting.cpp : isEmptyTableCell() is incomplete > * 32605: Regression: Selection anchor + focus swap when arrow

Re: [webkit-dev] Ancient patches in pending-review

2010-05-16 Thread 鵜飼文敏
On Fri, May 14, 2010 at 02:31, Alexey Proskuryakov wrote: > > 13.05.2010, в 10:19, David Levin написал(а): > > > Should we just r- and ask that it wait for "conceptual issues to be >> resolved in IETF spec review first" (unless for some reason it is needed >> quickly and that takes too long)? >>

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Alexey Proskuryakov
13.05.2010, в 10:19, David Levin написал(а): Should we just r- and ask that it wait for "conceptual issues to be resolved in IETF spec review first" (unless for some reason it is needed quickly and that takes too long)? I am not aware of any specific conceptual issues, just the fact that

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Adam Roben
On May 13, 2010, at 12:12 PM, Adam Barth wrote: > * 34953: Implement DEFINE_STUB_FUNCTION for WinCE I think this bug (and bug 36050, which it depends on) should be reviewed by Gavin Barraclough. -Adam ___ webkit-dev mailing list webkit-dev@lists.webk

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread David Levin
On Thu, May 13, 2010 at 10:15 AM, Alexey Proskuryakov wrote: > > 13.05.2010, в 9:41, David Levin написал(а): > > > * 35573: WebSocket add new event: CloseEvent >> >> I think ap is much more familiar with WebSockets -- though I am willing to >> look if needed. >> > > Anyone can review this patch

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Alexey Proskuryakov
13.05.2010, в 9:41, David Levin написал(а): * 35573: WebSocket add new event: CloseEvent I think ap is much more familiar with WebSockets -- though I am willing to look if needed. Anyone can review this patch - the key to reviewing is to decide whether a "close event" actually makes sens

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Jeremy Orlow
On Thu, May 13, 2010 at 5:41 PM, David Levin wrote: > > > On Thu, May 13, 2010 at 9:12 AM, Adam Barth wrote: > >> One of the least fun things in the project is to pour a bunch of >> effort into writing a patch only to see it sit forever waiting for >> review. In the past, I've tried to single-h

Re: [webkit-dev] Ancient patches in pending-review

2010-05-13 Thread David Levin
On Thu, May 13, 2010 at 9:12 AM, Adam Barth wrote: > One of the least fun things in the project is to pour a bunch of > effort into writing a patch only to see it sit forever waiting for > review. In the past, I've tried to single-handedly tackle the patches > that have been up for review for mo

[webkit-dev] Ancient patches in pending-review

2010-05-13 Thread Adam Barth
One of the least fun things in the project is to pour a bunch of effort into writing a patch only to see it sit forever waiting for review. In the past, I've tried to single-handedly tackle the patches that have been up for review for more than a month. That approach is less than ideal because (1