Re: [webkit-dev] CSSGroupingRule and a bit of refactoring?

2012-12-23 Thread Maciej Stachowiak
On Dec 21, 2012, at 3:06 PM, Elliott Sprehn espr...@chromium.org wrote: On Fri, Dec 21, 2012 at 6:09 AM, Antti Koivisto koivi...@iki.fi wrote: On Fri, Dec 21, 2012 at 3:33 AM, Tab Atkins Jr. jackalm...@gmail.com wrote: No, it's just a refactoring on the CSS side, so we don't have to repeat

Re: [webkit-dev] CSSGroupingRule and a bit of refactoring?

2012-12-21 Thread Antti Koivisto
On Fri, Dec 21, 2012 at 3:33 AM, Tab Atkins Jr. jackalm...@gmail.comwrote: No, it's just a refactoring on the CSS side, so we don't have to repeat a bunch of stuff every time we have an at-rule that contains other rules. It just makes the WebIDL easier and less error-prone. It seems bit

Re: [webkit-dev] CSSGroupingRule and a bit of refactoring?

2012-12-21 Thread Elliott Sprehn
On Fri, Dec 21, 2012 at 6:09 AM, Antti Koivisto koivi...@iki.fi wrote: On Fri, Dec 21, 2012 at 3:33 AM, Tab Atkins Jr. jackalm...@gmail.comwrote: No, it's just a refactoring on the CSS side, so we don't have to repeat a bunch of stuff every time we have an at-rule that contains other rules.

Re: [webkit-dev] CSSGroupingRule and a bit of refactoring?

2012-12-20 Thread Tab Atkins Jr.
On Thu, Dec 13, 2012 at 2:12 PM, Antti Koivisto koivi...@iki.fi wrote: We already have internal type corresponding to the new CSSGroupingRule, StyleRuleBlock. Technically refactoring the CSSOM like this would be fairly trivial. It is not clear to me what value this new type adds though. In JS

Re: [webkit-dev] CSSGroupingRule and a bit of refactoring?

2012-12-13 Thread Antti Koivisto
We already have internal type corresponding to the new CSSGroupingRule, StyleRuleBlock. Technically refactoring the CSSOM like this would be fairly trivial. It is not clear to me what value this new type adds though. In JS you don't really care if types have a common base as long as they share

Re: [webkit-dev] CSSGroupingRule and a bit of refactoring?

2012-12-13 Thread Pablo Flouret
On Thu, 13 Dec 2012 14:12:06 -0800, Antti Koivisto koivi...@iki.fi wrote: We already have internal type corresponding to the new CSSGroupingRule, StyleRuleBlock. Technically refactoring the CSSOM like this would be fairly trivial. It is not clear to me what value this new type adds though. In

[webkit-dev] CSSGroupingRule and a bit of refactoring?

2012-12-12 Thread Pablo Flouret
Hello webkit folk, I'm working on having @supports behave like a proper CSSSupportsRule [1]. In the css3-conditional spec, CSSSupportsRule inherits from a CSSGroupingRule (CSSMediaRule does as well): http://dev.w3.org/csswg/css3-conditional/#the-cssgroupingrule-interface. I'm wondering if it's