On Jun 12, 2012, at 1:02 PM, Ryosuke Niwa wrote:
> Because then we'll be placing tests for one component in multiple directories.
Makes sense, but fleshing this out for all the tests could be tricky.
Only a certain percentage of our tests will fall cleanly into a component such
as CSS or DOM.
On Tue, Jun 12, 2012 at 10:54 AM, Darin Adler wrote:
> On Jun 12, 2012, at 10:17 AM, Ryosuke Niwa wrote:
> > The last time we had this discussion, the consensus appeared to be
> renaming it to RegressionTests.
>
> I still like that name.
>
> > Are you suggesting that we have LayoutTests/W3C?
>
>
On Jun 12, 2012, at 10:17 AM, Ryosuke Niwa wrote:
> The last time we had this discussion, the consensus appeared to be renaming
> it to RegressionTests.
I still like that name.
> Are you suggesting that we have LayoutTests/W3C?
Yes. Something like RegressionTests/ImportedTests/W3C.
> we have
12.06.2012, в 9:59, Ojan Vafai написал(а):
> One more item I'd add to this list:
> -Replace js-test-post.js with an onload handler in js-test-pre.js so we can
> get rid of that file entirely.
I think that this is a separate discussion to test directory reorganization.
Also, I'd question that
On Tue, Jun 12, 2012 at 9:50 AM, Darin Adler wrote:
>
> - Each time we change the tests we need to make sure we haven’t broken new
> tests on various platforms and that we’ve updated the skipped or test
> expectations files properly.
>
- When rearranging tests that share the test shell JavaScript
On Tue, Jun 12, 2012 at 9:50 AM, Darin Adler wrote:
> On Jun 11, 2012, at 7:33 PM, Mike Lawther wrote:
>
> > Does having the 'fast' directory still serve a useful purpose?
>
> Not sure it does.
>
> The original intent was to put more extensive complete tests that were
> slow but had greater cover
On Jun 11, 2012, at 7:33 PM, Mike Lawther wrote:
> Does having the 'fast' directory still serve a useful purpose?
Not sure it does.
The original intent was to put more extensive complete tests that were slow but
had greater coverage outside the “fast” directory, so that you could run the
major
I don't think there is any consistency across the project here except
everyone agrees that imported test suites shouldn't go in fast, e.g. all
our new flexbox tests have gone in css3/flexbox.
On Mon, Jun 11, 2012 at 10:28 PM, James Robinson wrote:
> There are plenty of non-text tests in fast/, e
There are plenty of non-text tests in fast/, even entire directories of
them (fast/repaint). My understanding of the meaning of fast/ is that it is
where new tests that are not imported should go. This meaning is not
universally applied.
- James
On Jun 11, 2012 7:33 PM, "Mike Lawther" wrote:
> I
On Mon, Jun 11, 2012 at 7:33 PM, Mike Lawther wrote:
>
> I did so because I not all my tests are 'text only' tests, but I still
> wanted them all together. My understanding was that the 'fast' directory
> was intended for 'text only' tests only.
>
That's not the case. The reason we have many pixel
I'm the guy that added css3/calc tests.
I did so because I not all my tests are 'text only' tests, but I still
wanted them all together. My understanding was that the 'fast' directory
was intended for 'text only' tests only.
Does having the 'fast' directory still serve a useful purpose? I reckon
On 6/11/12 2:37 PM, "Ryosuke Niwa" mailto:rn...@webkit.org>>
wrote:
On Mon, Jun 11, 2012 at 2:33 PM, Dirk Pranke
mailto:dpra...@chromium.org>> wrote:
Technically, it does (at least NRWT does), but I wouldn't recommend
it. NRWT is designed to allow tests to live in multiple repos, but it
seems li
On Mon, Jun 11, 2012 at 2:33 PM, Dirk Pranke wrote:
>
> Technically, it does (at least NRWT does), but I wouldn't recommend
> it. NRWT is designed to allow tests to live in multiple repos, but it
> seems like all of the tests in the webkit repo should be under a
> single top-level dir.
>
I don't
On Mon, Jun 11, 2012 at 2:24 PM, Ryosuke Niwa wrote:
> On Mon, Jun 11, 2012 at 2:21 PM, Jacob Goldstein wrote:
>>
>> Can we just create an imported-w3c folder at the same level as
>> LayoutTests?
>
>
> You mean at trunk? I don't think that makes sense, and our testing
> infrastructure doesn't sup
On Mon, Jun 11, 2012 at 2:25 PM, Jacob Goldstein wrote:
> On 6/11/12 2:24 PM, "Ryosuke Niwa" wrote:
>
> On Mon, Jun 11, 2012 at 2:21 PM, Jacob Goldstein wrote:
>>
>> Can we just create an imported-w3c folder at the same level as
>> LayoutTests?
>>
>
> You mean at trunk? I don't think that makes
On 6/11/12 2:24 PM, "Ryosuke Niwa" mailto:rn...@webkit.org>>
wrote:
On Mon, Jun 11, 2012 at 2:21 PM, Jacob Goldstein
mailto:jac...@adobe.com>> wrote:
Can we just create an imported-w3c folder at the same level as LayoutTests?
You mean at trunk? I don't think that makes sense, and our testing
i
On Mon, Jun 11, 2012 at 2:21 PM, Jacob Goldstein wrote:
>
> Can we just create an imported-w3c folder at the same level as LayoutTests?
>
You mean at trunk? I don't think that makes sense, and our testing
infrastructure doesn't support that.
- Ryosuke
On 6/11/12 11:11 AM, "Alexis Menard" wrote:
>On Mon, Jun 11, 2012 at 3:09 PM, Simon Fraser
>wrote:
>> I think imported tests should be outside of LayoutTests/fast.
>
>I agree a dedicated folder seems more appropriate.
>
>My two cents.
>
>>
>> Simon
>>
>> On Jun 11, 2012, at 1:57 AM, Ryosuke Niwa
On Mon, Jun 11, 2012 at 3:09 PM, Simon Fraser wrote:
> I think imported tests should be outside of LayoutTests/fast.
I agree a dedicated folder seems more appropriate.
My two cents.
>
> Simon
>
> On Jun 11, 2012, at 1:57 AM, Ryosuke Niwa wrote:
>
> Hi,
>
> I realized that there are a whole bunc
I think imported tests should be outside of LayoutTests/fast.
Simon
On Jun 11, 2012, at 1:57 AM, Ryosuke Niwa wrote:
> Hi,
>
> I realized that there are a whole bunch of tests in LayoutTests/css3 that use
> layoutTestController (e.g. css3/calc, css3/filters, etc...), which appears to
> mean t
Hi,
I realized that there are a whole bunch of tests in LayoutTests/css3 that
use layoutTestController (e.g. css3/calc, css3/filters, etc...), which
appears to mean that they're our own tests. However, css3/selectors3 is an
imported W3C test suite. It's very confusing to mix imported tests and
Web
21 matches
Mail list logo
