Re: [webkit-dev] Committing EFL baselines

2011-10-19 Thread Leandro Pereira
On 10/17/2011 04:13 PM, Raphael Kubo da Costa wrote: Anyway, are there any options besides simply svn commit'ting all these files? I'm thinking in uploading the text baselines (which are small) first. When these are in place, we could work together to diminish the amount of pixel baselines by

Re: [webkit-dev] Committing EFL baselines

2011-10-17 Thread Raphael Kubo da Costa
Leandro Pereira writes: > What's the preferred way to commit a ton of baselines for a port that > currently has none? > > On our internal EFL tree, there is about 125MB of baselines for both > pixel and text tests. Unfortunately we were unable to share our > baselines with similar ports, due to s

Re: [webkit-dev] Committing EFL baselines

2011-09-12 Thread Ryosuke Niwa
On Mon, Sep 12, 2011 at 2:50 PM, Leandro Pereira wrote: > > Most differences are because the EFL port doesn't change the viewport size > because of the scrollbar: it is drawn on top of the content on the EFL port > by default. So there is a little more room horizontally, and then text > results are

Re: [webkit-dev] Committing EFL baselines

2011-09-12 Thread Leandro Pereira
On 09/12/2011 05:36 PM, Ryosuke Niwa wrote: On our internal EFL tree, there is about 125MB of baselines for both pixel and text tests. Unfortunately we were unable to share our baselines with similar ports, due to slight differences in results. What are differences you're seeing? >

Re: [webkit-dev] Committing EFL baselines

2011-09-12 Thread Peter Kasting
On Mon, Sep 12, 2011 at 1:56 PM, David Levin wrote: > On Mon, Sep 12, 2011 at 1:48 PM, Peter Kasting wrote: > >> In particular, if we have pixel tests that don't need to be pixel tests at >> all, or font rendering differences due to explanatory text that could be >> moved to an HTML comment insid

Re: [webkit-dev] Committing EFL baselines

2011-09-12 Thread Ryosuke Niwa
On Mon, Sep 12, 2011 at 1:56 PM, David Levin wrote: > > On Mon, Sep 12, 2011 at 1:48 PM, Peter Kasting wrote: > >> On Mon, Sep 12, 2011 at 1:36 PM, Ryosuke Niwa wrote: >> >>> This is pretty much unreviewable, so I pretend to commit this directly, in batches (one commit per toplevel directory

Re: [webkit-dev] Committing EFL baselines

2011-09-12 Thread David Levin
On Mon, Sep 12, 2011 at 1:48 PM, Peter Kasting wrote: > On Mon, Sep 12, 2011 at 1:36 PM, Ryosuke Niwa wrote: > >> This is pretty much unreviewable, so I pretend to commit this directly, in >>> batches (one commit per toplevel directory in LayoutTests/platform/efl) in >>> the next weeks. Any objec

Re: [webkit-dev] Committing EFL baselines

2011-09-12 Thread Peter Kasting
On Mon, Sep 12, 2011 at 1:36 PM, Ryosuke Niwa wrote: > This is pretty much unreviewable, so I pretend to commit this directly, in >> batches (one commit per toplevel directory in LayoutTests/platform/efl) in >> the next weeks. Any objections or suggestions? >> > > It'll be nice if we could spend

Re: [webkit-dev] Committing EFL baselines

2011-09-12 Thread Ryosuke Niwa
On Mon, Sep 12, 2011 at 1:32 PM, Leandro Pereira wrote: > Hi. > > What's the preferred way to commit a ton of baselines for a port that > currently has none? > > On our internal EFL tree, there is about 125MB of baselines for both pixel > and text tests. Unfortunately we were unable to share our b

[webkit-dev] Committing EFL baselines

2011-09-12 Thread Leandro Pereira
Hi. What's the preferred way to commit a ton of baselines for a port that currently has none? On our internal EFL tree, there is about 125MB of baselines for both pixel and text tests. Unfortunately we were unable to share our baselines with similar ports, due to slight differences in result