Re: [webkit-dev] Defaulting --exit-after-n-failures to 0

2012-06-08 Thread Ryosuke Niwa
On Fri, Jun 8, 2012 at 1:38 PM, Ojan Vafai wrote: > On Fri, Jun 8, 2012 at 12:46 PM, Dirk Pranke wrote: > >> On Fri, Jun 8, 2012 at 12:44 PM, Ryosuke Niwa wrote: >> > On Fri, Jun 8, 2012 at 12:37 PM, Dirk Pranke >> wrote: >> >> >> >> I have no objection either to increasing the defaults for ei

Re: [webkit-dev] Defaulting --exit-after-n-failures to 0

2012-06-08 Thread Ojan Vafai
On Fri, Jun 8, 2012 at 12:46 PM, Dirk Pranke wrote: > On Fri, Jun 8, 2012 at 12:44 PM, Ryosuke Niwa wrote: > > On Fri, Jun 8, 2012 at 12:37 PM, Dirk Pranke > wrote: > >> > >> I have no objection either to increasing the defaults for either of > >> these numbers or making it possible to have dif

Re: [webkit-dev] Defaulting --exit-after-n-failures to 0

2012-06-08 Thread Dirk Pranke
On Fri, Jun 8, 2012 at 12:44 PM, Ryosuke Niwa wrote: > On Fri, Jun 8, 2012 at 12:37 PM, Dirk Pranke wrote: >> >> I have no objection either to increasing the defaults for either of >> these numbers or making it possible to have different defaults per >> port. >> >> Do you want to suggest differen

Re: [webkit-dev] Defaulting --exit-after-n-failures to 0

2012-06-08 Thread Ryosuke Niwa
On Fri, Jun 8, 2012 at 12:37 PM, Dirk Pranke wrote: > I have no objection either to increasing the defaults for either of > these numbers or making it possible to have different defaults per > port. > > Do you want to suggest different defaults? Should we use ORWT's > (infinite failures and infin

Re: [webkit-dev] Defaulting --exit-after-n-failures to 0

2012-06-08 Thread Dirk Pranke
I have no objection either to increasing the defaults for either of these numbers or making it possible to have different defaults per port. Do you want to suggest different defaults? Should we use ORWT's (infinite failures and infinite crashes by default)? -- Dirk On Fri, Jun 8, 2012 at 12:31 P

Re: [webkit-dev] Defaulting --exit-after-n-failures to 0

2012-06-08 Thread Ryosuke Niwa
On Fri, Jun 8, 2012 at 12:12 PM, Ojan Vafai wrote: > On Fri, Jun 8, 2012 at 12:08 PM, Ryosuke Niwa wrote: > >> On Fri, Jun 8, 2012 at 12:05 PM, Ojan Vafai wrote: >>> >>> We'll still default --exit-after-n-crashes-or-timeouts to 20. That seems >>> more useful to me since you'd rarely hit this ca

Re: [webkit-dev] Defaulting --exit-after-n-failures to 0

2012-06-08 Thread Ojan Vafai
On Fri, Jun 8, 2012 at 12:08 PM, Ryosuke Niwa wrote: > On Fri, Jun 8, 2012 at 12:05 PM, Ojan Vafai wrote: >> >> We'll still default --exit-after-n-crashes-or-timeouts to 20. That seems >> more useful to me since you'd rarely hit this case locally and want to >> continue running tests. >> > > We

Re: [webkit-dev] Defaulting --exit-after-n-failures to 0

2012-06-08 Thread Ryosuke Niwa
On Fri, Jun 8, 2012 at 12:05 PM, Ojan Vafai wrote: > > We'll still default --exit-after-n-crashes-or-timeouts to 20. That seems > more useful to me since you'd rarely hit this case locally and want to > continue running tests. > We should also increase this number. Non-chromium bots hit this limi

[webkit-dev] Defaulting --exit-after-n-failures to 0

2012-06-08 Thread Ojan Vafai
Speaking of differences between NRWT and ORWT, ORWT doesn't limit to n failures by default. NRWT limits to 500 by default. It looks like all the bots pass in --exit-after-n-failures=500. Any objection to making NRWT match ORWT here? I don't think having this limit is useful/necessary for local deve