[webkit-dev] Exciting JS features (class fields) in need of review :)

Hi WebKitters, My colleagues at Igalia have been working on a number of JS language features! We want WebKit to have implementations in order to provide feedback for TC39, and to help meet the requirements to have them merged into the specification proper. Unfortunately, JSC suggested reviewer

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

I left the boring review feedback that this work should be behind a feature flag. Mentioning it here because this may apply to other feature patches you have in progress. (I am not qualified to review the substance of what the patch is doing.) > On Feb 13, 2019, at 1:51 PM, ca...@igalia.com w

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

Hi Maciej, the first patches had the flag indeed, so it should be easy to add it back to the patch. Not sure what's the usual procedure, but I guess it makes sense to enable it by default in the bug so that the bots keep testing the code? Then we'll disable it before landing if that's our decision

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

Hi Caitlin and Xan, > On Feb 13, 2019, at 1:51 PM, ca...@igalia.com wrote: > > Hi WebKitters, > > My colleagues at Igalia have been working on a number of JS language > features! We want WebKit to have implementations in order to provide feedback > for TC39, and to help meet the requirements t

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

> On Feb 14, 2019, at 1:37 AM, Xan Lopez wrote: > > Hi Maciej, > > the first patches had the flag indeed, so it should be easy to add it back to > the patch. Not sure what's the usual procedure, but I guess it makes sense to > enable it by default in the bug so that the bots keep testing the

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

Hi Xan, FYI, if you’re writing JSC stress tests, you can add test specific options by putting the following at the top of the test file: //@ requireOptions(“--myOption=true”, “--myOtherOption=1234”) For LayoutTests, you can add the following to the top line of the test html file: This way,

Re: [webkit-dev] Exciting JS features (class fields) in need of review :)

Hi all, last February we got a thorough review of the class fields patch, and have been updating it pretty frequently since. We think it's ready to be reviewed again. Hopefully we'll manage to either land this first stage of the feature, or receive enough new feedback to keep working on it. The bug