Re: [webkit-dev] Fwd: webkit editing rewrite?

2010-08-09 Thread Ojan Vafai
On Thu, Aug 5, 2010 at 1:59 AM, Maciej Stachowiak wrote: > I think this carries an assumption that the right internal abstractions are > necessarily also a sensible public API. I don't know if that is a good > assumption. > You're right that I was making this assumption. My intuition is that the

Re: [webkit-dev] Fwd: webkit editing rewrite?

2010-08-05 Thread Adam Barth
On Thu, Aug 5, 2010 at 1:59 AM, Maciej Stachowiak wrote: >> On Aug 4, 2010 4:30:01 PM PDT, Darin Adler wrote: On Aug 4, 2010, at 3:48 PM, Ryosuke Niwa wrote: > I think the kind of crashes Ojan is talking about are ones caused by DOM mutation events. >> >>> It’s possible we’ll addre

Re: [webkit-dev] Fwd: webkit editing rewrite?

2010-08-05 Thread Maciej Stachowiak
On Aug 4, 2010, at 6:12 PM, Ojan Vafai wrote: > > On Tue, Aug 3, 2010 at 5:07 PM, Geoffrey Garen wrote: >>> -Ensures that the APIs we expose to the web are at least good enough for >>> our own editing code >> >> I don't think this necessarily follows. Not everything exposed to the >> interna

Re: [webkit-dev] Fwd: webkit editing rewrite?

2010-08-04 Thread Ojan Vafai
On Tue, Aug 3, 2010 at 5:06 PM, Simon Fraser wrote: > I assume you plan on maintaining support for the DOM Range API? > Yes. We're stuck with them unfortunately. On Tue, Aug 3, 2010 at 5:07 PM, Geoffrey Garen wrote: >> -Ensures tha

Re: [webkit-dev] Fwd: webkit editing rewrite?

2010-08-04 Thread Darin Adler
On Aug 4, 2010, at 3:48 PM, Ryosuke Niwa wrote: > I think the kind of crashes Ojan is talking about are ones caused by DOM > mutation events. When we're in a middle of a composite event and fire a > DOMModified or whatever appropriate mutation event is, JavaScript can come in > and remove node

[webkit-dev] Fwd: webkit editing rewrite?

2010-08-04 Thread Ryosuke Niwa
> > -Ensures that editing code never crashes (outside of JSC/V8 bugs) > > JavaScript can still crash -- you just get an unhandled exception instead > of a segfault. It's not clear to me why that would be better. I think the kind of crashes Ojan is talking about are ones caused by DOM mutation ev