Re: [webkit-dev] HAVE_LANGINFO_H and OS X

2009-03-24 Thread Kevin Ollivier
Hi Darin, On Mar 23, 2009, at 12:55 PM, Darin Adler wrote: But I think that all DARWIN-targeted ports and indeed any port where PLATFORM(CF) is true, should use the superior version based on CFDateFormatter. That’s an even better fix for Mac OS X. Thanks, I've put the more limited fix up h

Re: [webkit-dev] HAVE_LANGINFO_H and OS X

2009-03-23 Thread Darin Adler
But I think that all DARWIN-targeted ports and indeed any port where PLATFORM(CF) is true, should use the superior version based on CFDateFormatter. That’s an even better fix for Mac OS X. -- Darin ___ webkit-dev mailing list webkit-dev@lists.w

Re: [webkit-dev] HAVE_LANGINFO_H and OS X

2009-03-23 Thread Darin Adler
On Mar 23, 2009, at 12:49 PM, Kevin Ollivier wrote: It does in fact fix the problem, but to get the fix I need to explicitly #define HAVE_LANGINFO_H 1 on Mac. I'm wondering if it's safe to define it to 1 for all ports building under Darwin, or if I should keep the fix isolated to the wx por

[webkit-dev] HAVE_LANGINFO_H and OS X

2009-03-23 Thread Kevin Ollivier
Hi all, Gustavo Noronha recently wrote me and pointed out that he did some work on the GTK port to fix a JSCore test (http://trac.webkit.org/changeset/41909 ), and said he thought that the fix might also apply to the JSCore regression we see on the wx port. It does in fact fix the problem, b