[webkit-dev] Implementing new WebSocket protocol

Hello, I would like to propose to start implementing the new WebSocket protocol which is discussed in IETF HyBi working group. Protocol draft: http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-09 JavaScript API draft: http://dev.w3.org/html5/websockets/ The new protocol is *incompa

Re: [webkit-dev] Implementing new WebSocket protocol

I think it's important to move forward with the new protocol. I'm not sure it matter too much what the transition plan is, but we should eventually remove the implementation of the old protocol from WebKit. No one else is going to implement the old protocol. Adam On Tue, Jun 14, 2011 at 7:55 AM

Re: [webkit-dev] Implementing new WebSocket protocol

On Tue, Jun 14, 2011 at 7:55 AM, Yuta Kitamura wrote: > > My original plan was to implement the new protocol directly (i.e. replacing > the old implementation in-place). However Alexey (ap) objected to dropping > support for the old protocol immediately. > > So, I'm currently planning to add a run

Re: [webkit-dev] Implementing new WebSocket protocol

We also said previously that we would remove the old protocol due to security concerns about poisoning caches/proxies. We justified not immediately disabling -00 like other browsers did by saying that a new version addressing the issue would come soon. We've had 9 new versions since and have yet to

Re: [webkit-dev] Implementing new WebSocket protocol

Reading that bug, Alexey's concerns seem to have been addressed by Firefox and IE shipping the new protocol. We don't want to ship something in between the old and new protocols though, so if it will take multiple patches to switch over, we should probably put it behind a runtime flag. On Tue, Jun

Re: [webkit-dev] Implementing new WebSocket protocol

I thought Kitamura-san had patches mostly ready to switch us over? Either way, I agree we don't want to ship something in the middle, but I would verymuch like to see us shipping -09 by July at the latest. We've got a protocol that's stable, we've got external partners waiting to use this (esp. wit

Re: [webkit-dev] Implementing new WebSocket protocol

Getting on the latest protocol in place would be great, so long as we minimize the risk of anyone shipping a halfway mix. - Maciej On Jun 14, 2011, at 10:47 AM, Ian Fette (イアンフェッティ) wrote: > I thought Kitamura-san had patches mostly ready to switch us over? Either > way, I agree we don't wan

Re: [webkit-dev] Implementing new WebSocket protocol

On Wed, Jun 15, 2011 at 6:57 AM, Maciej Stachowiak wrote: > > Getting on the latest protocol in place would be great, so long as we > minimize the risk of anyone shipping a halfway mix. > What do you mean by "a halfway mix"? If you mean we should not ship until the complete feature set is ready

Re: [webkit-dev] Implementing new WebSocket protocol

If possible, I would encourage any breaking update to WebSockets (protocol or JS API) to be feature detectable. Additionally, I would encourage WebKit to postpone updating to -09 to coincide with expected changes to the JS API, which may provide the necessary feature detection mechanisms (e.g., Web

Re: [webkit-dev] Implementing new WebSocket protocol

There seems to be no strong objection to adding a runtime flag, and I think it will take some time and need multiple patches to get the implementation in good shape. Therefore, I'd like to start to implement behind a runtime flag. It allows each port to control the time to switch protocols, too (of

Re: [webkit-dev] Implementing new WebSocket protocol

I'm surprised that the protocol has no facility for versioning. Is that really he case? Should it be considered for future versions of the spec? Simon On Jun 23, 2011, at 6:07 AM, Yuta Kitamura wrote: > There seems to be no strong objection to adding a runtime flag, and I think > it will take

Re: [webkit-dev] Implementing new WebSocket protocol

On 2011-06-23 17:15, Simon Fraser wrote: I'm surprised that the protocol has no facility for versioning. Is that really he case? Should it be considered for future versions of the spec? It does.

Re: [webkit-dev] Implementing new WebSocket protocol

That said, I don't think the intent should be to support any old versions for any protracted amount of time. -00 has security vulnerabilities brought up by people on webkit-dev@ so from the Chrome side, we intend not to support -00 at all once we have -09 support available. All the makers of server

Re: [webkit-dev] Implementing new WebSocket protocol

That said, you're all lucky that the rest of us developers have no idea when the current round of specification flux will settle down. Security vulnerabilities will always trump the specs. Thanks for keeping on top of things. -Charles On 6/23/2011 5:16 PM, Ian Fette (イアンフェッティ) wrote: That sai

Re: [webkit-dev] Implementing new WebSocket protocol

FWIW it has settled down. The spec is in last call and isn't changing, rather we're just arguing over wording, references in the spec, clarifying text based on implementation experiences and ambiguities implementers have found, etc. On Thu, Jun 23, 2011 at 6:29 PM, Charles Pritchard wrote: > *