Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Konstantin Tokarev
30.03.2016, 20:41, "Alex Christensen" : > I agree that it would be better to have one approach to copying forwarding > headers, but there is a fundamental disagreement between the needs of the > ports.  Windows needs the entire header to be copied into the forwarding >

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Alex Christensen
I agree that it would be better to have one approach to copying forwarding headers, but there is a fundamental disagreement between the needs of the ports. Windows needs the entire header to be copied into the forwarding directory because some internal builds are built without the other

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Konstantin Tokarev
30.03.2016, 19:47, "Brent Fulgham" : > This is happening because “Font.h” is referring to > “”, which doesn’t always exist on Windows at the > time the file is compiled. The CoreGraphicsSPI.h file lives in > “WebCore/platform/spi/cg/CoreGraphicsSPI.h”, and can be found

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Brent Fulgham
This is happening because “Font.h” is referring to “”, which doesn’t always exist on Windows at the time the file is compiled. The CoreGraphicsSPI.h file lives in “WebCore/platform/spi/cg/CoreGraphicsSPI.h”, and can be found with a normal ‘#include “CoreGraphicsSPI.h”. It’s only after a

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Brent Fulgham
Aside from ews206 being offline for some reason, all bot seem to be running without any errors. Can you point me at a couple of the patches you were looking at? I spot-checked a couple in the Review Queue and they seemed to be failing for legitimate problems with the patches. Thanks, -Brent

Re: [webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Brent Fulgham
Looking now. -Brent > On Mar 30, 2016, at 9:02 AM, Darin Adler wrote: > > Every patch I look at has a red bubble for Windows on EWS. Is someone > planning on fixing this? > > — Darin > ___ > webkit-dev mailing list >

[webkit-dev] Is someone going to fix Windows EWS?

2016-03-30 Thread Darin Adler
Every patch I look at has a red bubble for Windows on EWS. Is someone planning on fixing this? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev