[webkit-dev] Issue Analysis:48290 [HTML Canvas globalCompositeOperation]

2011-06-01 Thread Karthik
Hi All, I was going through the bug https://bugs.webkit.org/show_bug.cgi?id=48290, which passes is FF but fails in Safari/Winlauncher( r87771). As per http://www.w3.org/TR/2011/WD-2dcontext-20110525/#compositing, highlight is NOT a valid composite operation. but it is being mentioned in

Re: [webkit-dev] Issue Analysis:48290 [HTML Canvas globalCompositeOperation]

2011-06-01 Thread Darin Adler
On May 31, 2011, at 11:49 PM, Karthik wrote: However, the following comment was mentioned in GraphicsType.h (// Note: These constants exactly match the NSCompositeOperator constants of // AppKit on Mac OS X Tiger. If these ever change, we'll need to change the // Mac OS X Tiger

Re: [webkit-dev] Issue Analysis:48290 [HTML Canvas globalCompositeOperation]

2011-06-01 Thread Mustafizur Rahaman
Hi Darin, Thanks for your detailed explanation. Initially we decided to remove the string as well the enum to fix this issue. But Karthik's patch (we have already submitted the patch in https://bugs.webkit.org/show_bug.cgi?id=48290) caused a Chromium build issue then we found that this enum is

Re: [webkit-dev] Issue Analysis:48290 [HTML Canvas globalCompositeOperation]

2011-06-01 Thread Darin Adler
On Jun 1, 2011, at 10:14 AM, Mustafizur Rahaman wrote: Therefore, we submitted another patch where we are returning from the canvas code itself if the compositing mode is highlight. That’s not a good idea. We should keep looking into the real fix; that kind of hack is unneeded here.