Re: [webkit-dev] New Rich Text Editing Test suite

2010-10-06 Thread Roland Steiner
Hi Ryosuke, looking closer at RTE2-AC_JF_TEXT-1_SC it seems to actually pass on my Chrome Mac build (but it doesn't generate a )?!): Result: foo^bar Chromium7.0.547.0 (Developer Build ) WebKit534.10 V82.4.8 did you make any changes, or are you looking at a different build? Cheers, - Roland O

Re: [webkit-dev] New Rich Text Editing Test suite

2010-10-04 Thread Roland Steiner
I don't have a ToT WebKit browser ATM, but I'll check once I updated and compiled. FWIW, this seems to be a regression anyways, since release Chromium (Chrome 6.0) at least passes all those tests, without extra (?) Cheers, - Roland On Sat, Oct 2, 2010 at 5:07 AM, Ryosuke Niwa wrote: > Howev

Re: [webkit-dev] New Rich Text Editing Test suite

2010-10-04 Thread Roland Steiner
On Sat, Oct 2, 2010 at 5:14 AM, Ryosuke Niwa wrote: > I also noticed: > > RTE2-CC_FN:a_FONTf:a-1_SI fontname 'courier' y y y y FAIL face="arial">foo[bar]baz foo[bar]baz face="arial">foo[bar]baz Change existing font > name to same font name, using CSS styling (should be noop) > > Isn't supposed

Re: [webkit-dev] New Rich Text Editing Test suite

2010-10-01 Thread Ryosuke Niwa
Yay! http://trac.webkit.org/changeset/68904 fixed the last failing tests in queryCommandState & queryCommandIndeterminate. Now we pass all the sub tests. - Ryosuke On Fri, Oct 1, 2010 at 2:04 PM, Ryosuke Niwa wrote: > I think we shouldn't be hard-coding 18px here: > > {'value': '18px', 'pad':

Re: [webkit-dev] New Rich Text Editing Test suite

2010-10-01 Thread Ryosuke Niwa
I think we shouldn't be hard-coding 18px here: {'value': '18px', 'pad': '[foobarbaz]', 'expected': ['[foobarbaz]', '[foobarbaz]'], 'command': 'fontsize', 'id': 'FS:18px_SPANs:fs:l-1_SW', 'desc': 'Change existing font size to equivalent px size (should be noop, or change unit)'} The pixel font val

Re: [webkit-dev] New Rich Text Editing Test suite

2010-10-01 Thread Ryosuke Niwa
I also noticed: RTE2-CC_FN:a_FONTf:a-1_SI fontname 'courier' y y y y FAIL foo[bar]baz foo[bar]baz foo[bar]baz Change existing font name to same font name, using CSS styling (should be noop) Isn't supposed to be fontname 'arial' instead? There are 4 other tests below this one with the seemingly t

Re: [webkit-dev] New Rich Text Editing Test suite

2010-10-01 Thread Ryosuke Niwa
However, we pass JustifyLeft, JustifyRight, JustifyCenter even though we also add BR in those cases. I don't quite understand the difference there... - Ryosuke On Thu, Sep 30, 2010 at 6:58 PM, Roland Steiner wrote: > On Fri, Oct 1, 2010 at 10:49 AM, Ryosuke Niwa wrote: > >> Mn... I realized so

Re: [webkit-dev] New Rich Text Editing Test suite

2010-09-30 Thread Roland Steiner
First Blood! ^_- Roland On Fri, Oct 1, 2010 at 11:26 AM, Ryosuke Niwa wrote: > But thanks to your test suite, I noticed some very embarrassing fact: > https://bugs.webkit.org/show_bug.cgi?id=46954 > > - Ryosuke > > > On Thu, Sep 30, 2010 at 6:58 PM, Roland Steiner > wrote: > >> On Fri, Oct 1,

Re: [webkit-dev] New Rich Text Editing Test suite

2010-09-30 Thread Ryosuke Niwa
But thanks to your test suite, I noticed some very embarrassing fact: https://bugs.webkit.org/show_bug.cgi?id=46954 - Ryosuke On Thu, Sep 30, 2010 at 6:58 PM, Roland Steiner wrote: > On Fri, Oct 1, 2010 at 10:49 AM, Ryosuke Niwa wrote: > >> Mn... I realized something strange here. >> >> RTE2-AC

Re: [webkit-dev] New Rich Text Editing Test suite

2010-09-30 Thread Roland Steiner
On Fri, Oct 1, 2010 at 10:49 AM, Ryosuke Niwa wrote: > Mn... I realized something strange here. > > RTE2-AC_JF_TEXT-1_SC fails on WebKit TOT and the test is: JustifyFull on > "foo^bar". However, it clearly works on WebKit when I test it manually. It > generates foobar. I'm not sure > why the t

Re: [webkit-dev] New Rich Text Editing Test suite

2010-09-30 Thread Roland Steiner
On Fri, Oct 1, 2010 at 10:27 AM, Ryosuke Niwa wrote: > Great. I'm getting get 500 on the results page but is this because it's > still beta? > Good question - shouldn't happen. Have to ping Lindsey to see what the problem is... :( Cheers, - Roland _

Re: [webkit-dev] New Rich Text Editing Test suite

2010-09-30 Thread Ryosuke Niwa
Mn... I realized something strange here. RTE2-AC_JF_TEXT-1_SC fails on WebKit TOT and the test is: JustifyFull on "foo^bar". However, it clearly works on WebKit when I test it manually. It generates foobar. I'm not sure why the test claims that WebKit fails on this particular test. Best, Ryosu

Re: [webkit-dev] New Rich Text Editing Test suite

2010-09-30 Thread Ryosuke Niwa
On Thu, Sep 30, 2010 at 2:30 AM, Roland Steiner wrote: > > As a lot of folks here can probably attest to (Hi, Ryosuke! ;) ), the > current state of rich text editing amongst various browsers is not ideal. > WebKit is better than most, but still not perfect, either. > Hi, Roland! In order to docum

[webkit-dev] New Rich Text Editing Test suite

2010-09-30 Thread Roland Steiner
[Apologies if you have seen this already!] Hi all, As a lot of folks here can probably attest to (Hi, Ryosuke! ;) ), the current state of rich text editing amongst various browsers is not ideal. WebKit is better than most, but still not perfect, either. In order to document this and provide a g