Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

> On Sep 17, 2018, at 1:41 PM, Darin Adler wrote: > > Sent from my iPhone > >> On Sep 17, 2018, at 10:21 AM, Filip Pizlo wrote: >> >> Sorry, I should have asked: does it even rebuild when you change nothing? > > I don’t know what it’s doing, only how long it takes. My test was to build > a

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

Sent from my iPhone > On Sep 17, 2018, at 10:21 AM, Filip Pizlo wrote: > > Sorry, I should have asked: does it even rebuild when you change nothing? I don’t know what it’s doing, only how long it takes. My test was to build and then build again. In many cases I am only changing a source file f

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

> On Sep 17, 2018, at 10:36 AM, Keith Miller wrote: > > IIRC, it spends a bunch of time in the offline assembler ruby scripts. AFAIK, > those scripts only depend on the LowLevelInterpreter*.asm files. We’re talking about the offset extractor binary, which depends on most of JSC’s and WTF’s he

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

IIRC, it spends a bunch of time in the offline assembler ruby scripts. AFAIK, those scripts only depend on the LowLevelInterpreter*.asm files. So we should only need to run it if those files have changed. Or, for the assembly generation half, if there is also a new object offsets binary (from L

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

Sorry, I should have asked: does it even rebuild when you change nothing? That llint step really does depend on most headers in WTF and JSC, so if you change any of them then I would expect a rebuild of that file. It may be that the right solution is to make that step faster and to make it possi

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

I don’t know. Sent from my iPhone > On Sep 17, 2018, at 7:49 AM, Filip Pizlo wrote: > > > >> On Sep 16, 2018, at 8:48 PM, Darin Adler wrote: >> >>> On Sep 16, 2018, at 5:59 PM, Filip Pizlo wrote: >>> >>> Which offline assembler build step are you referring to? >> >> The one that is the

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

> On Sep 16, 2018, at 8:48 PM, Darin Adler wrote: > >> On Sep 16, 2018, at 5:59 PM, Filip Pizlo wrote: >> >> Which offline assembler build step are you referring to? > > The one that is the “Offline Assembler” target in Xcode, which runs this > command: > > ruby JavaScriptCore/offlineasm/a

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

> On Sep 16, 2018, at 5:59 PM, Filip Pizlo wrote: > > Which offline assembler build step are you referring to? The one that is the “Offline Assembler” target in Xcode, which runs this command: ruby JavaScriptCore/offlineasm/asm.rb JavaScriptCore/llint/LowLevelInterpreter.asm "${BUILT_PRODUCT

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

> On Sep 16, 2018, at 4:03 PM, Darin Adler wrote: > > I noticed that the “Offline Assembler” build step was taking between 5 and 30 > seconds every time I build. Really stands out in incremental builds. I > realized that this step does not do any dependency analysis. Every time, it > builds

Re: [webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

Darin, I can take a look at this. Filed > “Offline assembler always computes hashes even when nothing changes" - Michael > On Sep 16, 2018, at 4:03 PM, Darin Adler > wrote:

[webkit-dev] Offline Assembler build step always computes hashes even when nothing changes

I noticed that the “Offline Assembler” build step was taking between 5 and 30 seconds every time I build. Really stands out in incremental builds. I realized that this step does not do any dependency analysis. Every time, it builds a hash of the input to see if it needs to recompute the assembly