Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-14 Thread Dean Jackson
On 14 Feb 2014, at 12:17 am, Sergio Villar Senin wrote: > En 11/02/14 21:04, Maciej Stachowiak escribiu: Why not enabling the feature entirely on trunk? (and disable it when shipping product by disabling the compile time flag?). I think feature doing that tends to become sta

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-14 Thread Sergio Villar Senin
En 11/02/14 21:04, Maciej Stachowiak escribiu: >> > >> > Why not enabling the feature entirely on trunk? (and disable it when >> > shipping product by disabling the compile time flag?). >> > I think feature doing that tends to become stable a lot quicker. > Occasionally a feature is so experimenta

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-11 Thread Maciej Stachowiak
On Feb 11, 2014, at 10:25 AM, Benjamin Poulain wrote: > On 2/11/14, 9:26 AM, Maciej Stachowiak wrote: >> On Feb 10, 2014, at 1:38 PM, Benjamin Poulain >> wrote: >>> >>> Can't we add a compile time flag instead? The chromium patch you >>> linked is inelegant and it touches some hot paths. >>>

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-11 Thread Benjamin Poulain
On 2/11/14, 9:26 AM, Maciej Stachowiak wrote: > On Feb 10, 2014, at 1:38 PM, Benjamin Poulain > wrote: >> >> Can't we add a compile time flag instead? The chromium patch you >> linked is inelegant and it touches some hot paths. >> >> Another advantage of compile time flag is Andreas eventually n

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-11 Thread Maciej Stachowiak
On Feb 10, 2014, at 1:38 PM, Benjamin Poulain wrote: > > Can't we add a compile time flag instead? > The chromium patch you linked is inelegant and it touches some hot paths. > > Another advantage of compile time flag is Andreas eventually notice when they > become useless and remove all the

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-11 Thread Sergio Villar Senin
En 10/02/14 21:55, Maciej Stachowiak escribiu: >> The question is whether this is an acceptable behavior or not, and how >> to fix it in case we don't like it. I guess it's safe to conclude that >> it isn't something that we want in general, as it might confuse web >> authors (they see the how pro

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-11 Thread Manuel Rego Casasnovas
On Mon, 2014-02-10 at 13:38 -0800, Benjamin Poulain wrote: > Can't we add a compile time flag instead? > The chromium patch you linked is inelegant and it touches some hot paths. BTW, only with the compile flag the issue is not completely fixed. For example you can enable the compile flag but dis

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-10 Thread Sergio Villar Senin
En 10/02/14 22:38, Benjamin Poulain escribiu: > On 2/10/14, 10:40 AM, Sergio Villar Senin wrote: >> The question is whether this is an acceptable behavior or not, and how >> to fix it in case we don't like it. I guess it's safe to conclude that >> it isn't something that we want in general, as it m

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-10 Thread Benjamin Poulain
On 2/10/14, 10:40 AM, Sergio Villar Senin wrote: I'm sending this to the list because it might affect different components inside the project. So as smfr correctly reported here[1] for all those features that don't have a feature flag (like grid layout) we're web-exposing the CSS properties of t

Re: [webkit-dev] On web-exposing features disabled at runtime

2014-02-10 Thread Maciej Stachowiak
On Feb 10, 2014, at 10:40 AM, Sergio Villar Senin wrote: > Hi folks, > > I'm sending this to the list because it might affect different > components inside the project. > > So as smfr correctly reported here[1] for all those features that don't > have a feature flag (like grid layout) we're we

[webkit-dev] On web-exposing features disabled at runtime

2014-02-10 Thread Sergio Villar Senin
Hi folks, I'm sending this to the list because it might affect different components inside the project. So as smfr correctly reported here[1] for all those features that don't have a feature flag (like grid layout) we're web-exposing the CSS properties of the feature even if it's disabled at runt