Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-11-12 Thread Maciej Stachowiak via webkit-dev
> On Oct 17, 2020, at 10:00 AM, Sam Weinig wrote: > > Hi webkit-dev, > > I’d like to propose, and gauge feedback on, reducing (with the goal of > ultimately removing) the use of Makefile based DerivedSources.make. > > My understanding is that currently only the Xcode based ports still use >

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Darin Adler
> On Oct 20, 2020, at 4:08 PM, Sam Weinig wrote: > > For the ones conditionalizing adding to ADDITIONAL_BINDING_IDLS, those IDLs > should just have the appropriate Conditional=* extended attribute added, then > they can be included unconditionally in the makefile. > > For the ones conditionali

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Sam Weinig
> On Oct 20, 2020, at 3:36 PM, Darin Adler wrote: > >> On Oct 20, 2020, at 3:09 PM, Sam Weinig wrote: >> >> For the Platform.h issue, I think we could probably engineer things in the >> short term to have a script phase that produces a Defines.txt that the other >> script phases and build r

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Darin Adler
> On Oct 20, 2020, at 3:09 PM, Sam Weinig wrote: > > For the Platform.h issue, I think we could probably engineer things in the > short term to have a script phase that produces a Defines.txt that the other > script phases and build rules depend on. We definitely can, and it’s simpler than how

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Sam Weinig
> On Oct 20, 2020, at 2:25 PM, Keith Rollin wrote: > >> On Oct 20, 2020, at 10:51, Andy Estes wrote: >> >>> On Oct 18, 2020, at 11:01, Sam Weinig wrote: >>> >>> One direct benefit of moving away from DerivedSources.make would likely be >>> (I say likely, as the details of how it works out

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Keith Rollin
> On Oct 20, 2020, at 10:51, Andy Estes wrote: > >> On Oct 18, 2020, at 11:01, Sam Weinig wrote: >> >> One direct benefit of moving away from DerivedSources.make would likely be >> (I say likely, as the details of how it works out are far from certain in my >> mind) removing at least one plac

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Andy Estes
Hi Sam, > On Oct 18, 2020, at 11:01, Sam Weinig wrote: > > One direct benefit of moving away from DerivedSources.make would likely be (I > say likely, as the details of how it works out are far from certain in my > mind) removing at least one place that a IDL file needs to be listed as we > w

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-18 Thread Sam Weinig
One direct benefit of moving away from DerivedSources.make would likely be (I say likely, as the details of how it works out are far from certain in my mind) removing at least one place that a IDL file needs to be listed as we would not need to explicitly the list the IDL file in DerivedSources.

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-18 Thread Darin Adler
It would be wonderful to drastically cut down the repeated mentions of the same filenames. People not on Xcode platforms probably focus primarily on Xcode projects for this frustration. But I find it ridiculous how many places I have to add things. For example, to add AbstractRange I had to add

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-18 Thread Darin Adler
Oops, I was in the middle of writing this and hit send by mistake ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-18 Thread Darin Adler
Please note that this is a Cocoa-only, Xcode-only conversation. As Sam pointed out, there’s a whole different “will you please switch to CMake” conversation. That’s not an easy switch to make for programmers working on the Apple platforms, but we might do it at some point if we can work out the

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-18 Thread Sam Weinig
> On Oct 17, 2020, at 12:34 PM, Fujii Hironori > wrote: > > > On Sun, Oct 18, 2020 at 2:00 AM Sam Weinig > wrote: > > What are your thoughts on this? > > I'm disappointed. I want to use CMake for all ports. I hear you, it would i

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-18 Thread Ryosuke Niwa
On Sat, Oct 17, 2020 at 10:00 AM Sam Weinig wrote: > > Hi webkit-dev, > > I’d like to propose, and gauge feedback on, reducing (with the goal of > ultimately removing) the use of Makefile based DerivedSources.make. > > My understanding is that currently only the Xcode based ports still use > Der

Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-17 Thread Fujii Hironori
On Sun, Oct 18, 2020 at 2:00 AM Sam Weinig wrote: > > What are your thoughts on this? > I'm disappointed. I want to use CMake for all ports. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-17 Thread Sam Weinig
Hi webkit-dev, I’d like to propose, and gauge feedback on, reducing (with the goal of ultimately removing) the use of Makefile based DerivedSources.make. My understanding is that currently only the Xcode based ports still use DerivedSources.make, as all the CMake based ones have moved derived s