Re: [webkit-dev] Remove underscore check in check-webkit-style?

2010-01-21 Thread Jedrzej Nowacki
On Thursday 14. January 2010 12.49.40 ext Kenneth Christiansen wrote: In Qt we only allow underscored in methods that start with qt_ and they are used for private API, such as for the DRT and for API that we havent had the time to API review, but are still needed by some other software

Re: [webkit-dev] Remove underscore check in check-webkit-style?

2010-01-14 Thread Kenneth Christiansen
In Qt we only allow underscored in methods that start with qt_ and they are used for private API, such as for the DRT and for API that we havent had the time to API review, but are still needed by some other software products. Kenneth On Wed, Jan 13, 2010 at 9:32 PM, Darin Fisher

Re: [webkit-dev] Remove underscore check in check-webkit-style?

2010-01-14 Thread Chris Jerdonek
Date: Wed, 13 Jan 2010 15:49:05 -0800 From: David Levin le...@google.com 3) Stop checking code in gtk/qt platform directories for underscores? I think there are several other checks that code in some of these directories typically fail due to various issues (public api that should follow

[webkit-dev] Remove underscore check in check-webkit-style?

2010-01-13 Thread Adam Barth
Current check-webkit-style and the style bot complain if code uses identifiers with underscores in their names. It turns out our code does this fairly often, especially in Qt and Gtk specific code, for example to interface with unit testing frameworks. We could either: 1) Teach

Re: [webkit-dev] Remove underscore check in check-webkit-style?

2010-01-13 Thread Evan Martin
On Wed, Jan 13, 2010 at 3:43 PM, Adam Barth aba...@webkit.org wrote: Current check-webkit-style and the style bot complain if code uses identifiers with underscores in their names.  It turns out our code does this fairly often, especially in Qt and Gtk specific code, for example to interface

Re: [webkit-dev] Remove underscore check in check-webkit-style?

2010-01-13 Thread Darin Fisher
On Wed, Jan 13, 2010 at 4:17 PM, Evan Martin e...@chromium.org wrote: On Wed, Jan 13, 2010 at 3:43 PM, Adam Barth aba...@webkit.org wrote: Current check-webkit-style and the style bot complain if code uses identifiers with underscores in their names. It turns out our code does this fairly