Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth wrote: > On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa wrote: >> >> Are you referring to things like JSValueRef? If JS* functions are >> supposed to be tested in DumpRenderTree, then that's a good argument >> against this approach. >> > > JavaScriptCore

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Jun 4, 2012, at 11:07 AM, Adam Barth wrote: > On Mon, Jun 4, 2012 at 10:51 AM, Sam Weinig wrote: > On Jun 3, 2012, at 6:10 PM, Ryosuke Niwa wrote: >> On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth wrote: >> On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa wrote: >> On Sun, Jun 3, 2012 at 5:33 PM,

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Mon, Jun 4, 2012 at 10:51 AM, Sam Weinig wrote: > On Jun 3, 2012, at 6:10 PM, Ryosuke Niwa wrote: > > On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth wrote: > >> On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa wrote: >> >>> On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak wrote: On Jun

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Jun 3, 2012, at 6:10 PM, Ryosuke Niwa wrote: > On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth wrote: > On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa wrote: > On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak wrote: > On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa wrote: >> On Sun, Jun 3, 2012 at 3:5

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On 06/04/2012 03:10 AM, Ryosuke Niwa wrote: On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth > wrote: On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa mailto:rn...@webkit.org>> wrote: On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak mailto:m...@apple.com>> w

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Sun, Jun 3, 2012 at 6:01 PM, Adam Barth wrote: > On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa wrote: > >> On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak wrote: >>> >>> On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa wrote: >>> >>> On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak wrote: >>> >>

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Sun, Jun 3, 2012 at 5:54 PM, Ryosuke Niwa wrote: > On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak wrote: >> >> On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa wrote: >> >> On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak wrote: >> >>> I am on vacation so I won't be able to review your patch in

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Sun, Jun 3, 2012 at 5:33 PM, Maciej Stachowiak wrote: > > On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa wrote: > > On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak wrote: > >> I am on vacation so I won't be able to review your patch in detail, but >> from your description it sounds less appealing

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

Sent from my iPad On Jun 3, 2012, at 8:05 PM, Ryosuke Niwa wrote: > On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak wrote: > I am on vacation so I won't be able to review your patch in detail, but from > your description it sounds less appealing to me than the WKTR approach. It > seems li

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Sun, Jun 3, 2012 at 3:55 PM, Maciej Stachowiak wrote: > I am on vacation so I won't be able to review your patch in detail, but > from your description it sounds less appealing to me than the WKTR > approach. It seems like bad layering to me to define the IDL interface in > WebCore for somethi

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

I am on vacation so I won't be able to review your patch in detail, but from your description it sounds less appealing to me than the WKTR approach. It seems like bad layering to me to define the IDL interface in WebCore for something actually implemented completely outside of WebCore. It also s

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Sun, Jun 3, 2012 at 1:45 PM, Maciej Stachowiak wrote: > Already done for the WebKit2 WebKitTestRunner. It should be > straightforward to adapt its IDL compiler. > I've considered adapting WebKitTestRunner's code generator, but it appeared quite tricky because ports don't share much code in Du

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

Already done for the WebKit2 WebKitTestRunner. It should be straightforward to adapt its IDL compiler. - Maciej On Jun 2, 2012, at 11:03 PM, Adam Barth wrote: > We might also want to define the layoutTestController object with IDL > so we don't have to hand-write bindings every time we change

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Sat, Jun 2, 2012 at 8:04 PM, Ryosuke Niwa wrote: > On Sat, Jun 2, 2012 at 8:03 PM, Adam Barth wrote: > >> We might also want to define the layoutTestController object with IDL >> so we don't have to hand-write bindings every time we change it. >> Using IDL for window.internals seems to have w

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

On Sat, Jun 2, 2012 at 8:03 PM, Adam Barth wrote: > We might also want to define the layoutTestController object with IDL > so we don't have to hand-write bindings every time we change it. > Using IDL for window.internals seems to have worked out well. It > would be nice to replicate that succes

Re: [webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

We might also want to define the layoutTestController object with IDL so we don't have to hand-write bindings every time we change it. Using IDL for window.internals seems to have worked out well. It would be nice to replicate that success with layoutTestController. Adam On Sat, Jun 2, 2012 at

[webkit-dev] Renaming DumpRenderTree to WebKitTestRunner or merging those two

Hi, One thing that has annoyed me ever since I started working on WebKit is that our test runner is called DumpRenderTree. We fixed this problem in WebKit2 by renaming it to WebKitTestRunner but we've still got DumpRenderTree in WebKit1 land. Can we either rename DumpRenderTree to WebKitTestRunne