I'm implementing a patch for [1], namely to support the CSS3 line-break
property.
[1] https://bugs.webkit.org/show_bug.cgi?id=89235
There is an older -{khtml,webkit}-line-break enum EKHTMLLineBreak defined
in RenderStyleConstants.h. I see that some enums use a 'E' prefix, while
others do not,
E is an old style from KHTML.
We should update our style guide to say more than it does. :)
Enum members should user InterCaps with an initial capital letter.
[names-enum-members]
On Thu, Aug 23, 2012 at 11:53 PM, Glenn Adams gl...@skynav.com wrote:
I'm implementing a patch for [1], namely to
Sorry, I was unclear. I haven't seen someone create a new enum using
E in years. LineBreakType or similar would be better than
ELineBreakType.
On Thu, Aug 23, 2012 at 11:57 PM, Eric Seidel e...@webkit.org wrote:
E is an old style from KHTML.
We should update our style guide to say more than
On Fri, Aug 24, 2012 at 3:06 PM, Glenn Adams gl...@skynav.com wrote:
[or if there is a name conflict on LineBreak, then will use LineBreakType]
(whether the suffice 'Type' is included also seems somewhat irregular)
s/suffice/suffix/
___
webkit-dev
4 matches
Mail list logo