16.09.2010, в 18:39, Darin Fisher написал(а):
Push the publish button to review your comments :-)
Alas, not any more!
https://bugs.webkit.org/show_bug.cgi?id=46074
- WBR, Alexey Proskuryakov
___
webkit-dev mailing list
On Mon, Sep 20, 2010 at 8:37 AM, Alexey Proskuryakov a...@webkit.org wrote:
16.09.2010, в 18:39, Darin Fisher написал(а):
Push the publish button to review your comments :-)
Alas, not any more!
https://bugs.webkit.org/show_bug.cgi?id=46074
Yeah. The machinery is still there for the
On Mon, Sep 20, 2010 at 10:10 AM, Adam Barth aba...@webkit.org wrote:
On Mon, Sep 20, 2010 at 8:37 AM, Alexey Proskuryakov a...@webkit.org
wrote:
16.09.2010, в 18:39, Darin Fisher написал(а):
Push the publish button to review your comments :-)
Alas, not any more!
On Sep 20, 2010, at 10:22 AM, Darin Fisher wrote:
How about this?
If any annotations were made to the patch, then the button gets named
Preview. Else, the button is named Publish and when clicked performs its
work in one shot.
Was there a strong outcry for removing the preview step?
On Sep 20, 2010, at 10:22 AM, Darin Fisher wrote:
On Mon, Sep 20, 2010 at 10:10 AM, Adam Barth aba...@webkit.org wrote:
On Mon, Sep 20, 2010 at 8:37 AM, Alexey Proskuryakov a...@webkit.org wrote:
16.09.2010, в 18:39, Darin Fisher написал(а):
Push the publish button to review your comments
I really would like to be able to select some text and add a comment that uses
the selection as context, a single line of context is frequently insufficient,
this is about the only thing that still makes the new review tool less
effective than the old review mechanism (for me at least).
On Sep 20, 2010, at 2:34 PM, Oliver Hunt wrote:
I really would like to be able to select some text and add a comment that
uses the selection as context, a single line of context is frequently
insufficient, this is about the only thing that still makes the new review
tool less effective
On Sep 20, 2010, at 11:36 AM, Adam Roben wrote:
On Sep 20, 2010, at 2:34 PM, Oliver Hunt wrote:
I really would like to be able to select some text and add a comment that
uses the selection as context, a single line of context is frequently
insufficient, this is about the only thing that
On Sep 17, 2010, at 6:38 AM, Mike Pinkerton pinker...@chromium.org wrote:
On Fri, Sep 17, 2010 at 2:39 AM, Adam Barth aba...@webkit.org wrote:
The tool has some problems on iPad. The issue is the bottom toolbar
uses position: fixed, which seems to be frozen to the initial viewport
on iPad.
On Thu, Sep 16, 2010 at 5:33 PM, Darin Adler da...@apple.com wrote:
3) I suggest you make your review tool the default at ...action=review
and move the old style review tool to another URL; we can put a link in yours.
I've moved the new tool from Pretty Diff to Review Patch. Let me know
if
On Thu, Sep 16, 2010 at 5:33 PM, Darin Adler da...@apple.com wrote:
1) I am happy with the review tool. I have been using it for a lot of
reviews. There may be no one left who prefers the old review page.
Thanks. Please let me know if you have ideas for how to improve the
tool. One thing
On Fri, Sep 17, 2010 at 4:39 PM, Adam Barth aba...@webkit.org wrote:
On Thu, Sep 16, 2010 at 5:33 PM, Darin Adler da...@apple.com wrote:
1) I am happy with the review tool. I have been using it for a lot of
reviews. There may be no one left who prefers the old review page.
Thanks.
On Fri, Sep 17, 2010 at 12:05 AM, Alexey Proskuryakov a...@webkit.org wrote:
16.09.2010, в 23:39, Adam Barth написал(а):
As mentioned above, the publish button actually brings up a
confirmation screen. My original plan was to eventually remove the
confirmation screen, since it's fully
I just want to say that I absolutely love the new review tool and the
ability to select multiply lines of contents!
Kenneth
On Fri, Sep 17, 2010 at 4:11 AM, Darin Fisher da...@chromium.org wrote:
On Fri, Sep 17, 2010 at 12:05 AM, Alexey Proskuryakov a...@webkit.org wrote:
16.09.2010, в 23:39,
On Thu, Sep 16, 2010 at 11:58 PM, Ojan Vafai o...@chromium.org wrote:
On Fri, Sep 17, 2010 at 4:39 PM, Adam Barth aba...@webkit.org wrote:
On Thu, Sep 16, 2010 at 5:33 PM, Darin Adler da...@apple.com wrote:
1) I am happy with the review tool. I have been using it for a lot of
reviews.
Hi Adam.
A few thoughts on the review tools on bugs.webkit.org.
1) I am happy with the review tool. I have been using it for a lot of
reviews. There may be no one left who prefers the old review page.
2) It’s kind of crazy that the review tool’s URL is
...action=prettypatch. It was
On Fri, Sep 17, 2010 at 10:33 AM, Darin Adler da...@apple.com wrote:
2) It’s kind of crazy that the review tool’s URL is
...action=prettypatch. It was nice of you to leave the old review tool
unchanged, at least in part to placate me, but you’re squatting on another
feature’s territory! I
16.09.2010, в 17:33, Darin Adler написал(а):
1) I am happy with the review tool. I have been using it for a lot of
reviews. There may be no one left who prefers the old review page.
It's only now that I realized there's a new review tool at action=prettypatch
:-)
Is there a way to
Push the publish button to review your comments :-)
On Sep 16, 2010 6:36 PM, Alexey Proskuryakov a...@webkit.org wrote:
16.09.2010, в 17:33, Darin Adler написал(а):
1) I am happy with the review tool. I have been using it for a lot of
reviews. There may be no one left who prefers the old
19 matches
Mail list logo
