Re: [webkit-dev] SVG cloneNode?

2010-06-30 Thread Fady Samuel
I have just added a bugzilla bug: https://bugs.webkit.org/show_bug.cgi?id=41421 I looked at SVGAnimatedProperty.h briefly but I can't think of a clever way to modify it so that there's a nice, general way to copy these animated attributes to the cloned node. I believe a bunch of files will need t

Re: [webkit-dev] SVG cloneNode?

2010-06-30 Thread Darin Adler
As I see it, the issue shown in your test case is that cloning animated attributes does not clone the animation parameters. That’s something we will need to solve. We should not solve it by overriding copyNonAttributeProperties and hand-writing it in each class. I don’t know enough about the SV

Re: [webkit-dev] SVG cloneNode?

2010-06-30 Thread Simon Fraser
Is there a bugzilla bug for this? If not, there should be. Simon On Jun 30, 2010, at 10:47 AM, Fady Samuel wrote: > Hi Darin, > > I've attached a sample html file that creates an ellipse and then clones it. > The cx, cy, rx, ry properties are not cloned and so we do not see the second > ellip

Re: [webkit-dev] SVG cloneNode?

2010-06-30 Thread Fady Samuel
Hi Darin, I've attached a sample html file that creates an ellipse and then clones it. The cx, cy, rx, ry properties are not cloned and so we do not see the second ellipse. Fady On Wed, Jun 30, 2010 at 1:41 PM, Darin Adler wrote: > On Jun 30, 2010, at 10:38 AM, Fady Samuel wrote: > > > Styled

Re: [webkit-dev] SVG cloneNode?

2010-06-30 Thread Darin Adler
On Jun 30, 2010, at 10:38 AM, Fady Samuel wrote: > StyledElment's void copyNonAttributeProperties(const Element *sourceElement) > for every single SVG node. Do you think this is the case or is there a nicer > way to do this that doesn't involve my modifying 100+ files? Generally speaking clonin

Re: [webkit-dev] SVG cloneNode?

2010-06-30 Thread Fady Samuel
Sorry for the premature send. StyledElment's void copyNonAttributeProperties(const Element *sourceElement) for every single SVG node. Do you think this is the case or is there a nicer way to do this that doesn't involve my modifying 100+ files? Thanks, Fady On Wed, Jun 30, 2010 at 1:36 PM, Fady

[webkit-dev] SVG cloneNode?

2010-06-30 Thread Fady Samuel
So I'm looking at cloning SVG nodes in Javascript, and it's looking to me like SVG-specific properties aren't copied on cloning. I don't see SVG properties being stored in an attribute or property map, which suggests to me I'm going to need to modify every single SVG node class, overriding StyledEl