Re: [webkit-dev] SVG pixel test failures (recent regressions?)

2009-01-26 Thread Pierre-Olivier Latour
Just commited a fix - hopefully, it's good this time :) On Jan 26, 2009, at 10:52 AM, David Hyatt wrote: On Jan 26, 2009, at 12:02 PM, Darin Adler wrote: On Jan 26, 2009, at 9:58 AM, David Hyatt wrote: Yes. I'd have done it myself, but I have Perian installed. run- webkit-tests is refusin

Re: [webkit-dev] SVG pixel test failures (recent regressions?)

2009-01-26 Thread David Hyatt
On Jan 26, 2009, at 12:02 PM, Darin Adler wrote: On Jan 26, 2009, at 9:58 AM, David Hyatt wrote: Yes. I'd have done it myself, but I have Perian installed. run- webkit-tests is refusing to allow me to generate new pixel test results (despite the fact that Perian affects only tests that use

Re: [webkit-dev] SVG pixel test failures (recent regressions?)

2009-01-26 Thread Darin Adler
On Jan 26, 2009, at 9:58 AM, David Hyatt wrote: Yes. I'd have done it myself, but I have Perian installed. run- webkit-tests is refusing to allow me to generate new pixel test results (despite the fact that Perian affects only tests that use or Quicktime). Hopefully that pointless restri

Re: [webkit-dev] SVG pixel test failures (recent regressions?)

2009-01-26 Thread David Hyatt
On Jan 26, 2009, at 3:58 AM, Darin Adler wrote: This is a progression. Stuff that used to be incorrectly not painted is now being painted. Excellent! So we just have to generate new results for that one. I'll do that now. Yes. I'd have done it myself, but I have Perian installed. run-

Re: [webkit-dev] SVG pixel test failures (recent regressions?)

2009-01-26 Thread Darin Adler
On Jan 26, 2009, at 1:54 AM, David Hyatt wrote: On Jan 26, 2009, at 1:56 AM, Darin Adler wrote: It looks to me like the pixel test failures are showing some real regressions; they must be recent ones. For example, take a look at this test. http://build.webkit.org/results/trunk-mac-inte

Re: [webkit-dev] SVG pixel test failures (recent regressions?)

2009-01-26 Thread David Hyatt
On Jan 26, 2009, at 1:56 AM, Darin Adler wrote: It looks to me like the pixel test failures are showing some real regressions; they must be recent ones. For example, take a look at this test. http://build.webkit.org/results/trunk-mac-intel-pixel/1625/svg/text/text-align-03-b-diffs.html

Re: [webkit-dev] SVG pixel test failures (recent regressions?)

2009-01-26 Thread Eric Seidel
By "focus rect" I of course meant "selection rects". :) And below is my original email which probably bounced from the list: On Mon, Jan 26, 2009 at 12:05 AM, Eric Seidel wrote: > The SVG stuff relates to dumping the focus rect. From the diffs it > seems that somehow the text bounding rect calc

[webkit-dev] SVG pixel test failures (recent regressions?)

2009-01-25 Thread Darin Adler
It looks to me like the pixel test failures are showing some real regressions; they must be recent ones. For example, take a look at this test. http://build.webkit.org/results/trunk-mac-intel-pixel/1625/svg/text/text-align-03-b-diffs.html Does anyone know which code change caused that c