Let's try this again now that I've resubscribed with the correct email
address:
On Wednesday 09 December 2009 07:52:22 pm Peter Kasting wrote:
You haven't really said why. The closest you got was the vague It
is also
true that the current style guidelines if
practiced pedantically in
On Thu, Dec 10, 2009 at 7:57 AM, Joe Mason jma...@rim.com wrote:
Off the top of my head as a reviewer I'd accept:
if (color.red() == 255 color.green() == 0 color.blue() ==
255) // pink!
over
if (color.red() == 255 !color.green() color.blue() == 255)
// pink!
On Thursday 10 December 2009 01:34:12 pm Peter Kasting wrote:
But if !color.green() is potentially confusing, then certainly it is just
as confusing (in fact moreso) without the surrounding color.blue() and
color.red() tests in Adam's example. Yet Adam cited consistency with
surroundings as
On Thu, Dec 10, 2009 at 11:28 AM, Adam Treat tr...@kde.org wrote:
both are confusing and in my mind call for exercising reviewer
discretion over the style guide.
And I *do not* think the
style guide is wrong for the *guide* to prefer !foo over foo == 0!
OK. Then I have no idea what your
On Thursday 10 December 2009 03:16:51 pm Peter Kasting wrote:
Yeah, I'm not sold. But oh well. I think I was getting too irked, when
really we're just both giving our opinions on how we want the style guide
to work. There's nothing wrong with having opinions, or disagreeing.
Besides, I've
Hi Adam,
On Dec 9, 2009, at 11:25 AM, Adam Treat wrote:
Yep, that does distinguish. That being said, my personal preference
would be
either to keep the current rule and change the code to meet it or
even better
just eliminate the rule altogether since the community hasn't been
following
On Dec 9, 2009, at 1:02 PM, Maciej Stachowiak wrote:
That's my thinking on the matter, perhaps others have other opinions.
Perhaps no surprise to the rest of you, but I agree with every word Maciej said.
-- Darin
___
webkit-dev mailing list
For what it's worth, I completely agree as well.
Can we take this and put it in the style guide? That way it's perfectly
clear to people under what circumstances we would consider changing it and
we can even cite specific reason numbers in the discussions?
On Wed, Dec 9, 2009 at 1:05 PM, Darin
On Wed, Dec 9, 2009 at 1:02 PM, Maciej Stachowiak m...@apple.com wrote:
That's my thinking on the matter, perhaps others have other opinions.
Regards,
Maciej
+1. Very sound rules of thumb; please preserve them somewhere! FWIW,
these are basically the principles we followed at Oracle; the only
On Wednesday 09 December 2009 04:02:07 pm Maciej Stachowiak wrote:
I have thought over your comments about not changing the style
guidelines at a whim.
I think you make a very good point: the most important thing about the
style guidelines is that there is one way to do things, and that's
At first glance these meta-guidelines seem fine. If they are going
to be written down somewhere, a couple minor comments:
On Dec 9, 2009, Maciej Stachowiak wrote:
I think something like
the following should be our meta-guidelines for when to change the
style guide:
It would be good to
On Wednesday 09 December 2009 07:03:51 pm Peter Kasting wrote:
But even what is trivial is a judgement call. In general people don't
disagree about issues where they believe disagreement is a waste of time.
...
And I don't. Who is right? More importantly, how will you prevent us from
On Wed, Dec 9, 2009 at 4:47 PM, Adam Treat tr...@kde.org wrote:
On Wednesday 09 December 2009 07:03:51 pm Peter Kasting wrote:
And I don't. Who is right? More importantly, how will you prevent us
from
starting this debate on a bug?
I won't? If you as a reviewer consider the indentation
13 matches
Mail list logo
