Re: [webkit-dev] Some landed patches have incorrect date in commit messages and ChangeLog

2010-08-09 Thread Hajime Morita
Hi, I'm sorry that I did it yesterday. Usually I use webkit-patch. But that patch had 2 bug URLs and webkit-patch didn't work for it. So I rewrote ChangeLogs - with the wrong way. If "webkit-patch land" support --bug-id, it might be helpful for my case. Thanks. -- morita On Tue, Aug 10, 2010 at 2

Re: [webkit-dev] Some landed patches have incorrect date in commit messages and ChangeLog

2010-08-09 Thread Evan Martin
On Mon, Aug 9, 2010 at 10:51 AM, Jian Li wrote: > I noticed that several patches landed recently have the incorrect date put > in the commit messages and ChangeLog. Please fix the incorrect information > in ChangeLog. For the commit messages, anyone know if we can fix them or > not? > Please make

Re: [webkit-dev] Some landed patches have incorrect date in commit messages and ChangeLog

2010-08-09 Thread Eric Seidel
Yes. The commit-queue uses svn-apply which knows how to fix the date using: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/VCSUtils.pm#L1231 -eric On Mon, Aug 9, 2010 at 2:06 PM, Fady Samuel wrote: > What about the case where between the time you submit the patch and it gets > committ

Re: [webkit-dev] Some landed patches have incorrect date in commit messages and ChangeLog

2010-08-09 Thread Fady Samuel
What about the case where between the time you submit the patch and it gets committed, a day passes by...does the commit queue fix this automatically, or does someone have to go back and fix it manually? Fady On Mon, Aug 9, 2010 at 1:51 PM, Jian Li wrote: > Hi, > > I noticed that several patche

Re: [webkit-dev] Some landed patches have incorrect date in commit messages and ChangeLog

2010-08-09 Thread Martin Robinson
On Mon, Aug 9, 2010 at 10:51 AM, Jian Li wrote: > Please make sure the correct date is used when you land your patch manually. This is one of my favorite features of webkit-patch, which seems to do the right thing at least in the case of git. Martin __

[webkit-dev] Some landed patches have incorrect date in commit messages and ChangeLog

2010-08-09 Thread Jian Li
Hi, I noticed that several patches landed recently have the incorrect date put in the commit messages and ChangeLog. Please fix the incorrect information in ChangeLog. For the commit messages, anyone know if we can fix them or not? Please make sure the correct date is used when you land your patc