Re: [webkit-dev] Thread naming policy in WebKit

2017-01-09 Thread Yusuke SUZUKI
Thank you for your suggestions! Based on our discussion, I've uploaded the patch[1] :) [1]: https://bugs.webkit.org/show_bug.cgi?id=166678 Regards, Yusuke Suzuki On Fri, Jan 6, 2017 at 2:50 PM, Yusuke SUZUKI wrote: > On Fri, Jan 6, 2017 at 2:43 PM, Maciej Stachowiak wrote: > >> >> On Jan 5, 2

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Yusuke SUZUKI
On Fri, Jan 6, 2017 at 2:43 PM, Maciej Stachowiak wrote: > > On Jan 5, 2017, at 8:07 PM, Yusuke SUZUKI wrote: > > On Fri, Jan 6, 2017 at 10:37 AM, Maciej Stachowiak wrote: > >> >> On Jan 5, 2017, at 9:37 AM, Brady Eidson wrote: >> >> >> On Jan 5, 2017, at 12:48 AM, Yusuke SUZUKI wrote: >> >>

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Maciej Stachowiak
> On Jan 5, 2017, at 8:07 PM, Yusuke SUZUKI wrote: > > On Fri, Jan 6, 2017 at 10:37 AM, Maciej Stachowiak > wrote: > >> On Jan 5, 2017, at 9:37 AM, Brady Eidson > > wrote: >> >> >>> On Jan 5, 2017, at 12:48 AM, Yusuke SUZUKI >>

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Yusuke SUZUKI
On Fri, Jan 6, 2017 at 10:37 AM, Maciej Stachowiak wrote: > > On Jan 5, 2017, at 9:37 AM, Brady Eidson wrote: > > > On Jan 5, 2017, at 12:48 AM, Yusuke SUZUKI wrote: > > On Thu, Jan 5, 2017 at 5:43 PM, Darin Adler wrote: > >> I understand the appeal of “org.webkit” and structured names but >>

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Maciej Stachowiak
> On Jan 5, 2017, at 9:37 AM, Brady Eidson wrote: > > >> On Jan 5, 2017, at 12:48 AM, Yusuke SUZUKI > > wrote: >> >> On Thu, Jan 5, 2017 at 5:43 PM, Darin Adler > > wrote: >> I understand the appeal of “org.webkit” and structured names but

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Yusuke SUZUKI
Regards, Yusuke Suzuki On Fri, Jan 6, 2017 at 5:34 AM, Yusuke SUZUKI wrote: > On Fri, Jan 6, 2017 at 2:37 AM, Brady Eidson wrote: > >> >> On Jan 5, 2017, at 12:48 AM, Yusuke SUZUKI wrote: >> >> On Thu, Jan 5, 2017 at 5:43 PM, Darin Adler wrote: >> >>> I understand the appeal of “org.webkit” a

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Yusuke SUZUKI
On Fri, Jan 6, 2017 at 2:37 AM, Brady Eidson wrote: > > On Jan 5, 2017, at 12:48 AM, Yusuke SUZUKI wrote: > > On Thu, Jan 5, 2017 at 5:43 PM, Darin Adler wrote: > >> I understand the appeal of “org.webkit” and structured names but >> personally I would prefer to read names that look like titles

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Filip Pizlo
👍 -Filip > On Jan 5, 2017, at 10:51 AM, Geoffrey Garen wrote: > > Alternatively, we could just change thread name from a char* to a struct { > char*, char* } that contains a long name and a short name. > > Geoff > >> On Jan 5, 2017, at 9:37 AM, Brady Eidson > > wro

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Geoffrey Garen
Alternatively, we could just change thread name from a char* to a struct { char*, char* } that contains a long name and a short name. Geoff > On Jan 5, 2017, at 9:37 AM, Brady Eidson wrote: > >> >> On Jan 5, 2017, at 12:48 AM, Yusuke SUZUKI > > wrote: >> >> On T

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Brady Eidson
> On Jan 5, 2017, at 12:48 AM, Yusuke SUZUKI wrote: > > On Thu, Jan 5, 2017 at 5:43 PM, Darin Adler > wrote: > I understand the appeal of “org.webkit” and structured names but personally I > would prefer to read names that look like titles and are made up of words > wi

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Brady Eidson
> On Jan 5, 2017, at 12:43 AM, Darin Adler wrote: > > I understand the appeal of “org.webkit” and structured names but personally I > would prefer to read names that look like titles and are made up of words > with spaces, like these: > > “WebKit: Image Decoder”, rather than “org.webkit.Image

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Michael Catanzaro
On Thu, 2017-01-05 at 17:48 +0900, Yusuke SUZUKI wrote: > 1. specifying "org.webkit.ImageDecoder" > 2. In Linux, we just use "ImageDecoder" part. > 3. In macOS port, we automatically convert it to "WebKit: Image > Decoder" This sounds like a good path forward that works for all platforms. It's a

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Yusuke SUZUKI
On Thu, Jan 5, 2017 at 5:43 PM, Darin Adler wrote: > I understand the appeal of “org.webkit” and structured names but > personally I would prefer to read names that look like titles and are made > up of words with spaces, like these: > > “WebKit: Image Decoder”, rather than “org.webkit.ImageDecod

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Darin Adler
I understand the appeal of “org.webkit” and structured names but personally I would prefer to read names that look like titles and are made up of words with spaces, like these: “WebKit: Image Decoder”, rather than “org.webkit.ImageDecoder”. “WebKit: JavaScript DFG Compiler” rather than “org.webk

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-04 Thread Filip Pizlo
This sounds great to me! -Filip > On Jan 4, 2017, at 20:28, Yusuke SUZUKI wrote: > > Hi WebKittens! > > Recently, I started naming threads in Linux. And I also started naming > threads created by WTF::AutomaticThread. > Previously, all the thread is not named in Linux. It makes difficult to f

[webkit-dev] Thread naming policy in WebKit

2017-01-04 Thread Yusuke SUZUKI
Hi WebKittens! Recently, I started naming threads in Linux. And I also started naming threads created by WTF::AutomaticThread. Previously, all the thread is not named in Linux. It makes difficult to find problematic threads when using GDB in Linux. For example, if you run the JSC shell, all the th