Re: [webkit-dev] Why does our std::optional lack the has_value() function?

2017-06-19 Thread Yusuke SUZUKI
Feel free to review it :) https://bugs.webkit.org/show_bug.cgi?id=173582 Regards, Yusuke Suzuki On Tue, Jun 20, 2017 at 1:48 PM, JF Bastien wrote: > Ours was imported from: https://github.com/akrzemi1/Optional > at: 727c729dd1d9f06f225868280e50154594d7e59d > > And it was

Re: [webkit-dev] Why does our std::optional lack the has_value() function?

2017-06-19 Thread JF Bastien
Ours was imported from: https://github.com/akrzemi1/Optional at: 727c729dd1d9f06f225868280e50154594d7e59d And it was subsequently added in:

Re: [webkit-dev] Why does our std::optional lack the has_value() function?

2017-06-19 Thread Yusuke SUZUKI
I think it is just missing in the original code. Seeing the original repository, we can find that these things are added. We can rebaseline our copy by applying these changes. https://github.com/akrzemi1/Optional/commits/master Regards, Yusuke Suzuki On Tue, Jun 20, 2017 at 1:45 PM, Darin

[webkit-dev] Why does our std::optional lack the has_value() function?

2017-06-19 Thread Darin Adler
I noticed we don’t have has_value() in our version of std::optional. Does anyone know why? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev