[webkit-dev] add NeedsRebaseline keyword to TestExpectations as a way to hande updating pixel tests?

2012-10-04 Thread Ojan Vafai
TL;DR: We should add a NeedsRebaseline keyword to TestExpectations and add garden-o-matic tooling for it for the cases where someone commits a change/test that they know will need new results for different ports (e.g. any patch that changes the rendering of pixel tests). A common pattern that I

Re: [webkit-dev] add NeedsRebaseline keyword to TestExpectations as a way to hande updating pixel tests?

2012-10-04 Thread Emil A Eklund
That sounds like a great idea! It is too hard to do this right today and having an easy way to indicate that a test needs to be rebaselined across some or a subset of platforms would be great. -- Emil ___ webkit-dev mailing list

Re: [webkit-dev] add NeedsRebaseline keyword to TestExpectations as a way to hande updating pixel tests?

2012-10-04 Thread Dirk Pranke
Makes sense to me ... On Thu, Oct 4, 2012 at 2:46 PM, Ojan Vafai o...@chromium.org wrote: TL;DR: We should add a NeedsRebaseline keyword to TestExpectations and add garden-o-matic tooling for it for the cases where someone commits a change/test that they know will need new results for

Re: [webkit-dev] add NeedsRebaseline keyword to TestExpectations as a way to hande updating pixel tests?

2012-10-04 Thread Stephen Chenney
I also like this idea. I particularly like the side effect of making it clear when a patch is modifying a test result that is itself not necessarily up to date. I suggest a policy that says you must rebaseline a test before committing a patch that would change that test (if the test is marked as