Re: [webkit-dev] make-script-test-wrappers not being maintained

On Sep 8, 2011, at 11:15 AM, Eric Seidel wrote: > It seems the "sucessfullyParsed" question could also be answered by > some intelligent onerror handler added to the right script tag. The "successfullyParsed" thing was originally added to benefit JS tests running in the browser. If you get a bu

Re: [webkit-dev] make-script-test-wrappers not being maintained

It seems the "sucessfullyParsed" question could also be answered by some intelligent onerror handler added to the right script tag. On Thu, Sep 8, 2011 at 10:16 AM, Ryosuke Niwa wrote: > Yeah, if the script is located at LayoutTests/resources/js-test.js for > example, all I need to type is > >

Re: [webkit-dev] make-script-test-wrappers not being maintained

Yeah, if the script is located at LayoutTests/resources/js-test.js for example, all I need to type is or ... that seems like a trivial step to me. However, I've always felt having to add var successfullyParsed = true to be annoying. Can we get rid of this variable altogether since any parsing

Re: [webkit-dev] make-script-test-wrappers not being maintained

08.09.2011, в 00:58, Ryosuke Niwa написал(а): > I'd be more annoyed by having to run a script on Terminal (and presumably > giving it a relative path from LayoutTests). FWIW, the new script supports other ways to provide the path: make-new-script-test new-test.html (will create the test in cu

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Thu, Sep 8, 2011 at 11:04 AM, Tom Zakrajsek wrote: > Wouldn't that make it so that the tests would *only* work in DRT? Yeah that's not good ;) > > > > On 09/08/2011 07:58 AM, Eric Seidel wrote: > >> We could also teach DumpRenderTree to lie about what "/" is, so we >> could include the scr

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Thu, Sep 8, 2011 at 10:58 AM, Eric Seidel wrote: > We could also teach DumpRenderTree to lie about what "/" is, so we > could include the scripts like this: > > > +1 But this goes back to solving the problem of deriving a path to the LayoutTests, other than via the DRT executable's location

Re: [webkit-dev] make-script-test-wrappers not being maintained

Wouldn't that make it so that the tests would *only* work in DRT? On 09/08/2011 07:58 AM, Eric Seidel wrote: We could also teach DumpRenderTree to lie about what "/" is, so we could include the scripts like this: On Thu, Sep 8, 2011 at 1:14 AM, Adam Barth wrote:

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Sep 8, 2011, at 10:58 AM, Eric Seidel wrote: > We could also teach DumpRenderTree to lie about what "/" is, so we > could include the scripts like this: > >

Re: [webkit-dev] make-script-test-wrappers not being maintained

We could also teach DumpRenderTree to lie about what "/" is, so we could include the scripts like this: On Thu, Sep 8, 2011 at 1:14 AM, Adam Barth wrote: > On Thu, Sep 8, 2011 at 12:41 AM, Maciej Stachowiak wrote: >> Do you have an idea for how to avoid needi

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Thu, Sep 8, 2011 at 12:41 AM, Maciej Stachowiak wrote: > > Do you have an idea for how to avoid needing to adjust the number of "../" > path segments in the path to the harness? That's the most annoying step of > the current copy/paste solution, and it does not seem like simplifying the > boile

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Sep 7, 2011, at 4:58 PM, Ojan Vafai wrote: > On Wed, Sep 7, 2011 at 4:48 PM, Alexey Proskuryakov wrote: > > 16.08.2011, в 17:45, Alexey Proskuryakov написал(а): > > >> I think that a style bot rule complaining about new files in script-tests > >> directories (outside fast/js) would be grea

Re: [webkit-dev] make-script-test-wrappers not being maintained

07.09.2011, в 17:15, Alexey Proskuryakov написал(а): >> IMO, it's only undesirable because of the current amount of boilerplate. We >> could change script test JS code so that the only boilerplate you need is: >> >> > > I don't care much personally, and only want to unblock >

Re: [webkit-dev] make-script-test-wrappers not being maintained

I've written a number of dump-as-markup tests, and I wouldn't see a need for a generator. So I'm inclined to support ojan's proposal here. - Ryosuke 2011/9/7 Alexey Proskuryakov > > 07.09.2011, в 16:58, Ojan Vafai написал(а): > > IMO, it's only undesirable because of the current amount of boil

Re: [webkit-dev] make-script-test-wrappers not being maintained

07.09.2011, в 16:58, Ojan Vafai написал(а): > IMO, it's only undesirable because of the current amount of boilerplate. We > could change script test JS code so that the only boilerplate you need is: > > I don't care much personally, and only want to unblock

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Wed, Sep 7, 2011 at 4:48 PM, Alexey Proskuryakov wrote: > > 16.08.2011, в 17:45, Alexey Proskuryakov написал(а): > > >> I think that a style bot rule complaining about new files in > script-tests directories (outside fast/js) would be great. If there are no > new script tests, then there are n

Re: [webkit-dev] make-script-test-wrappers not being maintained

16.08.2011, в 17:45, Alexey Proskuryakov написал(а): >> I think that a style bot rule complaining about new files in script-tests >> directories (outside fast/js) would be great. If there are no new script >> tests, then there are no incorrectly prepared ones. > > I'm proposing a change for ma

Re: [webkit-dev] make-script-test-wrappers not being maintained

18.01.2011, в 17:41, Alexey Proskuryakov написал(а): > I think that a style bot rule complaining about new files in script-tests > directories (outside fast/js) would be great. If there are no new script > tests, then there are no incorrectly prepared ones. I'm proposing a change for make-scri

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Jan 18, 2011, at 11:28 PM, Maciej Stachowiak wrote: > Off-topic, but... we really should change the script to use the HTML5 doctype. As you may recall, the script uses a per-directory TEMPLATE.html file. Those can be changed to the HTML5 doctype one directory at a time as long as the person

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Jan 18, 2011, at 4:50 PM, Darin Adler wrote: > On Jan 18, 2011, at 4:43 PM, Ryosuke Niwa wrote: > >> What kind of diffs you're getting for the wrappers? > > All kinds. Most are some small difference between the template and the > generated wrapper. An HTML5 DOCTYPE instead of the one in the

Re: [webkit-dev] make-script-test-wrappers not being maintained

18.01.2011, в 16:30, Darin Adler написал(а): > It seems that a lot of people are making script tests with non-standard > wrappers. And not adding exceptions to the make-script-test-wrappers script. > I ran the script and it created 4 files, and modified 33 others. > > Any ideas on how to impro

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Jan 18, 2011, at 4:49 PM, Ojan Vafai wrote: > On Tue, Jan 18, 2011 at 4:46 PM, Simon Fraser wrote: > It would be good if the generated HTML had a big in it. > > I agree this would be valuable. We should do it. > If you need a non-standard wrapper, don't put the JS file in the script-tests

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Jan 18, 2011, at 4:36 PM, James Robinson wrote: > What are the advantages of using it vs generating script tests in other ways? The concept is that you write a script test and the wrapper is automatically generated. The advantage is that you don’t have to write the wrapper yourself. The long

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Jan 18, 2011, at 4:43 PM, Ryosuke Niwa wrote: > What kind of diffs you're getting for the wrappers? All kinds. Most are some small difference between the template and the generated wrapper. An HTML5 DOCTYPE instead of the one in the wrapper. A different relative path that goes up one level f

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Tue, Jan 18, 2011 at 4:46 PM, Simon Fraser wrote: > On Jan 18, 2011, at 4:30 PM, Darin Adler wrote: > > Any ideas on how to improve the situation? > > I usually take an existing .html file for a script test and modify it. It > would be good if the generated HTML had a big in it. I agree this

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Jan 18, 2011, at 4:30 PM, Darin Adler wrote: > It seems that a lot of people are making script tests with non-standard > wrappers. And not adding exceptions to the make-script-test-wrappers script. > I ran the script and it created 4 files, and modified 33 others. I'm probably guilty of some

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Tue, Jan 18, 2011 at 4:30 PM, Darin Adler wrote: > It seems that a lot of people are making script tests with non-standard > wrappers. And not adding exceptions to the make-script-test-wrappers > script. I ran the script and it created 4 files, and modified 33 others. > > Any ideas on how to i

Re: [webkit-dev] make-script-test-wrappers not being maintained

On Tue, Jan 18, 2011 at 4:30 PM, Darin Adler wrote: > It seems that a lot of people are making script tests with non-standard > wrappers. And not adding exceptions to the make-script-test-wrappers > script. I ran the script and it created 4 files, and modified 33 others. > > Any ideas on how to i

[webkit-dev] make-script-test-wrappers not being maintained

It seems that a lot of people are making script tests with non-standard wrappers. And not adding exceptions to the make-script-test-wrappers script. I ran the script and it created 4 files, and modified 33 others. Any ideas on how to improve the situation? -- Darin