Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Gavin Barraclough
ey are. I'm not sure how the fake stack would be, would you mind explains a bit more? Did you face same problem? Thanks also for your articles that gives new ideas. rgds joe --- On Wed, 6/3/09, Zoltan Herczeg wrote: From: Zoltan Herczeg Subject: Re: [webkit-dev] stack alignment bug To:

Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Zoltan Herczeg
s://bugs.webkit.org/show_bug.cgi?id=26164 >>> Stack is originally aligned then jit code destroys it; and, some data >>> structure or point to double is not aligned and I'm still trying to >>> find >>> where they are. >>> I'm not sure how the fake

Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Gavin Barraclough
face same problem? Thanks also for your articles that gives new ideas. rgds joe --- On Wed, 6/3/09, Zoltan Herczeg wrote: From: Zoltan Herczeg Subject: Re: [webkit-dev] stack alignment bug To: "x yz" Cc: webkit-dev@lists.webkit.org Date: Wednesday, June 3, 2009, 7:35 PM Hi, true, som

Re: [webkit-dev] stack alignment bug

2009-06-04 Thread Zoltan Herczeg
new ideas. > rgds > joe > > --- On Wed, 6/3/09, Zoltan Herczeg wrote: > >> From: Zoltan Herczeg >> Subject: Re: [webkit-dev] stack alignment bug >> To: "x yz" >> Cc: webkit-dev@lists.webkit.org >> Date: Wednesday, June 3, 2009, 7:35 PM >>

Re: [webkit-dev] stack alignment bug

2009-06-03 Thread x yz
d you mind explains a bit more? Did you face same problem? Thanks also for your articles that gives new ideas. rgds joe --- On Wed, 6/3/09, Zoltan Herczeg wrote: > From: Zoltan Herczeg > Subject: Re: [webkit-dev] stack alignment bug > To: "x yz" > Cc: webkit-dev@lists.webkit.org

Re: [webkit-dev] stack alignment bug

2009-06-03 Thread Zoltan Herczeg
Hi, true, some architectures have strict policies for stack handling. Perhaps the worst one is PowerPC with its organized stack frame (back chains, pre-defined register save areas, etc). I think a fake stack pointer for JIT can solve the x86 compatibility problem. 1) allocate enough aligned stack

Re: [webkit-dev] stack alignment bug

2009-06-02 Thread Gavin Barraclough
This code is designed to keep the stack correctly aligned, and appears to be working correctly. If you think there is a bug here, please report it at bugs.webkit.org. cheers, G. On Jun 2, 2009, at 5:26 PM, x yz wrote: I don't know how to file bug so I posted here. In privateCompileCTIMa

Re: [webkit-dev] stack alignment bug

2009-06-02 Thread x yz
I don't know how to file bug so I posted here. In privateCompileCTIMachineTrampolines() there are multiple align() to align code on 16byte margin, yet, the stack can be put on 32bit margin that causes crush. Suppose original stack is aligned to 8/16bytes, the above function frequently pop/push