On Feb 4, 2010, at 1:26 PM, Chris Jerdonek wrote:
> Does this issue have any bearing on the '"using" Statements' section of the
> style guidelines?
>
> http://webkit.org/coding/coding-style.html
>
> Would it make sense to adjust them in some way in response to this issue?
Sure, once we have a
Does this issue have any bearing on the '"using" Statements' section
of the style guidelines?
http://webkit.org/coding/coding-style.html
Would it make sense to adjust them in some way in response to this issue?
--Chris
On Thu, Feb 4, 2010 at 12:01 PM, Sam Weinig wrote:
> I would be in favor of
On Feb 4, 2010, at 1:09 PM, Eric Seidel wrote:
> explicit namespaces may not play well with:
> http://trac.webkit.org/browser/trunk/JavaScriptCore/wtf/MathExtras.h
I think it’s a good point, and we should make sure MathExtras.h continues to
help smooth over platform differences in such functions
explicit namespaces may not play well with:
http://trac.webkit.org/browser/trunk/JavaScriptCore/wtf/MathExtras.h
On Thu, Feb 4, 2010 at 1:06 PM, Darin Adler wrote:
> On Feb 4, 2010, at 12:01 PM, Sam Weinig wrote:
>
>> I would be in favor of fixing the existing uses by using explicit std::isin
On Feb 4, 2010, at 12:01 PM, Sam Weinig wrote:
> I would be in favor of fixing the existing uses by using explicit std::isinf.
Me too.
-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/we
I would be in favor of fixing the existing uses by using explicit
std::isinf.
-Sam
On Wed, Feb 3, 2010 at 5:07 PM, Chris Rogers wrote:
> Basically, if you include then it undefines the functions (or
> macros) for isinf(), isnan(), and others, and then expects you
> to use std::isinf(), std::is
Basically, if you include then it undefines the functions (or
macros) for isinf(), isnan(), and others, and then expects you
to use std::isinf(), std::isnan() instead. We use these functions in a
number of places, so we'd need to figure out a reasonable solution.
Or just go with my original class
What specific errors are you getting? I don't understand why including a
standard header would break other standard functions.
-Sam
On Wed, Feb 3, 2010 at 3:22 PM, Chris Rogers wrote:
> I initially put in a patch for a class for Complex numbers, but people
> preferred that I just use the std::c
I initially put in a patch for a class for Complex numbers, but people
preferred that I just use the std::complex version.
In the process of switching my code over to use std::complex I noticed a
conflict with isinf(), isnan(), etc.
The problem is that simply including:
#include
breaks the isin
9 matches
Mail list logo
