Re: [webkit-dev] use of isnan with integers (QNX gcc)

2011-07-22 Thread Darin Adler
On Jul 22, 2011, at 2:16 AM, Shkrablyuk, Pavel wrote: > Is there really a reason to check for ‘isnan’ of integer values in > WebGLRenderingContext::viewport? No. If there is a need to handle non-numeric values in the JavaScript binding, then that has to be done in the JavaScript binding machin

[webkit-dev] use of isnan with integers (QNX gcc)

2011-07-22 Thread Shkrablyuk, Pavel
Here's code from 'WebCore/html/canvas/WebGLRenderingContext.cpp' WebGLRenderingContext::viewport(GC3Dint x, GC3Dint y, GC3Dsizei width, GC3Dsizei height) { if (isContextLost()) return; if (isnan(x)) x = 0; if (isnan(y)) y = 0; if (isnan(width)) widt