Re: [webkit-dev] where should tests reside? tests/preload v. tests/loading

2017-11-08 Thread Ryosuke Niwa
All those grep for test path inside test runner should go away and be replaced with test runner flags. - R. Niwa On Wed, Nov 8, 2017 at 7:19 AM, Colin Bendell | +1.613.914.3387 < co...@bendell.ca> wrote: > On 8 November 2017 at 09:57, Konstantin Tokarev wrote: > > >> 2) how is the debug level e

Re: [webkit-dev] where should tests reside? tests/preload v. tests/loading

2017-11-08 Thread Colin Bendell | +1.613.914.3387
On 8 November 2017 at 09:57, Konstantin Tokarev wrote: >> 2) how is the debug level enabled for http/tests/loading? Is there a >> way to control this threshold programatically in the test? > > This is printed by InjectedBundle used in testing > (see Tools/WebKitTestRunner/InjectedBundle/InjectedB

Re: [webkit-dev] where should tests reside? tests/preload v. tests/loading

2017-11-08 Thread Konstantin Tokarev
08.11.2017, 17:54, "Colin Bendell | +1.613.914.3387" : > I'm chasing down racy logging with one of my tests and I've noticed > some duplication for preloader tests. Specifically: > 1) when should you organize preload tests in > LayoutTests/http/tests/preload v. > LayoutTests/http/tests/loading/pr

[webkit-dev] where should tests reside? tests/preload v. tests/loading

2017-11-08 Thread Colin Bendell | +1.613.914.3387
I'm chasing down racy logging with one of my tests and I've noticed some duplication for preloader tests. Specifically: 1) when should you organize preload tests in LayoutTests/http/tests/preload v. LayoutTests/http/tests/loading/preload*? I'm assuming that the real reason is the debug level? 2) h