Re: [webkit-dev] Coding convention of constants

2009-07-10 Thread Geoffrey Garen
Ditto. The last time I wondered about this, I grepped through the code and found [1] to be the most prevalent. So, in code reviews I have been recommending people do [1]. I think that's the nicest style (just like a variable, no special prefix). Let's go with that and update the coding st

Re: [webkit-dev] Coding convention of constants

2009-07-09 Thread Maciej Stachowiak
On Jul 9, 2009, at 8:55 PM, Darin Fisher wrote: Ditto. The last time I wondered about this, I grepped through the code and found [1] to be the most prevalent. So, in code reviews I have been recommending people do [1]. I think that's the nicest style (just like a variable, no special p

Re: [webkit-dev] Coding convention of constants

2009-07-09 Thread Darin Fisher
Ditto. The last time I wondered about this, I grepped through the code and found [1] to be the most prevalent. So, in code reviews I have been recommending people do [1]. -Darin On Thu, Jul 9, 2009 at 8:16 PM, Dimitri Glazkov wrote: > If we're voting, then +1 to [1]. If we're not voting, then o

Re: [webkit-dev] Coding convention of constants

2009-07-09 Thread Dimitri Glazkov
If we're voting, then +1 to [1]. If we're not voting, then oops. :DG< On Thu, Jul 9, 2009 at 12:50 PM, Darin Adler wrote: > On Jul 8, 2009, at 9:08 PM, KwangYul Seo wrote: > > I found another style which starts with "k". > [4] platform/chromium/PopupMenuChromium.cpp > static const int kMaxVisible

Re: [webkit-dev] Coding convention of constants

2009-07-09 Thread Scott Thompson
On Jul 8, 2009, at 11:08 PM, KwangYul Seo wrote: I found another style which starts with "k". [4] platform/chromium/PopupMenuChromium.cpp static const int kMaxVisibleRows = 20; static const int kMaxHeight = 500; static const int kBorderSize = 1; static const TimeStamp kTypeAheadTimeoutMs = 10

Re: [webkit-dev] Coding convention of constants

2009-07-09 Thread Darin Adler
On Jul 8, 2009, at 9:08 PM, KwangYul Seo wrote: I found another style which starts with "k". [4] platform/chromium/PopupMenuChromium.cpp static const int kMaxVisibleRows = 20; static const int kMaxHeight = 500; static const int kBorderSize = 1; static const TimeStamp kTypeAheadTimeoutMs = 1000

Re: [webkit-dev] Coding convention of constants

2009-07-08 Thread KwangYul Seo
I found another style which starts with "k". [4] platform/chromium/PopupMenuChromium.cpp static const int kMaxVisibleRows = 20; static const int kMaxHeight = 500; static const int kBorderSize = 1; static const TimeStamp kTypeAheadTimeoutMs = 1000; 2009/7/9 KwangYul Seo > Hi, > It seems that t